From patchwork Fri Jul 21 11:33:52 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Russell King (Oracle)" X-Patchwork-Id: 13321919 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 22C7BEB64DC for ; Fri, 21 Jul 2023 11:36:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Subject:Cc:To: From:Date:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=YImK4Vmy13aMHcQeVsI3nwPM4vl+RS1Hly/UOX3RSjk=; b=2yuersGWxki82h vYv42Ic9YyUN+rVz9h7aOVKkjSq3R4sWNj5zSlsSLTwMAn74REnfiBjv3oYW8XK/J/946cYsqOCIq OjWDhWy5XgFEonJoT83legoGrHjhsRYkbhrju33g/S1HAxn5pEfTNwq/YYFzZiz8IpWIL2b/rqq5G 4UZZVsa/2Q827+CGKoJUvWbUNgVOOBOCQwMay1UUmAKtn1d1DN1NvRbjLtCqR8Z8pP07a3UFbRyyq 9DRPnUWlawKl81sbZugKF0NUx6RydXZz+7VtPSDeGu+aA5vXysEd7iQ2Y2ZY7LbzKUR3jm4yxY3Di cXDgMdqrP0PF0J5V/QuA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qMoQr-00DwoM-1Y; Fri, 21 Jul 2023 11:36:25 +0000 Received: from pandora.armlinux.org.uk ([2001:4d48:ad52:32c8:5054:ff:fe00:142]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qMoQn-00DwPx-2y; Fri, 21 Jul 2023 11:36:23 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:Content-Type:MIME-Version: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=iItSOdqqfSgaHaVttPNHC8a08UlOwZdEhpHuVWdhpGE=; b=0RXfcyA8km5soyBIeESvbsuQbU 8Ug+GTC9bUzujdfG/M19pdrz94nRjBagXuQqpl+yBW4/L9YGyJKPzBG97jTARieRmq9hIZdonzrpb /HkUOHtfwlDgOK07F1qGCusEAVmCu1V3IZwsMHJZZdIx85aGwuJk+TcFTQGtTdT7XCp2vlzM4W4c3 WAJhhjokbAfr+lVzcNk41jxy3YBI22O2CWG4rJmvTZzGj4y8tQx6BB3vLhbWkLdTMzht4KSVXb7wk K3l1AjxAbZdl2Wh/Y2VGzNdQDON01kY8+e+pW4HyswSxYhcvmz/1H5DHCxojGTf7INnJNLmD1F+q7 WpcvwrXA==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:39288) by pandora.armlinux.org.uk with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1qMoOT-0003nN-2d; Fri, 21 Jul 2023 12:33:57 +0100 Received: from linux by shell.armlinux.org.uk with local (Exim 4.94.2) (envelope-from ) id 1qMoOO-00065a-4i; Fri, 21 Jul 2023 12:33:52 +0100 Date: Fri, 21 Jul 2023 12:33:52 +0100 From: "Russell King (Oracle)" To: Andrew Lunn , Heiner Kallweit , DanielGolle , =?utf-8?b?QXLEsW7DpyDDnE5BTA==?= , Frank Wunderlich , David Woodhouse Cc: AngeloGioacchino Del Regno , "David S. Miller" , Eric Dumazet , Felix Fietkau , Jakub Kicinski , John Crispin , linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, Lorenzo Bianconi , Mark Lee , Matthias Brugger , netdev@vger.kernel.org, Paolo Abeni , Sean Wang Subject: [PATCH net-next 0/4] Remove legacy phylink behaviour Message-ID: MIME-Version: 1.0 Content-Disposition: inline X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230721_043621_985082_1600DA84 X-CRM114-Status: GOOD ( 12.48 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi, This series removes the - as far as I can tell - unreachable code in mtk_eth_soc that relies upon legacy phylink behaviour, and then removes the support in phylink for this legacy behaviour. Patch 1 removes the clocking configuration from mtk_eth_soc for non- TRGMII, non-serdes based interface modes, and disables those interface modes prior to phylink configuration. Patch 2 removes the mac_pcs_get_state() method from mtk_eth_soc which I believe is also not used - mtk_eth_soc appears not to be used with SFPs (which would use a kind of in-band mode) nor does any DT appear to specify in-band mode for any non-serdes based interface mode. With both of those dealt with, the kernel is now free of any driver relying on the phylink legacy mode. Therefore, patch 3 removes support for this. Finally, with the advent of a new driver being submitted today that makes use of state->speed in the mac_config() path, patch 4 ensures that any phylink_link_state member that should not be used in mac_config is either cleared or set to an invalid value. drivers/net/ethernet/mediatek/mtk_eth_soc.c | 94 +++++------------------------ drivers/net/ethernet/mediatek/mtk_eth_soc.h | 1 + drivers/net/phy/phylink.c | 48 ++++++--------- include/linux/phylink.h | 45 ++------------ 4 files changed, 42 insertions(+), 146 deletions(-) Reviewed-by: Daniel Golle Tested-by: Daniel Golle