From patchwork Sun Feb 4 12:12:43 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Russell King (Oracle)" X-Patchwork-Id: 13544636 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 295D5C4828F for ; Sun, 4 Feb 2024 12:13:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Subject:Cc:To: From:Date:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=uIdaGSiV4vws+AQ+7LrzDNbl484bYMqyO2kDP41ToUk=; b=UUTtbsNyRyxkfe iV0145h+jo8o5Gqnopa6TRogiYZlY54Dk7IMUgJqXgBLyVVNtQHIY4jFGjGhHPafLWTQgI22ygzZz xdCiD2Y98A4HZL466agAgOoq8Sl530vvdZjqZA1vhruYVrDbPYs0mLzoSR15LxzI+8UnVuqCJjzc7 QGSuB5sJaYDD8bWIPSB0CZqoPQhP067cfPEFJzIt02oF27MjUCMwF7/g2N6rdq3Lh+Xj9sxA42TMg aip/fRgjVUufbqNU7xOR0iR7WoMBH0vYzehfAmC4UsnUw8QDGoqe1zYs93bNnwtGQt6dO9mb0W1Gu /5glHMV6uZrgXnMNnL9w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rWbMv-00000000ia4-3PvC; Sun, 04 Feb 2024 12:13:05 +0000 Received: from pandora.armlinux.org.uk ([2001:4d48:ad52:32c8:5054:ff:fe00:142]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rWbMt-00000000iZk-0PSK for linux-arm-kernel@lists.infradead.org; Sun, 04 Feb 2024 12:13:04 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:Content-Type:MIME-Version: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=tfFGQOv5/GrEK0+zIwugqFLOB+gCx2wHcbHq6NIW+nA=; b=D3umHcB1QiRfAsodNiW0F/EiA3 N3PiKr6gAVsu+YU/rw0WbxSwT6//3WFYU8I6qjtJBUC5S97kCGEmR7iENHpIOtG1w6jIxOeR4bClY V8unQnz0io3vRrv/ka7MEEB1qP5lBrSkQ8iR1Uma/PnrHJFvgNYzebSHbiG3N1EaIUumRx0b5wB++ NpCxx0JzT1ZlHpuZSUERS9/vnBWzim/kUEJaCcVkWahed6YZrzGVDs4GYfkng6dHdQERV0lruNxHt ThzezR/v8iye6UN2NHTK1uKRnNnwk5nQEZk8CZ7kAPQtk4FWvvxsCnaqlRtkWSFNlkckTiyB/ZIxG LiYvTmLw==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:55160) by pandora.armlinux.org.uk with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1rWbMf-0007vK-34; Sun, 04 Feb 2024 12:12:51 +0000 Received: from linux by shell.armlinux.org.uk with local (Exim 4.94.2) (envelope-from ) id 1rWbMZ-0001ke-TI; Sun, 04 Feb 2024 12:12:43 +0000 Date: Sun, 4 Feb 2024 12:12:43 +0000 From: "Russell King (Oracle)" To: Andrew Lunn , Heiner Kallweit Cc: Alexandre Torgue , bcm-kernel-feedback-list@broadcom.com, Byungho An , Clark Wang , "David S. Miller" , Doug Berger , Eric Dumazet , Florian Fainelli , Jakub Kicinski , Jose Abreu , Justin Chen , linux-arm-kernel@lists.infradead.org, linux-stm32@st-md-mailman.stormreply.com, Maxime Coquelin , netdev@vger.kernel.org, NXP Linux Team , Paolo Abeni , Shenwei Wang , Vladimir Oltean , Wei Fang Subject: [PATCH net-next v2 0/6] net: eee network driver cleanups Message-ID: MIME-Version: 1.0 Content-Disposition: inline X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240204_041303_162439_8F472CAF X-CRM114-Status: UNSURE ( 8.47 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi, Since commit d1420bb99515 ("net: phy: improve generic EEE ethtool functions") changed phylib to set eee->eee_active and eee->eee_enabled, overriding anything that drivers have set these to prior to calling phy_ethtool_get_eee(). Therefore, drivers setting these members becomes redundant, since phylib overwrites the values they set. This series finishes off Heiner's work in the referenced commit by removing these redundant writes in various drivers and any associated code or structure members that become unnecessary. v2: Address Andrew's comment on fec_main.c drivers/net/dsa/b53/b53_common.c | 6 ------ drivers/net/ethernet/broadcom/asp2/bcmasp_ethtool.c | 4 ---- drivers/net/ethernet/broadcom/asp2/bcmasp_intf.c | 5 +++-- drivers/net/ethernet/broadcom/genet/bcmgenet.c | 8 +++----- drivers/net/ethernet/broadcom/genet/bcmmii.c | 5 +++-- drivers/net/ethernet/freescale/fec_main.c | 4 ---- drivers/net/ethernet/samsung/sxgbe/sxgbe_common.h | 1 - drivers/net/ethernet/samsung/sxgbe/sxgbe_ethtool.c | 2 -- drivers/net/ethernet/samsung/sxgbe/sxgbe_main.c | 1 - drivers/net/ethernet/stmicro/stmmac/stmmac_ethtool.c | 2 -- 10 files changed, 9 insertions(+), 29 deletions(-)