From patchwork Tue Aug 28 17:56:48 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Michal Kubecek X-Patchwork-Id: 10578929 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 6A6A7175A for ; Tue, 28 Aug 2018 17:57:59 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 531382A22A for ; Tue, 28 Aug 2018 17:57:59 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 43C422A776; Tue, 28 Aug 2018 17:57:59 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.9 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id DA4282A22A for ; Tue, 28 Aug 2018 17:57:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:Date:To:Subject: From:Message-Id:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To: References:List-Owner; bh=ruK11JtpTFeqvNGFypGz0O+VC1C/I9fuN7CagYvj4Uw=; b=U9L fYsx72go8MZ1VDEQr63MG3IxFiAYZ2xhnXGpBswiML7N0gYsUNZPFFYm7Pf/buD+W76s5qAcuanM+ SmT1Hmz3TggTRut1n/VmZzF2wy8Y2l7QD7ZcgbkFOXeFtvbqEMqQBKreNFt4CFFn/cXuuMj1J5rsi jSDOxzAtWwmlGOzoB95Df2H0EKI1JJ7n4pBNG34e+cWF9ImVvjHUab0W6eC3q5fm2MmxZLM4V+ltP ly04AMBjdX2orcw8RE10QJQlq7C02CML4vTw3uKB2/iHUEB9+3OtkyKaoc0dktPFtNkBXgpQdS2V1 9R4t9r0E8AtdgWJ65Rnq/CvXJGOeQGg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1fuiFQ-00052o-LS; Tue, 28 Aug 2018 17:57:48 +0000 Received: from mx2.suse.de ([195.135.220.15] helo=mx1.suse.de) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1fuiEi-0004fN-5I for linux-arm-kernel@lists.infradead.org; Tue, 28 Aug 2018 17:57:25 +0000 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id F1ED4AD85; Tue, 28 Aug 2018 17:56:49 +0000 (UTC) Received: by unicorn.suse.cz (Postfix, from userid 1000) id 5FFAFA0C37; Tue, 28 Aug 2018 19:56:48 +0200 (CEST) Message-Id: From: Michal Kubecek Subject: [PATCH net-next 0/2] ethtool: drop get_settings and set_settings ops To: "David S. Miller" Date: Tue, 28 Aug 2018 19:56:48 +0200 (CEST) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20180828_105704_370685_00CABCBB X-CRM114-Status: UNSURE ( 8.59 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Andrew Lunn , Florian Fainelli , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Russell King , linux-arm-kernel@lists.infradead.org MIME-Version: 1.0 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP As Andrew Lunn pointed out in recent discussion, there is only one in tree driver left which still defines deprecated callbacks get_settings() and set_settings() in ethtool_ops. First patch converts this driver to get_link_ksettings() and set_link_ksettings(). Second patch then removes the deprecated callbacks from struct ethtool_ops and ethtool code which falls back to them. This doesn't break old versions of ethtool or any other userspace code using ETHTOOL_{G,S}SET. We still implement both (old) ETHTOOL_{G,S}SET and (new) ETHTOOL_{G,S}LINKSETTINGS ioctl commands but after this series both will be implemented only using {g,s}et_link_ksettings(). The only affected code would be out of tree NIC drivers which have not been converted yet. Michal Kubecek (2): 8390/etherh: convert to ethtool_{get,set}_link_ksettings ethtool: drop get_settings and set_settings callbacks Documentation/ABI/testing/sysfs-class-net | 4 +- drivers/net/ethernet/8390/etherh.c | 35 ++--- include/linux/ethtool.h | 33 ++--- include/uapi/linux/ethtool.h | 15 +- net/core/ethtool.c | 158 +++++----------------- 5 files changed, 69 insertions(+), 176 deletions(-)