From patchwork Sun Mar 3 07:44:39 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: William Breathitt Gray X-Patchwork-Id: 10836975 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id D48791669 for ; Sun, 3 Mar 2019 07:44:36 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id B638A2A143 for ; Sun, 3 Mar 2019 07:44:36 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id A3ADC2A145; Sun, 3 Mar 2019 07:44:36 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=2.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FROM,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 2C2C02A143 for ; Sun, 3 Mar 2019 07:44:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:To :From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=Tq0KJt0+4d09DlPcP1VvyI0OFeFDViaNJAakDdy/A1U=; b=OZQ/acbsnUdeDc zFbFjEHH/hB4Atzs8pbhv4GE34FndDxuRT3Aal1wLitgMI6ogrj8rcr0C62bJJ7OWVZVHcGOLE+vJ ytB42O5UP+5g3pKqDJ6Xf64ATBYnPg6baHTUFqGX1opQkrzKfsHZQ4kQSDZHRJpEL4JPezHeTbwxK re2BzuITIKUY6uYKfjssDd4Wqgqm8iM3jIobrkvLg/ITg18mFuQg1T0cLJKRwYO/1XpiFpyGddfSo kaRVFVuq2VJTh2VDMO3BnZYC9C1mkvQ4EW//e3dZU9MJoSGcjQBTo1jaiTFN8ObINpEi6JwL7bQGo e7y+NS4lCkFoXWctcDeQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1h0LnS-0006G7-JF; Sun, 03 Mar 2019 07:44:30 +0000 Received: from mail-pf1-x442.google.com ([2607:f8b0:4864:20::442]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1h0LnP-0006Eb-2V for linux-arm-kernel@lists.infradead.org; Sun, 03 Mar 2019 07:44:28 +0000 Received: by mail-pf1-x442.google.com with SMTP id j5so969285pfa.2 for ; Sat, 02 Mar 2019 23:44:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=FTGLQuMzA6NXFSyBaP9yP3iqhOjyb5SMy1QH7j0ioDk=; b=nPEjXNC8eHDuVCCKg0hFBeTWLkXIf9gug1s8tDZkRAH4veV1F6D0HNzqgyWB5OXOvF VhnhkAxOpVeWFdWrklMSbvHgs66ptkg5mlf8xjj2ESbwi2ktE0F8KISHLct2AEyeWSn+ /0NNxL5lRThwY+qOfPjXvNLIzsCOplg0rb2zcVSRD4XF1MFCyKJn//a1QMepNwUNQ5fJ QzQOe1jW9eaVBEwFicONRSh33lJGqSyPYRrDgciTA4GFfSt6Zgd3CJnBTZPMRr3YVhR8 Fy6LHKqcir6trUMbU3gX7y89Ea22XKOXCP1Mp8PKrA6KYpcr2ZJXk7s07KiYrLOzJ5Nz qZgA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=FTGLQuMzA6NXFSyBaP9yP3iqhOjyb5SMy1QH7j0ioDk=; b=Hp9R4JGjS1xUoFN/JIXcPd4fhLc8pLnjgtRL9Xb/ko5ba4bt7CENuaaylJj6AD4JCH 6MkxN+4/Ig/RLQyOHCG1S95a27qva7dKpkc29IfOG9iYF3AYcgTuKp5/1p56wQJv5E2E Jz/d05cM7nu3Q6lLHf081tmzHls5+MZEsYFzE5egvh+6DypRe/5kENVjM7j7txMPpW1E MK7BIOAfJ/eB/7sNT0VXwPj/WEKYK5XW/9xwFIvkgn7fRziohPdB5dHur9z6rDTeofPJ C1PAx1LnxpYYwwQJYGE7tswGtbCpSlh315vM+XDYeDvFZHhiJ1//41QqHQ+uDnEqDzWu cgwA== X-Gm-Message-State: APjAAAX2w7/RuUwM3ZbvLQgUktfyMfQ0WDLQA5p/iAn2Fu5q5+MsgXZB 3/jFLLaHAgY2lwhzj690Aak= X-Google-Smtp-Source: APXvYqy8++rSVrwPju2JVlF/IVz2MhoJ6re+mU8TZ7A9KEwvMCt5ualJFTnG1r9P5E0cIKGviivqXg== X-Received: by 2002:a63:de48:: with SMTP id y8mr3745654pgi.253.1551599063897; Sat, 02 Mar 2019 23:44:23 -0800 (PST) Received: from localhost.localdomain ([2001:268:c0a5:3b5c:c70:4af9:86e2:2]) by smtp.gmail.com with ESMTPSA id f8sm3453113pgs.77.2019.03.02.23.44.18 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 02 Mar 2019 23:44:22 -0800 (PST) From: William Breathitt Gray To: linus.walleij@linaro.org Subject: [PATCH v9 0/9] Introduce the for_each_set_clump8 macro Date: Sun, 3 Mar 2019 16:44:39 +0900 Message-Id: X-Mailer: git-send-email 2.21.0 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190302_234427_141985_A1D19294 X-CRM114-Status: GOOD ( 12.42 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-arch@vger.kernel.org, yamada.masahiro@socionext.com, linux@rasmusvillemoes.dk, linux-kernel@vger.kernel.org, William Breathitt Gray , linux-gpio@vger.kernel.org, bgolaszewski@baylibre.com, akpm@linux-foundation.org, andriy.shevchenko@linux.intel.com, linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP Changes in v9: - Return unsigned long for bitmap_get_value8 for consistency While adding GPIO get_multiple/set_multiple callback support for various drivers, I noticed a pattern of looping manifesting that would be useful standardized as a macro. This patchset introduces the for_each_set_clump8 macro and utilizes it in several GPIO drivers. The for_each_set_clump macro8 facilitates a for-loop syntax that iterates over a memory region entire groups of set bits at a time. For example, suppose you would like to iterate over a 32-bit integer 8 bits at a time, skipping over 8-bit groups with no set bit, where XXXXXXXX represents the current 8-bit group: Example: 10111110 00000000 11111111 00110011 First loop: 10111110 00000000 11111111 XXXXXXXX Second loop: 10111110 00000000 XXXXXXXX 00110011 Third loop: XXXXXXXX 00000000 11111111 00110011 Each iteration of the loop returns the next 8-bit group that has at least one set bit. The for_each_set_clump8 macro has four parameters: * start: set to the bit offset of the current clump * clump: set to the current clump value * bits: bitmap to search within * size: bitmap size in number of bits In this version of the patchset, the for_each_set_clump macro has been reimplemented and simplified based on the suggestions provided by Rasmus Villemoes and Andy Shevchenko in the version 4 submission. In particular, the function of the for_each_set_clump macro has been restricted to handle only 8-bit clumps; the drivers that use the for_each_set_clump macro only handle 8-bit ports so a generic for_each_set_clump implementation is not necessary. Thus, a solution for large clumps (i.e. those larger than the width of a bitmap word) can be postponed until a driver appears that actually requires such a generic for_each_set_clump implementation. For what it's worth, a semi-generic for_each_set_clump (i.e. for clumps smaller than the width of a bitmap word) can be implemented by simply replacing the hardcoded '8' and '0xFF' instances with respective variables. I have not yet had a need for such an implementation, and since it falls short of a true generic for_each_set_clump function, I have decided to forgo such an implementation for now. In addition, the bitmap_get_value8 and bitmap_set_value8 functions are introduced to get and set 8-bit values respectively. Their use is based on the behavior suggested in the patchset version 4 review. William Breathitt Gray (9): bitops: Introduce the for_each_set_clump8 macro lib/test_bitmap.c: Add for_each_set_clump8 test cases gpio: 104-dio-48e: Utilize for_each_set_clump8 macro gpio: 104-idi-48: Utilize for_each_set_clump8 macro gpio: gpio-mm: Utilize for_each_set_clump8 macro gpio: ws16c48: Utilize for_each_set_clump8 macro gpio: pci-idio-16: Utilize for_each_set_clump8 macro gpio: pcie-idio-24: Utilize for_each_set_clump8 macro gpio: uniphier: Utilize for_each_set_clump8 macro drivers/gpio/gpio-104-dio-48e.c | 73 ++++++-------------- drivers/gpio/gpio-104-idi-48.c | 37 +++------- drivers/gpio/gpio-gpio-mm.c | 73 ++++++-------------- drivers/gpio/gpio-pci-idio-16.c | 75 ++++++++------------ drivers/gpio/gpio-pcie-idio-24.c | 111 +++++++++++------------------- drivers/gpio/gpio-uniphier.c | 16 ++--- drivers/gpio/gpio-ws16c48.c | 72 ++++++------------- include/asm-generic/bitops/find.h | 14 ++++ include/linux/bitops.h | 5 ++ lib/find_bit.c | 81 ++++++++++++++++++++++ lib/test_bitmap.c | 65 +++++++++++++++++ 11 files changed, 313 insertions(+), 309 deletions(-)