From patchwork Thu Mar 14 12:29:32 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: William Breathitt Gray X-Patchwork-Id: 10852707 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id E306D139A for ; Thu, 14 Mar 2019 12:28:58 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id C84662A37B for ; Thu, 14 Mar 2019 12:28:58 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id B9B4E2A3AF; Thu, 14 Mar 2019 12:28:58 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=2.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FROM,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 4688B2A37B for ; Thu, 14 Mar 2019 12:28:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:To :From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=uR+S0pz2tF4wnvOk0Pg0E/h8QuQyJi2W0wDvwtXaci4=; b=q0/S/Vq3mn/iYo wVA28Rb5SUe0pQH45+IiU/iyJ1CrB7lpLYsk8vu2KgoQsbdBMtGkWZq3AOwUEgc8djwAYsYC7M/lz uAqItR+vJYrB8mhjsoQrifet9IuvSel+H1ucPO9WEWMLbjUoLBuE4AVkJNM973cJng6QneuxnQk7U TM3Z1OIL0vMFaEr82WamneNCUqZcjVsd5auWyiu39xaRDurR8kMHilgc/od3j+g8kVdQVO82eCFdp cURWUramZYCWx1X9i+NUyseOje/Nck1dy69X8tQruFa4oq43jKV5Gx+zEFXUdN8h3zYpt5DsLRzbL WK4Gzs7s+zlY/ZuR3leg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1h4PTk-00052Z-VF; Thu, 14 Mar 2019 12:28:56 +0000 Received: from mail-pg1-x544.google.com ([2607:f8b0:4864:20::544]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1h4PTh-00051s-O0 for linux-arm-kernel@lists.infradead.org; Thu, 14 Mar 2019 12:28:55 +0000 Received: by mail-pg1-x544.google.com with SMTP id 125so3847543pgc.12 for ; Thu, 14 Mar 2019 05:28:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=rcs1W5Jh624cN3abC6U54hsK7ZVCAgD4qFr+RxJnwoI=; b=ucvx4teWDRapdA2DUZ9Kz4dAnm0IXfdail/FxZyGhWkKFv/hVLISZlX+vY+nuWllhI b9PaU+lNzTXRc6Qh20CwP/7KuDl5KM6tjMril4hSlt4oAbNuzmWHyRWrKz2oO95Sgw/z RyytYaCLEqeWVfyl3opQ1ipR3jMLCHGVc9F8sgCqR5YiU4LNjs+eiMtw5mHy6+kTOxk+ nRXm+idIXMMy3+qgd0mbu7BkO7x4vgGgSrc3SKWmrlMC89MoO0pq2XXFRVvY9/oooOIq 7FHla0mHc5NkLEje6KRfobU129bgUmoSnloDvoZlaFraE/0SG8297uENCgWBovI0wTNS 2T+w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=rcs1W5Jh624cN3abC6U54hsK7ZVCAgD4qFr+RxJnwoI=; b=iwffj6mpDIKe0VkOtv1K/lW56l+woXD9q4bykkwLjUkCz/Y/6A3GXLUjBar6T8J9YQ an+Csesr7LktSMu3L1vhVw0qEtWd3h23oxAE6QBgo+Rmj5rvt5E20Y0OP+chPCOyI3oD f3F1hzfcbCiCinjTYr/j0Ixf+VtdxKg/JpNKdf1QWebrZvVnytOirq+PAbE6UUG0oogX ys2tllNM0JT6MKmeWzndjc8KqVc0w5WYiQ+mJj2BMbPtNwzZe0dd67Htji6babopKFcv 3Pc9W1ykQu3OXjYPY+0xcoau3gAtivuRE3VG24MOLNuCFJnqFol84PaWf0WLU5JGGryR tWwA== X-Gm-Message-State: APjAAAX5QqeLb260l9ykiRBfktBspBgtz4WEsYtI9mLCB0KO0AIitd1Q fXzCsY30bFd2rK7wZ3Nk8t4= X-Google-Smtp-Source: APXvYqzXssN3eikufA+LnFExGlKx7CTmGCdXPBFPF8edj/HXTe96DYLSwiUieK75lWipOj8ejMmh0w== X-Received: by 2002:a17:902:8c84:: with SMTP id t4mr24716031plo.298.1552566531458; Thu, 14 Mar 2019 05:28:51 -0700 (PDT) Received: from localhost.localdomain ([2001:268:c0a4:3974:c70:4af9:86e2:2]) by smtp.gmail.com with ESMTPSA id m13sm30073685pff.175.2019.03.14.05.28.46 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 14 Mar 2019 05:28:50 -0700 (PDT) From: William Breathitt Gray To: linus.walleij@linaro.org Subject: [PATCH v10 00/10] Introduce the for_each_set_clump8 macro Date: Thu, 14 Mar 2019 21:29:32 +0900 Message-Id: X-Mailer: git-send-email 2.21.0 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190314_052853_808368_959055FB X-CRM114-Status: GOOD ( 13.32 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-arch@vger.kernel.org, yamada.masahiro@socionext.com, linux@rasmusvillemoes.dk, linux-kernel@vger.kernel.org, William Breathitt Gray , linux-gpio@vger.kernel.org, bgolaszewski@baylibre.com, akpm@linux-foundation.org, andriy.shevchenko@linux.intel.com, linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP Changes in v10: - Fix off-by-one error in bitmap initialization in the test_for_each_set_clump8 function - Fix typos in clump_exp array definition in test_bitmap.c ("0x28" should have been "0x38") - Utilize for_each_set_clump8 macro in intel_soc_dts_iosf.c While adding GPIO get_multiple/set_multiple callback support for various drivers, I noticed a pattern of looping manifesting that would be useful standardized as a macro. This patchset introduces the for_each_set_clump8 macro and utilizes it in several GPIO drivers. The for_each_set_clump macro8 facilitates a for-loop syntax that iterates over a memory region entire groups of set bits at a time. For example, suppose you would like to iterate over a 32-bit integer 8 bits at a time, skipping over 8-bit groups with no set bit, where XXXXXXXX represents the current 8-bit group: Example: 10111110 00000000 11111111 00110011 First loop: 10111110 00000000 11111111 XXXXXXXX Second loop: 10111110 00000000 XXXXXXXX 00110011 Third loop: XXXXXXXX 00000000 11111111 00110011 Each iteration of the loop returns the next 8-bit group that has at least one set bit. The for_each_set_clump8 macro has four parameters: * start: set to the bit offset of the current clump * clump: set to the current clump value * bits: bitmap to search within * size: bitmap size in number of bits In this version of the patchset, the for_each_set_clump macro has been reimplemented and simplified based on the suggestions provided by Rasmus Villemoes and Andy Shevchenko in the version 4 submission. In particular, the function of the for_each_set_clump macro has been restricted to handle only 8-bit clumps; the drivers that use the for_each_set_clump macro only handle 8-bit ports so a generic for_each_set_clump implementation is not necessary. Thus, a solution for large clumps (i.e. those larger than the width of a bitmap word) can be postponed until a driver appears that actually requires such a generic for_each_set_clump implementation. For what it's worth, a semi-generic for_each_set_clump (i.e. for clumps smaller than the width of a bitmap word) can be implemented by simply replacing the hardcoded '8' and '0xFF' instances with respective variables. I have not yet had a need for such an implementation, and since it falls short of a true generic for_each_set_clump function, I have decided to forgo such an implementation for now. In addition, the bitmap_get_value8 and bitmap_set_value8 functions are introduced to get and set 8-bit values respectively. Their use is based on the behavior suggested in the patchset version 4 review. William Breathitt Gray (10): bitops: Introduce the for_each_set_clump8 macro lib/test_bitmap.c: Add for_each_set_clump8 test cases gpio: 104-dio-48e: Utilize for_each_set_clump8 macro gpio: 104-idi-48: Utilize for_each_set_clump8 macro gpio: gpio-mm: Utilize for_each_set_clump8 macro gpio: ws16c48: Utilize for_each_set_clump8 macro gpio: pci-idio-16: Utilize for_each_set_clump8 macro gpio: pcie-idio-24: Utilize for_each_set_clump8 macro gpio: uniphier: Utilize for_each_set_clump8 macro thermal: intel: intel_soc_dts_iosf: Utilize for_each_set_clump8 macro drivers/gpio/gpio-104-dio-48e.c | 73 ++++---------- drivers/gpio/gpio-104-idi-48.c | 37 ++----- drivers/gpio/gpio-gpio-mm.c | 73 ++++---------- drivers/gpio/gpio-pci-idio-16.c | 75 ++++++-------- drivers/gpio/gpio-pcie-idio-24.c | 111 ++++++++------------- drivers/gpio/gpio-uniphier.c | 16 ++- drivers/gpio/gpio-ws16c48.c | 72 ++++--------- drivers/thermal/intel/intel_soc_dts_iosf.c | 29 +++--- drivers/thermal/intel/intel_soc_dts_iosf.h | 2 - include/asm-generic/bitops/find.h | 14 +++ include/linux/bitops.h | 5 + lib/find_bit.c | 81 +++++++++++++++ lib/test_bitmap.c | 65 ++++++++++++ 13 files changed, 330 insertions(+), 323 deletions(-)