From patchwork Mon Mar 25 06:20:44 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: William Breathitt Gray X-Patchwork-Id: 10867961 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id B05A114DE for ; Mon, 25 Mar 2019 06:21:25 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 95905291F5 for ; Mon, 25 Mar 2019 06:21:25 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 89C152920C; Mon, 25 Mar 2019 06:21:25 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=2.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FROM,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED autolearn=unavailable version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 25522291F5 for ; Mon, 25 Mar 2019 06:21:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:To :From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=Zpk+4Vg/dwPoUuwMiso63fJa/PLCzzNqS9pLR54BpzQ=; b=fUm8QUa1k9Szao uf6PCiqZNtFFHZmIhCiIHAXpg8nRWPtDXUX/jVRZrha6m/gyk+87UyCNSrRk3kUBdQvvmsp4UaJGU qfy9xttUwcAfccyEe6vQvBtWqTKQhuSW8f3MJseJcf86hHUx83oUG5/Y1gtEFg778YfLb8EBlhCll Kr8aC7rs/ylo5CrHCC8LSdt+bfcgU20TzuAm/iM9J8CXt+yQVQ5HQWctu/s3RcMhf00p/Nw3uHOTX JoU6zjTiZpJicvMpNwZ0ew9LVK0oRI+xZVkWCWnIwNY/gld69YEsDBYCVN+4zF6MS0TbJI8cue/Xx qLn3XCccZbAFZ0XTpfaA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1h8Iyy-0005Ap-9K; Mon, 25 Mar 2019 06:21:16 +0000 Received: from mail-pg1-x543.google.com ([2607:f8b0:4864:20::543]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1h8Iys-0005AP-He for linux-arm-kernel@lists.infradead.org; Mon, 25 Mar 2019 06:21:14 +0000 Received: by mail-pg1-x543.google.com with SMTP id l11so5732124pgq.10 for ; Sun, 24 Mar 2019 23:21:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=VZA1AZswyx/+wZFoZFplEQGVijJC6Vlo9vlJ16dUfdw=; b=DmvlKSmUTcMrBrvSpkNYWKnL4gBGpDWKwwOnj4bASFnlNgyTEoUQO/fst7FrcmPocB bV/+oufq7crPAjkZ8F+s/cWgBH2K6R/SLil/0ENIblyNLbfAEDEEGVY3AuZBfUZIf6fx qwfOBDzFiZDKtn89fWoPzRDkZNbCIB002RZf1A/UBOz244+PHZqoaTjBAu8VYAZeGzmN eqHRJzbTsSPR0+kjExrv9mW6sc+pAHNKnygWhyJ7SWtzDMHOWUKfybZtx+A1dAXBXDh7 5LLp/VPHf+7CPJPfKTgf/mkYx+0z9TOhwSZz9YFMBR+PvDtRJNNTSMGlfsdz9dHeZQEo c9nA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=VZA1AZswyx/+wZFoZFplEQGVijJC6Vlo9vlJ16dUfdw=; b=oyqo31/ogZIS5qNLFZDtvhjfsyTBrhzm9Tecb0ClADCAbCwm9lMpFKSBEB233itHsc +3//feOW1J2bisg0uxGLrT1IrKi0j8odANSrqC1UdvM2lqzju2rIDdLU9X2xxTuUKL// lzloNm1IpWmyKoeJb3ZVATUenK+LCRSYlog2wZbMLKOkpPUnoKgC4bq9JCIeqKbLFsnQ yXJ7wA6px64JFqQu+TeFQM5FYmNsLfgK90HUvl/y+VbKMl16wlZc5zYf2o1fiWp9ZE7n MIKcqBZWEiSlZBi5KrxzTw/qcBk2Yl4aHhLeL9XUjGjaBCBtg+W1ZfM66xVxsxGR8Nmw 9XTw== X-Gm-Message-State: APjAAAUTbBFs+jCbKFqiYvlC0vjwDrEx3YZ1+1kw9w1/PT8FNAWSYtK2 Dg1gJFlSMGSvNG6RauXM2y4= X-Google-Smtp-Source: APXvYqwxlqnel+mfaGuoAogvMouTlmbxaIih05IIEsz4W3ijq/UUXCgDDOWTv+rH7BP3KpNaoof19A== X-Received: by 2002:a63:5854:: with SMTP id i20mr12338464pgm.171.1553494869493; Sun, 24 Mar 2019 23:21:09 -0700 (PDT) Received: from localhost.localdomain ([2001:268:c0a5:e068:c70:4af9:86e2:2]) by smtp.gmail.com with ESMTPSA id x13sm16580197pgr.87.2019.03.24.23.21.03 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 24 Mar 2019 23:21:08 -0700 (PDT) From: William Breathitt Gray To: linus.walleij@linaro.org, bgolaszewski@baylibre.com Subject: [PATCH v12 00/11] Introduce the for_each_set_clump8 macro Date: Mon, 25 Mar 2019 15:20:44 +0900 Message-Id: X-Mailer: git-send-email 2.21.0 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190324_232110_636626_895781CF X-CRM114-Status: GOOD ( 13.16 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-arch@vger.kernel.org, preid@electromag.com.au, yamada.masahiro@socionext.com, linux-pm@vger.kernel.org, linux@rasmusvillemoes.dk, linux-kernel@vger.kernel.org, William Breathitt Gray , linux-gpio@vger.kernel.org, geert@linux-m68k.org, akpm@linux-foundation.org, andriy.shevchenko@linux.intel.com, linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP Changes in v12: - Rebase changes (bitmap_set_value8 definition change in wrong commit) While adding GPIO get_multiple/set_multiple callback support for various drivers, I noticed a pattern of looping manifesting that would be useful standardized as a macro. This patchset introduces the for_each_set_clump8 macro and utilizes it in several GPIO drivers. The for_each_set_clump macro8 facilitates a for-loop syntax that iterates over a memory region entire groups of set bits at a time. For example, suppose you would like to iterate over a 32-bit integer 8 bits at a time, skipping over 8-bit groups with no set bit, where XXXXXXXX represents the current 8-bit group: Example: 10111110 00000000 11111111 00110011 First loop: 10111110 00000000 11111111 XXXXXXXX Second loop: 10111110 00000000 XXXXXXXX 00110011 Third loop: XXXXXXXX 00000000 11111111 00110011 Each iteration of the loop returns the next 8-bit group that has at least one set bit. The for_each_set_clump8 macro has four parameters: * start: set to the bit offset of the current clump * clump: set to the current clump value * bits: bitmap to search within * size: bitmap size in number of bits In this version of the patchset, the for_each_set_clump macro has been reimplemented and simplified based on the suggestions provided by Rasmus Villemoes and Andy Shevchenko in the version 4 submission. In particular, the function of the for_each_set_clump macro has been restricted to handle only 8-bit clumps; the drivers that use the for_each_set_clump macro only handle 8-bit ports so a generic for_each_set_clump implementation is not necessary. Thus, a solution for large clumps (i.e. those larger than the width of a bitmap word) can be postponed until a driver appears that actually requires such a generic for_each_set_clump implementation. For what it's worth, a semi-generic for_each_set_clump (i.e. for clumps smaller than the width of a bitmap word) can be implemented by simply replacing the hardcoded '8' and '0xFF' instances with respective variables. I have not yet had a need for such an implementation, and since it falls short of a true generic for_each_set_clump function, I have decided to forgo such an implementation for now. In addition, the bitmap_get_value8 and bitmap_set_value8 functions are introduced to get and set 8-bit values respectively. Their use is based on the behavior suggested in the patchset version 4 review. William Breathitt Gray (11): bitops: Introduce the for_each_set_clump8 macro lib/test_bitmap.c: Add for_each_set_clump8 test cases gpio: 104-dio-48e: Utilize for_each_set_clump8 macro gpio: 104-idi-48: Utilize for_each_set_clump8 macro gpio: gpio-mm: Utilize for_each_set_clump8 macro gpio: ws16c48: Utilize for_each_set_clump8 macro gpio: pci-idio-16: Utilize for_each_set_clump8 macro gpio: pcie-idio-24: Utilize for_each_set_clump8 macro gpio: uniphier: Utilize for_each_set_clump8 macro thermal: intel: intel_soc_dts_iosf: Utilize for_each_set_clump8 macro gpio: 74x164: Utilize the for_each_set_clump8 macro drivers/gpio/gpio-104-dio-48e.c | 73 ++++---------- drivers/gpio/gpio-104-idi-48.c | 37 ++----- drivers/gpio/gpio-74x164.c | 20 ++-- drivers/gpio/gpio-gpio-mm.c | 73 ++++---------- drivers/gpio/gpio-pci-idio-16.c | 75 ++++++-------- drivers/gpio/gpio-pcie-idio-24.c | 111 ++++++++------------- drivers/gpio/gpio-uniphier.c | 16 ++- drivers/gpio/gpio-ws16c48.c | 72 ++++--------- drivers/thermal/intel/intel_soc_dts_iosf.c | 29 +++--- drivers/thermal/intel/intel_soc_dts_iosf.h | 2 - include/asm-generic/bitops/find.h | 14 +++ include/linux/bitops.h | 5 + lib/find_bit.c | 81 +++++++++++++++ lib/test_bitmap.c | 65 ++++++++++++ 14 files changed, 340 insertions(+), 333 deletions(-)