From patchwork Mon Aug 26 13:44:27 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Leonard Crestez X-Patchwork-Id: 11114657 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 13D6E14F7 for ; Mon, 26 Aug 2019 13:46:19 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E5020217F5 for ; Mon, 26 Aug 2019 13:46:18 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="gkT5xxg8" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E5020217F5 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=nxp.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To: References:List-Owner; bh=5gAsQ8wL/c/m84AAt6rDJT/JBCHNCEBYxPTLg6iv/6g=; b=gkT 5xxg8UFMZJatQwDxkG2ZrqccZxmfq10biyuKXtrN7mh86RZ3M/VSVd55NwhNKGI3DJbt/wMyTistA NOSNEBSSmClJSwaS7eMb0B308DIofNtuNKMZ2rW3JhFtEFMZ2sdWNtqgu2qIMfcYO8VHUrKnXsPNt K0uLvVxOgWfS7KWtoqN5kq/dIUwXwx4Q/NwbVW+WiPKBgfiIkKhPGqhDo3J1JszgVKJnqLdXXjFi3 Qa+b3NGj8x7HQTj64Kqk7HsZ2gWV31FniJ7wB7XkxOwkFv6om04r1t05mtlTZ3cgDO0xl1arJukLL h/ThUI6CqbDAnWYN4+eDDBH7RydcL2g==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1i2FK6-0000wn-AU; Mon, 26 Aug 2019 13:46:18 +0000 Received: from inva021.nxp.com ([92.121.34.21]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1i2FIX-0007Tr-SP for linux-arm-kernel@lists.infradead.org; Mon, 26 Aug 2019 13:44:44 +0000 Received: from inva021.nxp.com (localhost [127.0.0.1]) by inva021.eu-rdc02.nxp.com (Postfix) with ESMTP id 8F0DE200201; Mon, 26 Aug 2019 15:44:36 +0200 (CEST) Received: from inva024.eu-rdc02.nxp.com (inva024.eu-rdc02.nxp.com [134.27.226.22]) by inva021.eu-rdc02.nxp.com (Postfix) with ESMTP id 8042620000C; Mon, 26 Aug 2019 15:44:36 +0200 (CEST) Received: from fsr-ub1864-112.ea.freescale.net (fsr-ub1864-112.ea.freescale.net [10.171.82.98]) by inva024.eu-rdc02.nxp.com (Postfix) with ESMTP id E98A220605; Mon, 26 Aug 2019 15:44:35 +0200 (CEST) From: Leonard Crestez To: Chanwoo Choi , MyungJoo Ham Subject: [PATCH v4 0/6] PM / devfreq: Add dev_pm_qos support Date: Mon, 26 Aug 2019 16:44:27 +0300 Message-Id: X-Mailer: git-send-email 2.17.1 X-Virus-Scanned: ClamAV using ClamSMTP X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190826_064442_051023_CDAD658C X-CRM114-Status: UNSURE ( 7.44 ) X-CRM114-Notice: Please train this message. X-Spam-Score: -2.3 (--) X-Spam-Report: SpamAssassin version 3.4.2 on bombadil.infradead.org summary: Content analysis details: (-2.3 points) pts rule name description ---- ---------------------- -------------------------------------------------- -2.3 RCVD_IN_DNSWL_MED RBL: Sender listed at https://www.dnswl.org/, medium trust [92.121.34.21 listed in list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: =?utf-8?b?QXJ0dXIgxZp3aWdvxYQ=?= , Abel Vesa , Saravana Kannan , linux-pm@vger.kernel.org, Viresh Kumar , Krzysztof Kozlowski , Kyungmin Park , Alexandre Bailon , Georgi Djakov , linux-arm-kernel@lists.infradead.org, Jacky Bai MIME-Version: 1.0 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org Add dev_pm_qos notifies to devfreq core in order to support frequency limits via the dev_pm_qos_add_request. Unlike the rest of devfreq the dev_pm_qos frequency is measured in Khz, this is consistent with current dev_pm_qos usage for cpufreq and allows frequencies above 2Ghz (pm_qos expresses limits as s32). Like with cpufreq the handling of min_freq/max_freq is moved to the dev_pm_qos mechanism. Patches 1/2 are technically bugfixes; as far as I can tell the paths that "goto err_devfreq" in devfreq_add_device never worked correctly. Constraints from userspace are no longer clamped on store, instead all values are allowed and we only check against OPPs in a new devfreq_get_freq_range function. This is consistent with the design of dev_pm_qos design. Changes since v3: * Cleanup locking and error-handling in devfreq_add_device * Register notifiers after device registration but before governor start * Keep the initialization of min_req/max_req ahead of device_register because it's used for sysfs handling * Use HZ_PER_KHZ instead of 1000 * Add kernel-doc comments * Move OPP notifier to core Link to v3: https://patchwork.kernel.org/cover/11104061/ Changes since v2: * Handle sysfs via dev_pm_qos (in separate patch) * Add locking to {min,max}_freq_show * Fix checkpatch issues (long lines etc) Link to v2: https://patchwork.kernel.org/patch/11084279/ Changes since v1: * Add doxygen comments for min_nb/max_nb * Remove notifiers on error/cleanup paths. Keep gotos simple by relying on dev_pm_qos_remove_notifier ignoring notifiers which were not added. Link to v1: https://patchwork.kernel.org/patch/11078475/ Leonard Crestez (6): PM / devfreq: Don't take lock in devfreq_add_device PM / devfreq: Add to devfreq_list immediately after registration PM / devfreq: Introduce devfreq_get_freq_range PM / devfreq: Add dev_pm_qos support PM / devfreq: Use dev_pm_qos for sysfs min/max_freq PM / devfreq: Move opp notifier registration to core drivers/devfreq/devfreq.c | 313 +++++++++++++++++++---------------- drivers/devfreq/exynos-bus.c | 7 - drivers/devfreq/rk3399_dmc.c | 6 - include/linux/devfreq.h | 22 ++- 4 files changed, 177 insertions(+), 171 deletions(-)