From patchwork Mon Sep 23 15:51:03 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Leonard Crestez X-Patchwork-Id: 11157201 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 6DC441668 for ; Mon, 23 Sep 2019 15:52:37 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4B7B2205F4 for ; Mon, 23 Sep 2019 15:52:37 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="q4Hwlmj4" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4B7B2205F4 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=nxp.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To: References:List-Owner; bh=8sgk6qf4WHL4T8CyGWNQ7lM/o8++vBKaUzf24r4fZGM=; b=q4H wlmj4KwmXyRewm07LLcQK2ZPJgBAv6qLxl55gyWE34UFIvtWbogj1krlll3PvRS3eEIWsLWIbmusr wSYq9vMkExEi0Jjt71Btv6sR8icu0G3ss6mBFpArHjHB4TNAmCpdCaPjxej7SgpMGi6hv1KWS6X/0 ibq0dgV+OV0C4qk3unu3RjpazhkPcGGMggnCBeinnJDto4hC/Jg68lwdkazeyXaYwy9X0Kr0roys3 myYQQ7oKBul7aGFNDLjHoxPK7SjcIKs8M967a95EwzRHbH31N/J0ZbXHRl28JIoHM4EidyfLxk1yD 3VRovaBmAH3rzVRAe/rN/krZ1aNn7Og==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.2 #3 (Red Hat Linux)) id 1iCQdg-0000TO-T7; Mon, 23 Sep 2019 15:52:36 +0000 Received: from inva020.nxp.com ([92.121.34.13]) by bombadil.infradead.org with esmtps (Exim 4.92.2 #3 (Red Hat Linux)) id 1iCQcO-0007vW-2r for linux-arm-kernel@lists.infradead.org; Mon, 23 Sep 2019 15:51:19 +0000 Received: from inva020.nxp.com (localhost [127.0.0.1]) by inva020.eu-rdc02.nxp.com (Postfix) with ESMTP id 68B071A0BB1; Mon, 23 Sep 2019 17:51:12 +0200 (CEST) Received: from inva024.eu-rdc02.nxp.com (inva024.eu-rdc02.nxp.com [134.27.226.22]) by inva020.eu-rdc02.nxp.com (Postfix) with ESMTP id 62BA91A09C6; Mon, 23 Sep 2019 17:51:12 +0200 (CEST) Received: from fsr-ub1864-112.ea.freescale.net (fsr-ub1864-112.ea.freescale.net [10.171.82.98]) by inva024.eu-rdc02.nxp.com (Postfix) with ESMTP id B185420613; Mon, 23 Sep 2019 17:51:11 +0200 (CEST) From: Leonard Crestez To: Matthias Kaehlcke , MyungJoo Ham , Kyungmin Park Subject: [PATCH v6 0/6] PM / devfreq: Add dev_pm_qos support Date: Mon, 23 Sep 2019 18:51:03 +0300 Message-Id: X-Mailer: git-send-email 2.17.1 X-Virus-Scanned: ClamAV using ClamSMTP X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190923_085116_563809_3663D40A X-CRM114-Status: UNSURE ( 8.90 ) X-CRM114-Notice: Please train this message. X-Spam-Score: -2.3 (--) X-Spam-Report: SpamAssassin version 3.4.2 on bombadil.infradead.org summary: Content analysis details: (-2.3 points) pts rule name description ---- ---------------------- -------------------------------------------------- -2.3 RCVD_IN_DNSWL_MED RBL: Sender listed at https://www.dnswl.org/, medium trust [92.121.34.13 listed in list.dnswl.org] 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 SPF_PASS SPF: sender matches SPF record X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: =?utf-8?b?QXJ0dXIgxZp3aWdvxYQ=?= , Abel Vesa , Saravana Kannan , linux-pm@vger.kernel.org, Viresh Kumar , NXP Linux Team , Krzysztof Kozlowski , Lukasz Luba , Chanwoo Choi , Alexandre Bailon , Georgi Djakov , linux-arm-kernel@lists.infradead.org, Jacky Bai MIME-Version: 1.0 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org Add dev_pm_qos notifiers to devfreq core in order to support frequency limits via dev_pm_qos_add_request. Unlike the rest of devfreq the dev_pm_qos frequency is measured in Khz, this is consistent with current dev_pm_qos usage for cpufreq and allows frequencies above 2Ghz (pm_qos expresses limits as s32). Like with cpufreq the handling of min_freq/max_freq is moved to the dev_pm_qos mechanism. Constraints from userspace are no longer clamped on store, instead all values can be written and we only check against OPPs in a new devfreq_get_freq_range function. This is consistent with the design of dev_pm_qos. Notifiers from pm_qos are executed under a single global dev_pm_qos_mtx and need to take devfreq->lock. Notifier registration takes the same dev_pm_qos_mtx so in order to prevent lockdep warnings it must be done outside devfreq->lock. Current devfreq_add_device does all initialization under devfreq->lock and that needs to be relaxed. --- Changes since v5 are mostly cosmetic: * Drop patches which are not strictly related to PM QoS. * Add a comment explaining why devfreq_add_device needs two cleanup paths. * Remove {} for single line. * Rename {min,max}_freq_req to user_{min,max}_freq_freq * Collect reviews Link to v5: https://patchwork.kernel.org/cover/11149497/ Sorry for forgetting to properly label v5. I know this is inside the merge window but review would still be appreciated. Changes since v4: * Move more devfreq_add_device init ahead of device_register. * Make devfreq_dev_release cleanup devices not yet in devfreq_list. This is simpler than previous attempt to add to devfreq_list sonner. * Take devfreq->lock in trans_stat_show * Register dev_pm_opp notifier on devfreq parent dev (which has OPPs) Link to v4: https://patchwork.kernel.org/cover/11114657/ Changes since v3: * Cleanup locking and error-handling in devfreq_add_device * Register notifiers after device registration but before governor start * Keep the initialization of min_req/max_req ahead of device_register because it's used for sysfs handling * Use HZ_PER_KHZ instead of 1000 * Add kernel-doc comments * Move OPP notifier to core Link to v3: https://patchwork.kernel.org/cover/11104061/ Changes since v2: * Handle sysfs via dev_pm_qos (in separate patch) * Add locking to {min,max}_freq_show * Fix checkpatch issues (long lines etc) Link to v2: https://patchwork.kernel.org/patch/11084279/ Changes since v1: * Add doxygen comments for min_nb/max_nb * Remove notifiers on error/cleanup paths. Keep gotos simple by relying on dev_pm_qos_remove_notifier ignoring notifiers which were not added. Link to v1: https://patchwork.kernel.org/patch/11078475/ Leonard Crestez (6): PM / devfreq: Don't fail devfreq_dev_release if not in list PM / devfreq: Move more initialization before registration PM / devfreq: Don't take lock in devfreq_add_device PM / devfreq: Introduce devfreq_get_freq_range PM / devfreq: Add PM QoS support PM / devfreq: Use PM QoS for sysfs min/max_freq drivers/devfreq/devfreq.c | 264 +++++++++++++++++++++++++------------- include/linux/devfreq.h | 14 +- 2 files changed, 188 insertions(+), 90 deletions(-)