mbox series

[v2,0/2] irqchip: xilinx: Switch to generic domain handler

Message ID cover.1582545908.git.michal.simek@xilinx.com (mailing list archive)
Headers show
Series irqchip: xilinx: Switch to generic domain handler | expand

Message

Michal Simek Feb. 24, 2020, 12:05 p.m. UTC 
Hi,

this series is based on cascade mode patch sent by Mubin
(https://lkml.org/lkml/2020/2/11/888 - v3 series).

The first patch is just fixing error patch. The second is converting microblaze
do_IRQ() to generic IRQ handler with appropriate changes in xilinx intc driver.

Also removes concurrent_irq global variable which wasn't wired
anywhere but it stores number of concurrent IRQs handled by one call. There
is option to get it back if needed but I haven't seen it in other archs
that's why I have removed it too.

Thanks,
Michal

Changes in v2:
- Merge generic irq multi handler(v1 2/3) and domain irq patch (v1 3/3) from together
- Add likely() suggested by Marc

Michal Simek (2):
  irqchip: xilinx: Fill error code when irq domain registration fails
  irqchip: xilinx: Enable generic irq multi handler

 arch/microblaze/Kconfig           |  2 ++
 arch/microblaze/include/asm/irq.h |  3 ---
 arch/microblaze/kernel/irq.c      | 21 +------------------
 drivers/irqchip/irq-xilinx-intc.c | 35 ++++++++++++++++++-------------
 4 files changed, 24 insertions(+), 37 deletions(-)

Comments

Marc Zyngier March 8, 2020, 2:01 p.m. UTC | #1 
On Mon, 24 Feb 2020 13:05:12 +0100
Michal Simek <michal.simek@xilinx.com> wrote:

> Hi,
> 
> this series is based on cascade mode patch sent by Mubin
> (https://lkml.org/lkml/2020/2/11/888 - v3 series).
> 
> The first patch is just fixing error patch. The second is converting microblaze
> do_IRQ() to generic IRQ handler with appropriate changes in xilinx intc driver.
> 
> Also removes concurrent_irq global variable which wasn't wired
> anywhere but it stores number of concurrent IRQs handled by one call. There
> is option to get it back if needed but I haven't seen it in other archs
> that's why I have removed it too.

Queued for 5.7.

Thanks,

	M.
Marc Zyngier March 8, 2020, 2:32 p.m. UTC | #2 
On Sun, 8 Mar 2020 14:01:26 +0000
Marc Zyngier <maz@kernel.org> wrote:

> On Mon, 24 Feb 2020 13:05:12 +0100
> Michal Simek <michal.simek@xilinx.com> wrote:
> 
> > Hi,
> > 
> > this series is based on cascade mode patch sent by Mubin
> > (https://lkml.org/lkml/2020/2/11/888 - v3 series).
> > 
> > The first patch is just fixing error patch. The second is converting microblaze
> > do_IRQ() to generic IRQ handler with appropriate changes in xilinx intc driver.
> > 
> > Also removes concurrent_irq global variable which wasn't wired
> > anywhere but it stores number of concurrent IRQs handled by one call. There
> > is option to get it back if needed but I haven't seen it in other archs
> > that's why I have removed it too.  
> 
> Queued for 5.7.

Scratch that, this doesn't apply to mainline because of the above
dependency (and said dependency hasn't been reposted after Thomas'
review). I've now dropped it. Please resubmit a full series that
contains all the pre-requisite to be applied on mainline.

	M.
Michal Simek March 9, 2020, 8:20 a.m. UTC | #3 
On 08. 03. 20 15:32, Marc Zyngier wrote:
> On Sun, 8 Mar 2020 14:01:26 +0000
> Marc Zyngier <maz@kernel.org> wrote:
> 
>> On Mon, 24 Feb 2020 13:05:12 +0100
>> Michal Simek <michal.simek@xilinx.com> wrote:
>>
>>> Hi,
>>>
>>> this series is based on cascade mode patch sent by Mubin
>>> (https://lkml.org/lkml/2020/2/11/888 - v3 series).
>>>
>>> The first patch is just fixing error patch. The second is converting microblaze
>>> do_IRQ() to generic IRQ handler with appropriate changes in xilinx intc driver.
>>>
>>> Also removes concurrent_irq global variable which wasn't wired
>>> anywhere but it stores number of concurrent IRQs handled by one call. There
>>> is option to get it back if needed but I haven't seen it in other archs
>>> that's why I have removed it too.  
>>
>> Queued for 5.7.
> 
> Scratch that, this doesn't apply to mainline because of the above
> dependency (and said dependency hasn't been reposted after Thomas'
> review). I've now dropped it. Please resubmit a full series that
> contains all the pre-requisite to be applied on mainline.

I have asked Mubin to send these two patches as series with cascade mode
support.

Thanks,
Michal