From patchwork Mon Jun 15 12:50:05 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Syed Nayyar Waris X-Patchwork-Id: 11604813 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id A8A3E912 for ; Mon, 15 Jun 2020 12:50:35 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 85F99206B7 for ; Mon, 15 Jun 2020 12:50:35 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="H6ZCS9r6"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="LVl5ljYL" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 85F99206B7 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Subject:To:From :Date:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=bqQ9q14djXjF6JeO35bXclzjBQXVjQqpI4+aIrvtIl8=; b=H6ZCS9r6rFeleb WxYxteNL8idR1yodab1jgZYGB2LrIS7uqZX3dCHp3cMlgfic1VazGHAGJX+nwjEpJjAHYRqUU+pm0 oHjIK6DYbmqyIzKoSXFJp7oAzjd7ryVdTx6rlxoI/MU/1mYEqwElrHL0WjHkYF/SdLeVhajocnOBT U9XeZPTQ8q9ZqqyK8U9oMXOGVZoO9FWTrmsU1zlnT74SlhBSM4fwKLogKtn9bRFC8gL7duXJzu+u6 taxL/04+GjOgEEnpuFyIwA2tcv4QwZ3JgosOW+lUnqoQQvtK/qTtnZw6umEhvtXy10mDCqImoxT8g mPtZ9dnqBdPoG6fI3Yzg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jkoZL-0008Lq-LU; Mon, 15 Jun 2020 12:50:31 +0000 Received: from mail-pj1-x1043.google.com ([2607:f8b0:4864:20::1043]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jkoZJ-0008LR-2q for linux-arm-kernel@lists.infradead.org; Mon, 15 Jun 2020 12:50:30 +0000 Received: by mail-pj1-x1043.google.com with SMTP id k2so6790385pjs.2 for ; Mon, 15 Jun 2020 05:50:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:mime-version:content-disposition :user-agent; bh=CW8sVg3Ki8BPXWoXTIsvDk7MK1hG8/08VLgL06LyYi4=; b=LVl5ljYLSgTAVwIntKBSWNOIq+59AJGhYsMRCv7FgizVBCV9zxPwAYBxWxQZ6xADRy d9ARo/Ao8Gq4lHGuhuUQO634dCgBnH7O+BDc22OpAW3UiD+TtPiC6zskCXfep1rrEYFT waJkS+LySZyNniytxVp83g7ILVl6wK8EoOEcSOxJ+VC7TDDNAAF71YT1XzolXC2RFUVu LZQYzfPELSxdi3bYcBbnOTRwwBahB87UlvBevC6JI3MSIGOIXrzIrjIel1BAB4uE4fKg e+U8RC8uU+ZDLPLRB4jmqk78v6AlRiDMRT48brZ8tM+aC9R3L+1pd4FpP8xtXJBESok/ OsMQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:mime-version :content-disposition:user-agent; bh=CW8sVg3Ki8BPXWoXTIsvDk7MK1hG8/08VLgL06LyYi4=; b=HtX2k7zoNU+M4Ietl3TekYkXCzqiMQOzHELIh2HY/GgmnIfbuB6aA4XUxewcAocpF2 4UOGxRDoWjJnsi97zlq7w7Bv8LqfP0359HrDe4tEQZG4kC4q4u4L3qWyZBrY4UBIW2pg wiftD+bY/fFkI8r2QCvXHnUj9sD22Gjk17U0g07RTgxIXEDsIwrzLpjnnNtcopm46R4C 7ptdzEEULSGOrMZaO3+v5PKVQ6YIvXBOd2+O9qqDQCjEMQr4AYb3FOWKQVHXCy4HCRch C6Y6ar4Cd7iFgyV+Ok4XRkXpUOFPbav+bDpUTTUL6GArURChNbACIJTzuQ+77Oa/mEV3 wPlw== X-Gm-Message-State: AOAM531SHDZeIBNAMyWQ93FDXvG21cyJELOATPOThJxUpc69Ik1KEwHH R0b8APDbAaokmuAYK8v65w8= X-Google-Smtp-Source: ABdhPJwc22e39iJAlXB5y6rgPIfIw/oKijE5P33N2iVQp4Hj73fH1PvftHb5a+uVHJ1TwJ241w7Udw== X-Received: by 2002:a17:902:8e82:: with SMTP id bg2mr22711436plb.198.1592225428192; Mon, 15 Jun 2020 05:50:28 -0700 (PDT) Received: from syed ([106.198.128.180]) by smtp.gmail.com with ESMTPSA id a10sm12010155pgv.72.2020.06.15.05.50.18 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 15 Jun 2020 05:50:27 -0700 (PDT) Date: Mon, 15 Jun 2020 18:20:05 +0530 From: Syed Nayyar Waris To: linus.walleij@linaro.org, akpm@linux-foundation.org Subject: [PATCH v8 0/4] Introduce the for_each_set_clump macro Message-ID: MIME-Version: 1.0 Content-Disposition: inline User-Agent: Mutt/1.5.24 (2015-08-30) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200615_055029_127120_4265AD6C X-CRM114-Status: GOOD ( 14.39 ) X-Spam-Score: -0.2 (/) X-Spam-Report: SpamAssassin version 3.4.4 on bombadil.infradead.org summary: Content analysis details: (-0.2 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2607:f8b0:4864:20:0:0:0:1043 listed in] [list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider [syednwaris[at]gmail.com] -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-arch@vger.kernel.org, amit.kucheria@verdurent.com, arnd@arndb.de, yamada.masahiro@socionext.com, linux-kernel@vger.kernel.org, linus.walleij@linaro.org, daniel.lezcano@linaro.org, vilhelm.gray@gmail.com, michal.simek@xilinx.com, bgolaszewski@baylibre.com, rrichter@marvell.com, linux-gpio@vger.kernel.org, linux-pm@vger.kernel.org, rui.zhang@intel.com, andriy.shevchenko@linux.intel.com, linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org Hello Linus, Since this patchset primarily affects GPIO drivers, would you like to pick it up through your GPIO tree? This patchset introduces a new generic version of for_each_set_clump. The previous version of for_each_set_clump8 used a fixed size 8-bit clump, but the new generic version can work with clump of any size but less than or equal to BITS_PER_LONG. The patchset utilizes the new macro in several GPIO drivers. The earlier 8-bit for_each_set_clump8 facilitated a for-loop syntax that iterates over a memory region entire groups of set bits at a time. For example, suppose you would like to iterate over a 32-bit integer 8 bits at a time, skipping over 8-bit groups with no set bit, where XXXXXXXX represents the current 8-bit group: Example: 10111110 00000000 11111111 00110011 First loop: 10111110 00000000 11111111 XXXXXXXX Second loop: 10111110 00000000 XXXXXXXX 00110011 Third loop: XXXXXXXX 00000000 11111111 00110011 Each iteration of the loop returns the next 8-bit group that has at least one set bit. But with the new for_each_set_clump the clump size can be different from 8 bits. Moreover, the clump can be split at word boundary in situations where word size is not multiple of clump size. Following are examples showing the working of new macro for clump sizes of 24 bits and 6 bits. Example 1: clump size: 24 bits, Number of clumps (or ports): 10 bitmap stores the bit information from where successive clumps are retrieved. /* bitmap memory region */ 0x00aa0000ff000000; /* Most significant bits */ 0xaaaaaa0000ff0000; 0x000000aa000000aa; 0xbbbbabcdeffedcba; /* Least significant bits */ Different iterations of for_each_set_clump:- 'offset' is the bit position and 'clump' is the 24 bit clump from the above bitmap. Iteration first: offset: 0 clump: 0xfedcba Iteration second: offset: 24 clump: 0xabcdef Iteration third: offset: 48 clump: 0xaabbbb Iteration fourth: offset: 96 clump: 0xaa Iteration fifth: offset: 144 clump: 0xff Iteration sixth: offset: 168 clump: 0xaaaaaa Iteration seventh: offset: 216 clump: 0xff Loop breaks because in the end the remaining bits (0x00aa) size was less than clump size of 24 bits. In above example it can be seen that in iteration third, the 24 bit clump that was retrieved was split between bitmap[0] and bitmap[1]. This example also shows that 24 bit zeroes if present in between, were skipped (preserving the previous for_each_set_macro8 behaviour). Example 2: clump size = 6 bits, Number of clumps (or ports) = 3. /* bitmap memory region */ 0x00aa0000ff000000; /* Most significant bits */ 0xaaaaaa0000ff0000; 0x0f00000000000000; 0x0000000000000ac0; /* Least significant bits */ Different iterations of for_each_set_clump: 'offset' is the bit position and 'clump' is the 6 bit clump from the above bitmap. Iteration first: offset: 6 clump: 0x2b Loop breaks because 6 * 3 = 18 bits traversed in bitmap. Here 6 * 3 is clump size * no. of clumps. Changes in v8: - [Patch 2/4]: Minor change: Use '__initdata' for correct section mismatch in 'clump_test_data' array. Changes in v7: - [Patch 2/4]: Minor changes: Use macro 'DECLARE_BITMAP()' and split 'struct' definition and test data. Changes in v6: - [Patch 2/4]: Make 'for loop' inside test_for_each_set_clump more succinct. Changes in v5: - [Patch 4/4]: Minor change: Hardcode value for better code readability. Changes in v4: - [Patch 2/4]: Use 'for' loop in test function of for_each_set_clump. - [Patch 3/4]: Minor change: Inline value for better code readability. - [Patch 4/4]: Minor change: Inline value for better code readability. Changes in v3: - [Patch 3/4]: Change datatype of some variables from u64 to unsigned long in function thunderx_gpio_set_multiple. CHanges in v2: - [Patch 2/4]: Unify different tests for 'for_each_set_clump'. Pass test data as function parameters. - [Patch 2/4]: Remove unnecessary bitmap_zero calls. Syed Nayyar Waris (4): bitops: Introduce the for_each_set_clump macro lib/test_bitmap.c: Add for_each_set_clump test cases gpio: thunderx: Utilize for_each_set_clump macro gpio: xilinx: Utilize for_each_set_clump macro drivers/gpio/gpio-thunderx.c | 11 ++- drivers/gpio/gpio-xilinx.c | 62 ++++++------- include/asm-generic/bitops/find.h | 19 ++++ include/linux/bitmap.h | 61 +++++++++++++ include/linux/bitops.h | 13 +++ lib/find_bit.c | 14 +++ lib/test_bitmap.c | 145 ++++++++++++++++++++++++++++++ 7 files changed, 291 insertions(+), 34 deletions(-) base-commit: 444fc5cde64330661bf59944c43844e7d4c2ccd8