From patchwork Sat Jun 27 08:09:42 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Syed Nayyar Waris X-Patchwork-Id: 11629385 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id D3F84912 for ; Sat, 27 Jun 2020 08:12:31 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A76732074F for ; Sat, 27 Jun 2020 08:12:31 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="ONVHt3i9"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="EgYf/6s7" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A76732074F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:Message-ID:Subject:To:From:Date: Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender :Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Owner; bh=HEhEX3uQ1mn00FPqRLHBXP0RDaI5IdwhYfOL0RipGGM=; b=ONVHt3i95QOq0sxjce2ezaxWNn 7NpCn/OHy98w8SorNUTR9Ukke4Bl2JryjW146PcBFC9ePVodz5SHcM727vj/Gaaqaeiv4sK+Io4uL envqUHDkgOI7l+iGf/CA9Fhyph0qrExDGVcbmNQvAGqeYTLQ5KLYia2ln0vCgHY+AQIVWAbZKTJFi Ict9/sjMZZJFfSa9XKp+7/NVYwSU1mWc4aLmTOxaf8wKtGS8rAW6T9qqKCRxyHslUFKcH329sfR6t hBXQEC3AohAueohnpnIfdYpmKxEmUllu56DHed61Vonw67pUhFW3NyAmQ9jLi0GCVMp3uLmrqZGiS 7YFwF3Xg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jp5ua-00064N-RW; Sat, 27 Jun 2020 08:10:08 +0000 Received: from mail-pg1-x542.google.com ([2607:f8b0:4864:20::542]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jp5uX-00063q-7x for linux-arm-kernel@lists.infradead.org; Sat, 27 Jun 2020 08:10:06 +0000 Received: by mail-pg1-x542.google.com with SMTP id o13so3068342pgf.0 for ; Sat, 27 Jun 2020 01:10:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:mime-version:content-disposition :user-agent; bh=mMs3gYZpHPvw7n5oRkve+y/cWnhNNHLz+TPT8hcajaU=; b=EgYf/6s7SYl2cpDHK5aBJ9oObbELwUgjBNjVufgUHhT65ouUSRazVsC7Ji7kkYR6R+ kdU8pxS+rKvod5npBCNK+RD5y8zeHYKVRKkTg22Gud7QNs+EoZdqdtWDj1iIdyGADSFB Q5RNc8hNS8SOf0FrSWQ2XZtggTdWicPWfyBdlkz7TQXKUJUqQGZYW1R//2RIhF22Hape ey1M+A120DoApdjrZ/33qTHZ56theKKsJEj305KMTxqXNB+iSxFF4f40W8ymlQwqCo29 REoUc9s3Utxhf3RLlgO1Fk4WeK6w0SprU6m8O2hfQ5WdA6aITTYqJE8OsIkYvL/Cn9Jh APnQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:mime-version :content-disposition:user-agent; bh=mMs3gYZpHPvw7n5oRkve+y/cWnhNNHLz+TPT8hcajaU=; b=BazZ74dojuzcjvHTuqrSChmG1vkyxoPCQfsx+vi+BvrICuOKsj3rv822e34wzDibPm 4s/9DZai7JjHhOBCM8lEi0gE9r9NhzO8nh/UioTtiHMqrgmY9fJeDnuR3eLXH6InTWld nrPGMagFqHtxOZK31ywmHZy//BH0T9aPHZNyFwpMVu5ne+aFV5ihFiYCmBvtYMSW/NQu tCBsgURjg4WEH6inPcZNTaF56v8wBvNxMu59J1orzBw2bLu4N3iZaztnnmk9F2onfv25 6SZRinaWwmuwiOdAhbnDwyOjFGONcfkqNRj6ld4rhLVSJ/Zcs57MDwDT+/l3Q5A4139k OKZg== X-Gm-Message-State: AOAM533K027yRafYcyPmZa2hGL8P+/zM7Zdo6hWtnS5pa3z9TeKl252s p/zhCGrFDfyPAuGRkACSbAA= X-Google-Smtp-Source: ABdhPJyXvNyg7BqiH3Ur+MpSwG2S7VDm27kt7QyIFWKarumFxhDABWmKxLr0amttw9l6DI/CPsFmSg== X-Received: by 2002:a63:380d:: with SMTP id f13mr2314214pga.16.1593245402252; Sat, 27 Jun 2020 01:10:02 -0700 (PDT) Received: from syed ([106.198.224.34]) by smtp.gmail.com with ESMTPSA id h6sm4195780pfg.25.2020.06.27.01.09.55 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 27 Jun 2020 01:10:01 -0700 (PDT) Date: Sat, 27 Jun 2020 13:39:42 +0530 From: Syed Nayyar Waris To: linus.walleij@linaro.org Subject: [PATCH v9 0/4] Introduce the for_each_set_clump macro Message-ID: MIME-Version: 1.0 Content-Disposition: inline User-Agent: Mutt/1.5.24 (2015-08-30) X-Spam-Note: CRM114 invocation failed X-Spam-Score: -0.2 (/) X-Spam-Report: SpamAssassin version 3.4.4 on merlin.infradead.org summary: Content analysis details: (-0.2 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2607:f8b0:4864:20:0:0:0:542 listed in] [list.dnswl.org] 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider [syednwaris[at]gmail.com] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-arch@vger.kernel.org, amit.kucheria@verdurent.com, arnd@arndb.de, yamada.masahiro@socionext.com, linux-kernel@vger.kernel.org, linus.walleij@linaro.org, daniel.lezcano@linaro.org, vilhelm.gray@gmail.com, michal.simek@xilinx.com, bgolaszewski@baylibre.com, rrichter@marvell.com, linux-gpio@vger.kernel.org, linux-pm@vger.kernel.org, rui.zhang@intel.com, andriy.shevchenko@linux.intel.com, linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org Hello Linus, Since this patchset primarily affects GPIO drivers, would you like to pick it up through your GPIO tree? This patchset introduces a new generic version of for_each_set_clump. The previous version of for_each_set_clump8 used a fixed size 8-bit clump, but the new generic version can work with clump of any size but less than or equal to BITS_PER_LONG. The patchset utilizes the new macro in several GPIO drivers. The earlier 8-bit for_each_set_clump8 facilitated a for-loop syntax that iterates over a memory region entire groups of set bits at a time. For example, suppose you would like to iterate over a 32-bit integer 8 bits at a time, skipping over 8-bit groups with no set bit, where XXXXXXXX represents the current 8-bit group: Example: 10111110 00000000 11111111 00110011 First loop: 10111110 00000000 11111111 XXXXXXXX Second loop: 10111110 00000000 XXXXXXXX 00110011 Third loop: XXXXXXXX 00000000 11111111 00110011 Each iteration of the loop returns the next 8-bit group that has at least one set bit. But with the new for_each_set_clump the clump size can be different from 8 bits. Moreover, the clump can be split at word boundary in situations where word size is not multiple of clump size. Following are examples showing the working of new macro for clump sizes of 24 bits and 6 bits. Example 1: clump size: 24 bits, Number of clumps (or ports): 10 bitmap stores the bit information from where successive clumps are retrieved. /* bitmap memory region */ 0x00aa0000ff000000; /* Most significant bits */ 0xaaaaaa0000ff0000; 0x000000aa000000aa; 0xbbbbabcdeffedcba; /* Least significant bits */ Different iterations of for_each_set_clump:- 'offset' is the bit position and 'clump' is the 24 bit clump from the above bitmap. Iteration first: offset: 0 clump: 0xfedcba Iteration second: offset: 24 clump: 0xabcdef Iteration third: offset: 48 clump: 0xaabbbb Iteration fourth: offset: 96 clump: 0xaa Iteration fifth: offset: 144 clump: 0xff Iteration sixth: offset: 168 clump: 0xaaaaaa Iteration seventh: offset: 216 clump: 0xff Loop breaks because in the end the remaining bits (0x00aa) size was less than clump size of 24 bits. In above example it can be seen that in iteration third, the 24 bit clump that was retrieved was split between bitmap[0] and bitmap[1]. This example also shows that 24 bit zeroes if present in between, were skipped (preserving the previous for_each_set_macro8 behaviour). Example 2: clump size = 6 bits, Number of clumps (or ports) = 3. /* bitmap memory region */ 0x00aa0000ff000000; /* Most significant bits */ 0xaaaaaa0000ff0000; 0x0f00000000000000; 0x0000000000000ac0; /* Least significant bits */ Different iterations of for_each_set_clump: 'offset' is the bit position and 'clump' is the 6 bit clump from the above bitmap. Iteration first: offset: 6 clump: 0x2b Loop breaks because 6 * 3 = 18 bits traversed in bitmap. Here 6 * 3 is clump size * no. of clumps. Changes in v9: - [Patch 4/4]: Remove looping of 'for_each_set_clump' and instead process two halves of a 64-bit bitmap separately or individually. Use normal spin_lock call for second inner lock. And take the spin_lock_init call outside the 'if' condition in the probe function of driver. Changes in v8: - [Patch 2/4]: Minor change: Use '__initdata' for correct section mismatch in 'clump_test_data' array. Changes in v7: - [Patch 2/4]: Minor changes: Use macro 'DECLARE_BITMAP()' and split 'struct' definition and test data. Changes in v6: - [Patch 2/4]: Make 'for loop' inside test_for_each_set_clump more succinct. Changes in v5: - [Patch 4/4]: Minor change: Hardcode value for better code readability. Changes in v4: - [Patch 2/4]: Use 'for' loop in test function of for_each_set_clump. - [Patch 3/4]: Minor change: Inline value for better code readability. - [Patch 4/4]: Minor change: Inline value for better code readability. Changes in v3: - [Patch 3/4]: Change datatype of some variables from u64 to unsigned long in function thunderx_gpio_set_multiple. CHanges in v2: - [Patch 2/4]: Unify different tests for 'for_each_set_clump'. Pass test data as function parameters. - [Patch 2/4]: Remove unnecessary bitmap_zero calls. Syed Nayyar Waris (4): bitops: Introduce the for_each_set_clump macro lib/test_bitmap.c: Add for_each_set_clump test cases gpio: thunderx: Utilize for_each_set_clump macro gpio: xilinx: Utilize generic bitmap_get_value and _set_value. drivers/gpio/gpio-thunderx.c | 11 ++- drivers/gpio/gpio-xilinx.c | 66 +++++++------- include/asm-generic/bitops/find.h | 19 ++++ include/linux/bitmap.h | 61 +++++++++++++ include/linux/bitops.h | 13 +++ lib/find_bit.c | 14 +++ lib/test_bitmap.c | 145 ++++++++++++++++++++++++++++++ 7 files changed, 292 insertions(+), 37 deletions(-) base-commit: b3a9e3b9622ae10064826dccb4f7a52bd88c7407