From patchwork Wed Aug 12 19:36:54 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jonathan McDowell X-Patchwork-Id: 11711271 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 72A04722 for ; Wed, 12 Aug 2020 19:38:30 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4A29E206DA for ; Wed, 12 Aug 2020 19:38:30 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="SgpQYKHb"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=earth.li header.i=@earth.li header.b="FMeEhwrV" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4A29E206DA Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=earth.li Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe :List-Id:MIME-Version:Message-ID:Subject:To:From:Date:Reply-To:Cc:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Owner; bh=cP3zSeWaf0p1juEQVId4B1tCjqGsQuRxOO5/iXIlq60=; b=SgpQYKHbybBq+YNSveTUMoXMUt cC8PeQ7HN/Ja9ducpbEER0AFTydKuAKOmUCYAeYsgrAgFoAoglslQebrBHkqWE/jTcq21uoeYi/gf +1edxPlQuSplTSLkZopp7d6rUIoSlnFH8EOA/SmuOWk/QpK9xRKKjjX2SgK+nnsDexPjKI6BInXmZ MFlV4x9rHeIJIMzSMnD/CvX5sQM0Q46EPHbY/il5lkqV5AHhRI10gWOURwAyZNPgbVMmvUSmF5ZiU VWOc56MpPVUgQUAMfoPmgyCbVO5poKNJXrL7z5XByovAK6WuWMWW8FQH8iSDsNuaDn/akVsMdS2i8 QtXWMAIA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1k5wYb-0004Et-RD; Wed, 12 Aug 2020 19:37:05 +0000 Received: from the.earth.li ([2a00:1098:86:4d:c0ff:ee:15:900d]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1k5wYZ-0004EK-G2 for linux-arm-kernel@lists.infradead.org; Wed, 12 Aug 2020 19:37:04 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=earth.li; s=the; h=Content-Type:MIME-Version:Message-ID:Subject:To:From:Date:Sender: Reply-To:Cc:Content-Transfer-Encoding:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: In-Reply-To:References:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=XqxBkx0fhTjErNZmjOmJ0k+Zy+sZA4pBOuNGrWDz6iI=; b=FMeEhwrV6De794yhR10herc21E qdQvLTi+Nv2G9VZkkbfSUyNa3hH/0pMw7ZcvxmIanCTJR/cygmyBgGNaGMG7O9ymJm4SBlC9RnefP 8tXAq4QSkoI21sA2RFEMRQsyXdSRnpOUr4akPKkWNfzmCgNLP/zXN7M3DsWyRl6nErD+1O/IVKjap EJAMRIxdFe+I40ckS63WCjDzAwaSBqS7ImhQ4FAsKqK763DYrN1c2ZzKWxcHhKU8lM0a7t4g6gS00 8t+GqPAoXn7pTPSQ7mFFT5QzAnUlBYUVlutQLETWTK4+2m//BBwBi9yQ+16e3ZfOIrRjeLTopfBk9 drVXFmRw==; Received: from noodles by the.earth.li with local (Exim 4.92) (envelope-from ) id 1k5wYQ-0002nP-Bl; Wed, 12 Aug 2020 20:36:54 +0100 Date: Wed, 12 Aug 2020 20:36:54 +0100 From: Jonathan McDowell To: Giuseppe Cavallaro , Alexandre Torgue , Jose Abreu , David Miller , Jakub Kicinski , Maxime Coquelin , netdev@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH net 0/2] net: stmmac: Fix multicast filter on IPQ806x Message-ID: MIME-Version: 1.0 Content-Disposition: inline User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200812_153703_587165_E89A0A8C X-CRM114-Status: GOOD ( 10.41 ) X-Spam-Score: -0.2 (/) X-Spam-Report: SpamAssassin version 3.4.4 on merlin.infradead.org summary: Content analysis details: (-0.2 points) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 SPF_PASS SPF: sender matches SPF record -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org This pair of patches are the result of discovering a failure to correctly receive IPv6 multicast packets on such a device (in particular DHCPv6 requests and RA solicitations). Putting the device into promiscuous mode, or allmulti, both resulted in such packets correctly being received. Examination of the vendor driver (nss-gmac from the qsdk) shows that it does not enable the multicast filter and instead falls back to allmulti. Extend the base dwmac1000 driver to fall back when there's no suitable hardware filter, and update the ipq806x platform to request this. Jonathan McDowell (2): net: stmmac: dwmac1000: provide multicast filter fallback net: ethernet: stmmac: Disable hardware multicast filter drivers/net/ethernet/stmicro/stmmac/dwmac-ipq806x.c | 1 + drivers/net/ethernet/stmicro/stmmac/dwmac1000_core.c | 3 +++ 2 files changed, 4 insertions(+)