From patchwork Wed Aug 19 16:37:55 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Cristian Ciocaltea X-Patchwork-Id: 11724599 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 563FE1392 for ; Wed, 19 Aug 2020 16:38:22 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2DAA3207BB for ; Wed, 19 Aug 2020 16:38:22 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="BpEs4P4c"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="QZPlaQmY" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2DAA3207BB Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:To:From: Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender :Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Owner; bh=tt4nE1nqdckEKPT2g2cPFDvksnY/INJoETnKuvygSM0=; b=BpEs4P4cqBWjvzOtN0pi5+xBCT 9r2qbE111A5YNV8az/M39rSvWtfkAm6Ydg4WMA8X36wGTu1tGPArE7HVCiRJFPRsduDE5VpC0osLx HeYquqMkT9OXVLr4QeYSipEepbSjdJ9h/rLDla+3S6pOMFbQ6FCwZt4mf54zTRdFCOau9oXIVnmt0 cTsk+LGhDXqU45FdIdmy0YyD41s0ndM3NB2ybG/fHYNuAzBy8JGYakdGo1wbKWidedomDcnFPOenU pCug+P699XNQcS/WIqLNqsjUpnKqWsP49E7nfCYim/TVcx2cVoQKVtUi75fLdwYYH0foTdPtgjpyg xFkyeX7A==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1k8R6C-000826-PZ; Wed, 19 Aug 2020 16:38:04 +0000 Received: from mail-ej1-x642.google.com ([2a00:1450:4864:20::642]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1k8R6A-00081P-4F; Wed, 19 Aug 2020 16:38:02 +0000 Received: by mail-ej1-x642.google.com with SMTP id o18so27054668eje.7; Wed, 19 Aug 2020 09:38:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=8aNI7vXPweXU0xeLfQMTOUq4C8U6Hd6f9EUV+FsNfGY=; b=QZPlaQmYiTEEzpLW9J3XqSpHGGdCCg9D+RTfmhlMqd1d3ItkuAoHjyBAW58uBEasHt 6MjLmIVo+bDsM2nmle61oFsL/z/rkN74k8usw+kSQxMQSJJnjPkBbI5Ag4yluIlp2w8B 28q5UoemgDJkHRyEQ5pBnXHH9GAodjXXY2/9cFCSn30/cXZh2bTZGjVXBqagrUPiNZuM kbnuB4L2g1EuSjkEqHkDOmVT61mJQlDKPSSDhPhdMT158zFZk7R9b/Nt6fPPF+Y2WDz5 y8b2BzkhPEJLP5nrYofR/8zE/JdohiBSIgzzYkuBFJkjV8trhd7gS6Oud9b6oxJY0w5b 04iw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=8aNI7vXPweXU0xeLfQMTOUq4C8U6Hd6f9EUV+FsNfGY=; b=JPA/ToaKB0j05TRpbUFXTbPUX3UWe7tSa5O8pVnHoZk4lFNUAuA/rspKYpO7zQWqNu xLiPYe1B17rEHyooMChhy43Qyf/BGiEBYgwpAS0EnjNKi8uN02oVRmmgXAsSd/p6iPV6 HfDHEnM1DZiGrvV0cxrbcaBRmSq+92h0M5whs28IEb0whcFNNS/oLj240XGR56i39H0p dQlOSIB8MQs/yqEEF7nYut2q7bUzEW+qsP+MlKFGX0cJOBD9loHu0/7nsXEsK5v1Kcu1 7hE70alseK+jkAI3ZtKokzrxmgO4XQK4w8DVESJu563/ra1XffLGg42luOd2K30k+Q25 kGeQ== X-Gm-Message-State: AOAM531+Asfka3L3Uc7QI1uJ7kXnQ44ElgOiuAwLoMnD1IWcmhjWqHrH 36/QBMgBOCIQlYj4a/71wBU= X-Google-Smtp-Source: ABdhPJyAR7gVU7w4pXzDT/4F9iydlbvDGAB7vWGxTGgBHRB16SLjUEKppg4RCjmYi1nRsq0dSerjfg== X-Received: by 2002:a17:906:6801:: with SMTP id k1mr26149858ejr.492.1597855080803; Wed, 19 Aug 2020 09:38:00 -0700 (PDT) Received: from localhost.localdomain ([188.24.144.238]) by smtp.gmail.com with ESMTPSA id m13sm18310774edi.89.2020.08.19.09.37.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 19 Aug 2020 09:38:00 -0700 (PDT) From: Cristian Ciocaltea To: Thomas Gleixner , Jason Cooper , Marc Zyngier , Rob Herring , =?utf-8?q?Andreas_F=C3=A4rber?= , Manivannan Sadhasivam Subject: [PATCH v5 0/3] Add Actions Semi Owl family sirq support Date: Wed, 19 Aug 2020 19:37:55 +0300 Message-Id: X-Mailer: git-send-email 2.28.0 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200819_123802_181718_9116951A X-CRM114-Status: GOOD ( 21.05 ) X-Spam-Score: -0.2 (/) X-Spam-Report: SpamAssassin version 3.4.4 on merlin.infradead.org summary: Content analysis details: (-0.2 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2a00:1450:4864:20:0:0:0:642 listed in] [list.dnswl.org] 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider [cristian.ciocaltea[at]gmail.com] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, linux-actions@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org This patch series adds support for the external interrupt controller (SIRQ) found in the Actions Semi Owl family of SoC's (S500, S700 and S900). The controller handles up to 3 external interrupt lines through dedicated SIRQ pins. This is a rework of the patch series submitted some time ago by Parthiban Nallathambi: https://lore.kernel.org/lkml/20181126100356.2840578-1-pn@denx.de/ Please note I have dropped, for the moment, the S700 related patches since I do not own a compatible hardware for testing. I'm using instead an S500 SoC based board for which I have already provided the initial support: https://lore.kernel.org/lkml/cover.1592123160.git.cristian.ciocaltea@gmail.com/ The SIRQ controller support is a prerequisite of the soon to be submitted MFD driver for the Actions Semi ATC260x PMICs. Thanks and regards, Cristi Changes in v5: - Integrated Marc's review (more details in the driver patch changelog) - Rebased patch series on v5.9-rc1 Changes in v4: - Simplified the DTS structure: * dropped 'actions,sirq-shared-reg' node, now the differentiation between SoC variants is handled now via the compatible property * dropped 'actions,sirq-reg-offset', now controller base address in DTS points to SIRQ0 register, so no additional information is required for S500 and S700, while for S900 SoC the offsets of SIRQ1 and SIRQ2 regs are provided by the driver * 'actions,ext-irq-range' was replaced with 'actions,ext-interrupts', an array of the GIC interrupts triggered by the controller - Fixed wrong INTC_EXTCTL_TYPE_MASK definition - Removed redundant irq_fwspec checks in owl_sirq_domain_alloc() - Improved error handling in owl_sirq_of_init() - Added yaml binding document - Dropped S700 related DTS patches for lack of testing hardware: * arm64: dts: actions: Add sirq node for Actions Semi S700 * arm64: dts: actions: s700-cubieboard7: Enable SIRQ - Updated MAINTAINERS - Rebased patchset on kernel v5.8 - Cosmetic changes * Ordered include statements alphabetically * Added comment to owl_sirq_set_type() describing conversion of falling edge or active low signals * Replaced IRQF_TRIGGER_* with corresponding IRQ_TYPE_* variants * Ensured data types and function naming are consistent regarding the 'owl_sirq' prefix Changes in v3 (Parthiban Nallathambi): - Set default operating frequency to 24MHz - Falling edge and Low Level interrupts translated to rising edge and high level - Introduced common function with lock handling for register read and write - Used direct GIC interrupt number for interrupt local hwirq and finding offset using DT entry (range) when registers are shared - Changed irq_ack to irq_eoi - Added translation method for irq_domain_ops - Clearing interrupt pending based on bitmask for edge triggered - Added pinctrl definition for sirq for cubieboard7. This depends on, https://lore.kernel.org/patchwork/patch/1012859/ Changes in v2 (Parthiban Nallathambi): - Added SIRQ as hierarchical chip GIC <----> SIRQ <----> External interrupt controller/Child devices - Device binding updates with vendor prefix - Register sharing handled globally and common init sequence/data for all actions SoC family Cristian Ciocaltea (3): dt-bindings: interrupt-controller: Add Actions SIRQ controller binding irqchip: Add Actions Semi Owl SIRQ controller MAINTAINERS: Add entries for Actions Semi Owl SIRQ controller .../actions,owl-sirq.yaml | 68 ++++ MAINTAINERS | 2 + drivers/irqchip/Makefile | 1 + drivers/irqchip/irq-owl-sirq.c | 347 ++++++++++++++++++ 4 files changed, 418 insertions(+) create mode 100644 Documentation/devicetree/bindings/interrupt-controller/actions,owl-sirq.yaml create mode 100644 drivers/irqchip/irq-owl-sirq.c