From patchwork Fri Apr 2 10:10:44 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Syed Nayyar Waris X-Patchwork-Id: 12180745 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.2 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D8275C433ED for ; Fri, 2 Apr 2021 10:19:56 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2AF7E610D1 for ; Fri, 2 Apr 2021 10:19:55 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2AF7E610D1 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:Message-ID:Subject:Cc:To:From:Date: Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender :Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Owner; bh=479pFZxtxtJMzsrnsDC5XubaZG9kDxXgs/DMdaow3TQ=; b=RcQkCQ5Avt+EBzaW31Xl/HMLoU 3f3rpqectJSAL+JzuX6M63Vwv1u3JuNae9JA85H0WAZe++ulni/+aScxDwlcwXmioiSn/vXvK9uxF EdOCuetEN4cuzfDU9Ga6jBW4VOUYQmqk7fNryK+57+IgFLOemRVBsMz1qRAX6s5fOiw6+WJKe6DLF MVQ8gtRH8U/oG6VHszggVWFZpOna94kT0mMpMob3hpqTziJ5MQRDTNGoMPhcq4Om/GwPtwanmuWkz frUccamwtIyUL0o64hDvIf6oXCwOdijCRsdNxnfOMA7GqLfYAO90qj05hm9MPCTcQ6YUZ2FXL5GwM xVDmPDTw==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lSGrw-00CikZ-Ay; Fri, 02 Apr 2021 10:17:37 +0000 Received: from mail-pl1-x62e.google.com ([2607:f8b0:4864:20::62e]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lSGld-00ChXp-O9 for linux-arm-kernel@lists.infradead.org; Fri, 02 Apr 2021 10:11:17 +0000 Received: by mail-pl1-x62e.google.com with SMTP id y2so2332127plg.5 for ; Fri, 02 Apr 2021 03:11:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:mime-version:content-disposition :user-agent; bh=gPxPlJkhjlRcmhG+AYGmsIcUB9lxV1Qy07Ql0LeH3zw=; b=ftm6H1yakWnWGqrjXFE0PlTo+DKAxkT7NH5rBLt8f9t7BRqm++64+4C7pOOwp4GZzn 3Ay9V5knEczFP6x0D+kHKSJ5risO8x2g4YDwdkMMRpUyDJX3sLa0weEB2VwCK5/WJzXo waAawhBnmQAgWC91ht6Iz8NiMPfpwvg2d02/3gAYroBFssSL4X5iGWZSzIfj2Xq+oLRT Xq/DnxapoLtAa5+Mk9cfUQXxpUFH3Y8MZp+0KyOKyN3jq1MS0jXZ9zgDVmCYdEKrYRSw KJH74Yz2MQl9bGcY0ViKG7wWJbDS3CLyEtrvsD9qfkm7szghgwM8ugl4AvVLQ6wYxWr1 L4yg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:mime-version :content-disposition:user-agent; bh=gPxPlJkhjlRcmhG+AYGmsIcUB9lxV1Qy07Ql0LeH3zw=; b=Vknt6cMOnsXYUdrRjkmPWItkxYVQnbR+XWcuO6dVSWDCd3CF5EVajf1fwB/gBJ6ucq XwUIT2CoQOUM7IxBhJybW+KqrB2YdaoawzTYzIlSPYEwkjwEiy7PnComN3qhIo6HdjwT VGkR+DMgRRRhGD6SKoRYzf0HbFg4CJWFeUGEUveeUCoPZxKINsXJF7Y3ltHlmO8LIPYv STANW/WyjEelS4rq2HMaycDbZl8nnnoT+YvC6RJXe/D+VQU0RwTkuWZoCnmaS71kaYMN ofXkmVyw40gV6jwETmzMag4ZXeiCa6QROzK4VEtbFlGA1+lIPoO49rKaWZPLZ8UT2wK1 REdQ== X-Gm-Message-State: AOAM530klEhuPBTb0bMguJ+G70RH5YS9/Gk54kYZTPu3jjvY+ZHpjjF/ PEDVQqzw4xzby7OdxcyBoHg= X-Google-Smtp-Source: ABdhPJzdeGGNxdrgjG8DDwsn2kc7sSYRM74Hjy2lPY1s31Z5b1en6kSkcPhTeQE/tRNtFX65O4DDWg== X-Received: by 2002:a17:902:dacb:b029:e5:b538:9ce6 with SMTP id q11-20020a170902dacbb02900e5b5389ce6mr12107281plx.8.1617358262564; Fri, 02 Apr 2021 03:11:02 -0700 (PDT) Received: from syed ([223.225.111.29]) by smtp.gmail.com with ESMTPSA id k22sm7748079pfa.93.2021.04.02.03.10.54 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 02 Apr 2021 03:11:02 -0700 (PDT) Date: Fri, 2 Apr 2021 15:40:44 +0530 From: Syed Nayyar Waris To: bgolaszewski@baylibre.com Cc: andriy.shevchenko@linux.intel.com, vilhelm.gray@gmail.com, michal.simek@xilinx.com, arnd@arndb.de, rrichter@marvell.com, linus.walleij@linaro.org, bgolaszewski@baylibre.com, yamada.masahiro@socionext.com, akpm@linux-foundation.org, rui.zhang@intel.com, daniel.lezcano@linaro.org, amit.kucheria@verdurent.com, linux-arch@vger.kernel.org, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-pm@vger.kernel.org Subject: [PATCH v4 0/3] Introduce the for_each_set_nbits macro Message-ID: MIME-Version: 1.0 Content-Disposition: inline User-Agent: Mutt/1.5.24 (2015-08-30) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210402_111106_657216_07CA0446 X-CRM114-Status: GOOD ( 18.07 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hello Bartosz, Since this patchset primarily affects GPIO drivers, would you like to pick it up through your GPIO tree? This patchset introduces a new generic version of for_each_set_nbits. The previous version of for_each_set_clump8 used a fixed size 8-bit clump, but the new generic version can work with clump of any size but less than or equal to BITS_PER_LONG. The patchset utilizes the new macro in several GPIO drivers. The earlier 8-bit for_each_set_clump8 facilitated a for-loop syntax that iterates over a memory region entire groups of set bits at a time. For example, suppose you would like to iterate over a 32-bit integer 8 bits at a time, skipping over 8-bit groups with no set bit, where XXXXXXXX represents the current 8-bit group: Example: 10111110 00000000 11111111 00110011 First loop: 10111110 00000000 11111111 XXXXXXXX Second loop: 10111110 00000000 XXXXXXXX 00110011 Third loop: XXXXXXXX 00000000 11111111 00110011 Each iteration of the loop returns the next 8-bit group that has at least one set bit. But with the new for_each_set_nbits the clump size can be different from 8 bits. Moreover, the clump can be split at word boundary in situations where word size is not multiple of clump size. Following are examples showing the working of new macro for clump sizes of 24 bits and 6 bits. Example 1: clump size: 24 bits, Number of clumps (or ports): 10 bitmap stores the bit information from where successive clumps are retrieved. /* bitmap memory region */ 0x00aa0000ff000000; /* Most significant bits */ 0xaaaaaa0000ff0000; 0x000000aa000000aa; 0xbbbbabcdeffedcba; /* Least significant bits */ Different iterations of for_each_set_nbits:- 'offset' is the bit position and 'clump' is the 24 bit clump from the above bitmap. Iteration first: offset: 0 clump: 0xfedcba Iteration second: offset: 24 clump: 0xabcdef Iteration third: offset: 48 clump: 0xaabbbb Iteration fourth: offset: 96 clump: 0xaa Iteration fifth: offset: 144 clump: 0xff Iteration sixth: offset: 168 clump: 0xaaaaaa Iteration seventh: offset: 216 clump: 0xff Loop breaks because in the end the remaining bits (0x00aa) size was less than clump size of 24 bits. In above example it can be seen that in iteration third, the 24 bit clump that was retrieved was split between bitmap[0] and bitmap[1]. This example also shows that 24 bit zeroes if present in between, were skipped (preserving the previous for_each_set_macro8 behaviour). Example 2: clump size = 6 bits, Number of clumps (or ports) = 3. /* bitmap memory region */ 0x00aa0000ff000000; /* Most significant bits */ 0xaaaaaa0000ff0000; 0x0f00000000000000; 0x0000000000000ac0; /* Least significant bits */ Different iterations of for_each_set_nbits: 'offset' is the bit position and 'clump' is the 6 bit clump from the above bitmap. Iteration first: offset: 6 clump: 0x2b Loop breaks because 6 * 3 = 18 bits traversed in bitmap. Here 6 * 3 is clump size * no. of clumps. Changes in v4: - [Patch 3/3]: Remove extra line and add few comments. - [Patch 3/3]: Use single lock (and unlock) call instead of two lock (and two unlock) calls. - [Patch 3/3]: Use bitmap_from_arr32() where applicalble. - [Patch 3/3]: Remove unnecessary 'const'. Changes in v3: - [Patch 1/3]: Rename for_each_set_clump to for_each_set_nbits. - [Patch 1/3]: Shift function definitions outside 'ifdef CONFIG_DEBUG_FS' macro guard to resolve build (linking) error in xilinx Patch[3/3]. - [Patch 2/3]: Rename for_each_set_clump to for_each_set_nbits. Changes in v2: - [Patch 1/3]: Shift the macros and related functions to gpiolib inside gpio/. Reduce the visibilty of 'for_each_set_clump' to gpio. - [Patch 1/3]: Remove __builtin_unreachable and simply use return statement. - Remove tests from lib/test_bitmap.c as 'for_each_set_clump' is now localised inside gpio/ only. Syed Nayyar Waris (3): gpiolib: Introduce the for_each_set_nbits macro gpio: thunderx: Utilize for_each_set_nbits macro gpio: xilinx: Utilize generic bitmap_get_value and _set_value drivers/gpio/gpio-thunderx.c | 13 ++++-- drivers/gpio/gpio-xilinx.c | 60 ++++++++++++------------ drivers/gpio/gpiolib.c | 90 ++++++++++++++++++++++++++++++++++++ drivers/gpio/gpiolib.h | 28 +++++++++++ 4 files changed, 156 insertions(+), 35 deletions(-) base-commit: e1b7033ecdac56c1cc4dff72d67cac25d449efc6