mbox series

[v10,0/5] Move Hisilicon 6421v600 SPMI and USB drivers out of staging

Message ID cover.1624962269.git.mchehab+huawei@kernel.org (mailing list archive)
Headers show
Series Move Hisilicon 6421v600 SPMI and USB drivers out of staging | expand

Message

Mauro Carvalho Chehab June 29, 2021, 10:31 a.m. UTC
Hi Greg,

This series contain the final bits needed for the USB3 bus to work
without staging drivers on Hikey 970.

Tested on a Hikey 970:

	$ lsusb
	Bus 002 Device 002: ID 0451:8140 Texas Instruments, Inc. TUSB8041 4-Port Hub
	Bus 002 Device 001: ID 1d6b:0003 Linux Foundation 3.0 root hub
	Bus 001 Device 003: ID 046d:c52b Logitech, Inc. Unifying Receiver
	Bus 001 Device 002: ID 0451:8142 Texas Instruments, Inc. TUSB8041 4-Port Hub
	Bus 001 Device 001: ID 1d6b:0002 Linux Foundation 2.0 root hub

and checked that mouse events are working using evtest:

	...
	Input device ID: bus 0x3 vendor 0x46d product 0xc52b version 0x111
	Input device name: "Logitech USB Receiver Mouse"
	....
	Testing ... (interrupt to exit)
	Event: time 1624640001.871917, type 2 (EV_REL), code 0 (REL_X), value -4
	Event: time 1624640001.871917, type 2 (EV_REL), code 1 (REL_Y), value -3
	Event: time 1624640001.871917, -------------- SYN_REPORT ------------
	Event: time 1624640001.879868, type 2 (EV_REL), code 0 (REL_X), value -5
	Event: time 1624640001.879868, type 2 (EV_REL), code 1 (REL_Y), value -4
	....

v10:
  - Addressed some issues pointed by Axel Lin at the regulator;
  - Removed a now uneeded header file (hi6421-spmi-pmic.h);
  - Addressed a couple of checkpatch warnings and did minor
    cleanups.

Mauro Carvalho Chehab (5):
  staging: hikey9xx: split hi6421v600 irq into a separate driver
  regulator: hi6421v600-regulator: fix platform drvdata
  mfd: hi6421-spmi-pmic: move driver from staging
  dts: hisilicon: add support for the PMIC found on Hikey 970
  dts: hisilicon: add support for USB3 on Hikey 970

 .../mfd/hisilicon,hi6421-spmi-pmic.yaml       | 134 ++++++++
 MAINTAINERS                                   |   7 +
 .../boot/dts/hisilicon/hi3670-hikey970.dts    | 129 ++++++--
 arch/arm64/boot/dts/hisilicon/hi3670.dtsi     |  56 ++++
 .../boot/dts/hisilicon/hikey970-pmic.dtsi     |  87 +++++
 drivers/mfd/Kconfig                           |  16 +
 drivers/mfd/Makefile                          |   1 +
 drivers/mfd/hi6421-spmi-pmic.c                |  66 ++++
 drivers/misc/Kconfig                          |  10 +
 drivers/misc/Makefile                         |   1 +
 drivers/misc/hi6421v600-irq.c                 | 313 ++++++++++++++++++
 drivers/regulator/hi6421v600-regulator.c      |  49 +--
 drivers/staging/Kconfig                       |   2 -
 drivers/staging/Makefile                      |   1 -
 drivers/staging/hikey9xx/Kconfig              |  19 --
 drivers/staging/hikey9xx/Makefile             |   3 -
 drivers/staging/hikey9xx/TODO                 |   5 -
 drivers/staging/hikey9xx/hi6421-spmi-pmic.c   | 311 -----------------
 .../hikey9xx/hisilicon,hi6421-spmi-pmic.yaml  | 134 --------
 include/linux/mfd/hi6421-spmi-pmic.h          |  30 --
 20 files changed, 826 insertions(+), 548 deletions(-)
 create mode 100644 Documentation/devicetree/bindings/mfd/hisilicon,hi6421-spmi-pmic.yaml
 create mode 100644 arch/arm64/boot/dts/hisilicon/hikey970-pmic.dtsi
 create mode 100644 drivers/mfd/hi6421-spmi-pmic.c
 create mode 100644 drivers/misc/hi6421v600-irq.c
 delete mode 100644 drivers/staging/hikey9xx/Kconfig
 delete mode 100644 drivers/staging/hikey9xx/Makefile
 delete mode 100644 drivers/staging/hikey9xx/TODO
 delete mode 100644 drivers/staging/hikey9xx/hi6421-spmi-pmic.c
 delete mode 100644 drivers/staging/hikey9xx/hisilicon,hi6421-spmi-pmic.yaml
 delete mode 100644 include/linux/mfd/hi6421-spmi-pmic.h

Comments

Greg KH June 29, 2021, 10:43 a.m. UTC | #1
On Tue, Jun 29, 2021 at 12:31:26PM +0200, Mauro Carvalho Chehab wrote:
> Hi Greg,
> 
> This series contain the final bits needed for the USB3 bus to work
> without staging drivers on Hikey 970.

Thanks for these, I'll look at them after 5.14-rc1 is out.

greg k-h
Mauro Carvalho Chehab June 30, 2021, 8:28 a.m. UTC | #2
Em Tue, 29 Jun 2021 12:43:47 +0200
Greg Kroah-Hartman <gregkh@linuxfoundation.org> escreveu:

> On Tue, Jun 29, 2021 at 12:31:26PM +0200, Mauro Carvalho Chehab wrote:
> > Hi Greg,
> > 
> > This series contain the final bits needed for the USB3 bus to work
> > without staging drivers on Hikey 970.  
> 
> Thanks for these, I'll look at them after 5.14-rc1 is out.

Thanks!

I'll submit a v11 soon enough.

We're opting to solve a regression at the regulator driver using a 
different approach than on v10. 

We need to sync with Mark if the fixup patch from Axel [1] will be 
merged via the regulator's tree or together with this series, as there 
will be one (trivial) conflict, as one of the patches in this series
drop a priv struct, defined on a header that will also be dropped,
replacing it by struct regmap.

[1] https://lore.kernel.org/lkml/20210630100911.5e866629@coco.lan/T/#m598ee2e31ecdf560c3b752fd8b0518131f4bf123

Thanks,
Mauro