mbox series

[v2,0/3] staging: vc04_services: avoid the use of typedef for function pointers

Message ID cover.1640776340.git.gascoar@gmail.com (mailing list archive)
Headers show
Series staging: vc04_services: avoid the use of typedef for function pointers | expand

Message

Gaston Gonzalez Dec. 30, 2021, 11:31 a.m. UTC
This patch set removes some typedefs for function pointers in vc04_services.

v1 -> v2:

- Following Greg suggestion, functions pointers were not renamed making patches
  1 and 2 much smaller.
- Function pointers in vchiq-mmal were not touched as the result is less
  readable than the original.
- In the description of changes in the TODO file, it was specified that there
  are no current 'struct typedefs' left inside vc04_servivces. 
- The name of the particular subsystem of vc04_services was included in the
  title of each commit.

Gaston Gonzalez (3):
  staging: vc04_services: bcm2835-audio: avoid the use of typedef for
    function pointers
  staging: vc04_services: bcm2835-camera: avoid the use of typedef for
    function pointers
  staging: vc04_services: update TODO file

 .../staging/vc04_services/bcm2835-audio/bcm2835.c    | 12 +++---------
 .../staging/vc04_services/bcm2835-camera/controls.c  | 10 ++--------
 drivers/staging/vc04_services/interface/TODO         |  8 ++------
 3 files changed, 7 insertions(+), 23 deletions(-)

Comments

Greg Kroah-Hartman Dec. 30, 2021, 1:20 p.m. UTC | #1
On Thu, Dec 30, 2021 at 08:31:23AM -0300, Gaston Gonzalez wrote:
> This patch set removes some typedefs for function pointers in vc04_services.
> 
> v1 -> v2:
> 
> - Following Greg suggestion, functions pointers were not renamed making patches
>   1 and 2 much smaller.
> - Function pointers in vchiq-mmal were not touched as the result is less
>   readable than the original.
> - In the description of changes in the TODO file, it was specified that there
>   are no current 'struct typedefs' left inside vc04_servivces. 
> - The name of the particular subsystem of vc04_services was included in the
>   title of each commit.

Much nicer, thanks for redoing this.  Now queued up.

greg k-h