From patchwork Sun May 8 08:58:51 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Baolin Wang X-Patchwork-Id: 12842274 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 19ACDC433EF for ; Sun, 8 May 2022 09:00:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:List-Subscribe:List-Help: List-Post:List-Archive:List-Unsubscribe:List-Id:Message-Id:Date:Subject:Cc:To :From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=Ejq8kXs6qLMcs9aMWnrNSl7DDqoGqYxBWTkxw2saGC0=; b=qxcxN3wS1LoA0N j7bjORpdXRT5jgSnR8Vs+rJZ/qcZ3fBl3voCde1H8PqnpHyZociCVR02LgARjoEEOST44bAJlHUf5 TcAUVc3QtmdysV36DOnIA/iUPPl89mAmtUd6cu4yeFhMaAlffONYjvOt0nt6/CO00Q5ELa7SUKhD3 duQrhnS25eajL1PIecKOgnNiHPpVA+7YMEoviVuJLeym23ziT4YmhRehyhntMn13oAGD1MEYWohwK RdMOXKSere6SALC5ynAbq1kb2C5xzRIJwodUIGwKuUjaZlC9+PeILgZahZERwCzAZ1VzI330po6qp lbdRLaeyXa3NLNjaofgQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nncl1-009YQ5-Pt; Sun, 08 May 2022 08:59:15 +0000 Received: from out30-54.freemail.mail.aliyun.com ([115.124.30.54]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nncky-009YMM-Jw for linux-arm-kernel@lists.infradead.org; Sun, 08 May 2022 08:59:14 +0000 X-Alimail-AntiSpam: AC=PASS; BC=-1|-1; BR=01201311R761e4; CH=green; DM=||false|; DS=||; FP=0|-1|-1|-1|0|-1|-1|-1; HT=e01e04400; MF=baolin.wang@linux.alibaba.com; NM=1; PH=DS; RN=12; SR=0; TI=SMTPD_---0VCZqsya_1652000343; Received: from localhost(mailfrom:baolin.wang@linux.alibaba.com fp:SMTPD_---0VCZqsya_1652000343) by smtp.aliyun-inc.com(127.0.0.1); Sun, 08 May 2022 16:59:04 +0800 From: Baolin Wang To: catalin.marinas@arm.com, will@kernel.org, arnd@arndb.de, mike.kravetz@oracle.com, akpm@linux-foundation.org, sj@kernel.org Cc: baolin.wang@linux.alibaba.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org Subject: [RFC PATCH 0/3] Introduce new huge_ptep_get_access_flags() interface Date: Sun, 8 May 2022 16:58:51 +0800 Message-Id: X-Mailer: git-send-email 1.8.3.1 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220508_015912_859257_B2FBBB5B X-CRM114-Status: GOOD ( 10.96 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi, As Mike pointed out [1], the huge_ptep_get() will only return one specific pte value for the CONT-PTE or CONT-PMD size hugetlb on ARM64 system, which will not take into account the subpages' dirty or young bits of a CONT-PTE/PMD size hugetlb page. That will make us miss dirty or young flags of a CONT-PTE/PMD size hugetlb page for those functions that want to check the dirty or young flags of a hugetlb page. For example, the gather_hugetlb_stats() will get inaccurate dirty hugetlb page statistics, and the DAMON for hugetlb monitoring will also get inaccurate access statistics. To fix this issue, one approach is that we can define an ARM64 specific huge_ptep_get() implementation, which will take into account any subpages' dirty or young bits. However we should add a new parameter for ARM64 specific huge_ptep_get() to check how many continuous PTEs or PMDs in this CONT-PTE/PMD size hugetlb, that means we should convert all the places using huge_ptep_get(), meanwhile most places using huge_ptep_get() did not care about the dirty or young flags at all. So instead of changing the prototype of huge_ptep_get(), this patch set introduces a new huge_ptep_get_access_flags() interface and define an ARM64 specific implementation, that will take into account any subpages' dirty or young bits for CONT-PTE/PMD size hugetlb page. And we can only change to use huge_ptep_get_access_flags() for those functions that care about the dirty or young flags of a hugetlb page. [1] https://lore.kernel.org/linux-mm/85bd80b4-b4fd-0d3f-a2e5-149559f2f387@oracle.com/ Baolin Wang (3): arm64/hugetlb: Introduce new huge_ptep_get_access_flags() interface fs/proc/task_mmu: Change to use huge_ptep_get_access_flags() mm/damon/vaddr: Change to use huge_ptep_get_access_flags() arch/arm64/include/asm/hugetlb.h | 2 ++ arch/arm64/mm/hugetlbpage.c | 24 ++++++++++++++++++++++++ fs/proc/task_mmu.c | 3 ++- include/asm-generic/hugetlb.h | 7 +++++++ mm/damon/vaddr.c | 5 +++-- 5 files changed, 38 insertions(+), 3 deletions(-)