From patchwork Tue Mar 12 17:34:02 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Robin Murphy X-Patchwork-Id: 13590443 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id F00BDC54E5D for ; Tue, 12 Mar 2024 17:34:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:Cc :To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=CA+DjH+D2c5rEdHLDlplMfEKHMj+91o3o/JDBLkaxdY=; b=HQ3bAxVVhBB+Pe Pxqhs2pmlEdrJhoQ+bPNnXM5KleXiqakN2Qx/gKyke/vShs/HkumCMIPNho5QjA7nsIKgcfxzYN1P AQHNa4Cf+eKsJd6Pg2vsRSy49aLwMgF1pctmSIRUKd+s5BmWOvPRugdFXJcyYZnQ1LaoaJhN28uCm 9am21BhFRYsV34yCyp430o5kelg6rX+XO4W36JcFN7e8zCAl62FY1fKKuBOkxQGzvXdQc4F7Tzpn9 Yw9DaR/V6tuoDCd4eW4CzUHdPmHT5qSEOQEKSLNSlWMN61X70FBHUm1cqIQt0oRY65Kzuo/aAFdzf XvSHI3CXxEWmR+6k/Ciw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rk61M-00000006sER-36is; Tue, 12 Mar 2024 17:34:36 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rk61G-00000006s9t-24ES for linux-arm-kernel@lists.infradead.org; Tue, 12 Mar 2024 17:34:32 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id CDA101570; Tue, 12 Mar 2024 10:35:01 -0700 (PDT) Received: from e121345-lin.cambridge.arm.com (e121345-lin.cambridge.arm.com [10.1.196.40]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 9BAB63F762; Tue, 12 Mar 2024 10:34:22 -0700 (PDT) From: Robin Murphy To: Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Namhyung Kim , Mark Rutland , Will Deacon Cc: Alexander Shishkin , Jiri Olsa , Ian Rogers , Adrian Hunter , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, x86@kernel.org, linux-perf-users@vger.kernel.org, jialong.yang@shingroup.cn Subject: [PATCH 00/10] perf: Clean up common uncore boilerplate Date: Tue, 12 Mar 2024 17:34:02 +0000 Message-Id: X-Mailer: git-send-email 2.39.2.101.g768bb238c484.dirty MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240312_103430_650362_BAA1F431 X-CRM114-Status: GOOD ( 14.42 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi all, Since this came up yet again recently, and it's an idea which has been nagging me for years, I decided it was time to see how hard it really would be to start shaving this yak. And it turns out to be refreshingly simple - the core code has quietly become capable of doing most of what we want, the one new functional addition is trivial (patch #2), and the resulting largely-mechanical cleanup seems a pretty nice win. This series is focused on drivers/perf/ as that's where most mess is concentrated, but figured I'd include the arch/ patches as well since they might be reasonable to land with the core changes, at least for x86 (FWIW I did also look at the powerpc drivers but they scared me and I ran away; sorry). The remaining stragglers elsewhere around the tree I'd come back to as a follow-up. (And yes, I appreciate it's mid-merge-window already, but since I do have a tree-wide rename proposed here, may as well give the discussion a chance for a head start before -rc1...) Thanks, Robin. Robin Murphy (10): perf/alibaba_uncore_drw: Use correct CPU affinity perf: Add capability for common event support drivers/perf: Use PERF_PMU_CAP_NO_COMMON_EVENTS perf: Rename PERF_PMU_CAP_NO_INTERRUPT drivers/perf: Use PERF_PMU_CAP_NO_SAMPLING consistently drivers/perf: Clean up redundant per-task checks perf: Define common uncore capabilities drivers/perf: Use common uncore capabilities x86: Use common uncore PMU capabilities ARM: Use common uncore PMU capabilities arch/arc/kernel/perf_event.c | 2 +- arch/arm/mach-imx/mmdc.c | 16 +------------- arch/arm/mm/cache-l2x0-pmu.c | 12 +--------- arch/csky/kernel/perf_event.c | 2 +- arch/powerpc/perf/8xx-pmu.c | 2 +- arch/powerpc/perf/hv-24x7.c | 2 +- arch/powerpc/perf/hv-gpci.c | 2 +- arch/powerpc/platforms/pseries/papr_scm.c | 2 +- arch/s390/kernel/perf_cpum_cf.c | 2 +- arch/sh/kernel/perf_event.c | 2 +- arch/x86/events/amd/iommu.c | 17 +------------- arch/x86/events/amd/power.c | 10 +-------- arch/x86/events/amd/uncore.c | 12 +++------- arch/x86/events/core.c | 2 +- arch/x86/events/intel/cstate.c | 16 +++----------- arch/x86/events/intel/uncore.c | 11 +-------- arch/x86/events/intel/uncore_snb.c | 20 +++-------------- arch/x86/events/msr.c | 9 +------- arch/x86/events/rapl.c | 9 +------- drivers/fpga/dfl-fme-perf.c | 2 +- drivers/perf/alibaba_uncore_drw_pmu.c | 27 +++-------------------- drivers/perf/amlogic/meson_ddr_pmu_core.c | 11 +-------- drivers/perf/arm-cci.c | 15 +------------ drivers/perf/arm-ccn.c | 20 +---------------- drivers/perf/arm-cmn.c | 10 +-------- drivers/perf/arm_cspmu/arm_cspmu.c | 27 ++--------------------- drivers/perf/arm_dmc620_pmu.c | 18 +-------------- drivers/perf/arm_dsu_pmu.c | 22 +----------------- drivers/perf/arm_pmu_platform.c | 2 +- drivers/perf/arm_smmuv3_pmu.c | 15 +------------ drivers/perf/arm_spe_pmu.c | 7 ++---- drivers/perf/cxl_pmu.c | 8 +------ drivers/perf/dwc_pcie_pmu.c | 13 +---------- drivers/perf/fsl_imx8_ddr_perf.c | 13 +---------- drivers/perf/fsl_imx9_ddr_perf.c | 13 +---------- drivers/perf/hisilicon/hisi_pcie_pmu.c | 10 +-------- drivers/perf/hisilicon/hisi_uncore_pmu.c | 20 +---------------- drivers/perf/hisilicon/hns3_pmu.c | 9 +------- drivers/perf/marvell_cn10k_ddr_pmu.c | 15 +------------ drivers/perf/marvell_cn10k_tad_pmu.c | 6 +---- drivers/perf/qcom_l2_pmu.c | 21 ++---------------- drivers/perf/qcom_l3_pmu.c | 21 +----------------- drivers/perf/riscv_pmu_sbi.c | 2 +- drivers/perf/thunderx2_pmu.c | 17 +------------- drivers/perf/xgene_pmu.c | 16 +------------- include/linux/perf_event.h | 6 ++++- kernel/events/core.c | 7 +++++- 47 files changed, 67 insertions(+), 456 deletions(-) Reviewed-by: James Clark