From patchwork Thu May 30 10:11:57 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andrea della Porta X-Patchwork-Id: 13680113 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 100FAC25B74 for ; Thu, 30 May 2024 10:12:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:Subject:Cc :To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=2UUA3h7b/L11AP1tHt5/GUvNlQAGmKNn5kQMNYmwIQ8=; b=DXyrTbFgtqnDy7 hSKCWMpKnWQ0nf+V+YDmT6LPqXOoeOOvCU1zSUFNmyPUxJKhHzUTRnbGNY5DWQ35nrbtq6rg/izm+ AwoFUOvLCBfKP6OpGBPikfn+wwM6ZEcYYK2qs+x1sXHzkrdKGFulWWF498Rpz1NOaPYSfkvSvOqGD 8+jPpaNj6Ps437DPLzj2NiaUDtmQKRcV7SOu+HYRuJGlRUisdAmx2GNG+xvQB01r2zuXWN4ZeBfyb REHSK2Brx9xk5wo3eTyka6aTgNx1P2npEsIt3OkVSCZJCUnj1kgUI6emR2Od25VYXvltfeSyXoAWm 8lGX9ycPtG6H3gJyC/OQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sCclG-00000006wYY-37HE; Thu, 30 May 2024 10:11:54 +0000 Received: from mail-ed1-x52c.google.com ([2a00:1450:4864:20::52c]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sCclE-00000006wWm-0OuC for linux-arm-kernel@lists.infradead.org; Thu, 30 May 2024 10:11:53 +0000 Received: by mail-ed1-x52c.google.com with SMTP id 4fb4d7f45d1cf-57a1e980a65so441375a12.2 for ; Thu, 30 May 2024 03:11:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1717063910; x=1717668710; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=WxB6vVIAxKAJRnWfHDwiheUcKLANimvzznXfGKQj6Bk=; b=QminZF7j1oTFc46sVl/tS1HQ+HyUMwUbrPrUWK31w/fG+6oINm1TPSfXejYafVnSAL NiWf+f9KN6nqu5TAHSSN6AblhiRYMX7W+43M1YoKLvp7LH5AYiEoUdjDXZBV4LXcuTBx 3V/9i4s0ElUnqofnvywhc2ZUWZ4+XTE26DbzH2fmTBVFIPMl7dOXPN+T6lLAMCScdaBr 3XtnArgEBGSTc9MNI0homdgoN6W0ieHAdBg+rmyPvlPSF8y1XoIp9rZIN9Z/cOXzAwqi rqWWaD9WPooyscBDZcRxhgBd7ZPR8OiPNKgX/7F3pOaVmjf7bpspe9y+ssKD3CTL0oPS htJw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1717063910; x=1717668710; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=WxB6vVIAxKAJRnWfHDwiheUcKLANimvzznXfGKQj6Bk=; b=wSh9UIQRo9g8J9yg0wkkDRvPWoEOyIbL0zEHj/s0gNmd9apH218j3nRYpEmf+TMI8v dp7sgeBqC8Ts7t6xVjIDm1WL2J0pgjyNO8cWIXoXGva/zzVbtzutNVNwzPoh7NadiwG6 v3JD91u/hMZ74VlP/peX2XaQM91TDPG0eX31Cuqcs/6WrAmB08Y/m5CRmhH/ihOL4p86 WcIn43XmoKpFTgny0j565R6gfI2aPz5lJpVNX6DQURh9ega9iypW+VYostQzcwSS0zb6 gVvqUOnNRJ0HkwTLMoQFXUBJ4ByEWA3iEewr14LEdx6p+BCB0rWq05AUi1548YyWLcaj lEIg== X-Forwarded-Encrypted: i=1; AJvYcCXq4lncu28bYyHoP5InRFktwCRaVweEtxy65312QW9YdYMKyvhRoS4ti/0QcEeuIGGxNnY2vYWERflGbvMrY6Kd77VqbPtxUM901vhta4Ox8uEFGq8= X-Gm-Message-State: AOJu0Yx3VkqH/vbaHQhmHWc5SuFJOxLj7hjr07eorGtmivFB2u5t5e80 GvEQb9uPsGWG4g2wLpTT6gD/vootovNajJJWfXE4/OB4alqp8/hMteIgnl6JN84= X-Google-Smtp-Source: AGHT+IGAqVcwnQPl/3CgZD4XLSZ6kROjcJ3UsjrJVNy/fPCBJ8FCqFEl8EuImSsnZcB+tM1Cmf75Lg== X-Received: by 2002:a50:9b57:0:b0:578:610d:b889 with SMTP id 4fb4d7f45d1cf-57a17806552mr1075945a12.24.1717063910225; Thu, 30 May 2024 03:11:50 -0700 (PDT) Received: from localhost (host-87-16-233-11.retail.telecomitalia.it. [87.16.233.11]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-579c3bbee4asm6727551a12.76.2024.05.30.03.11.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 30 May 2024 03:11:49 -0700 (PDT) From: Andrea della Porta To: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Florian Fainelli , Ray Jui , Scott Branden , Broadcom internal kernel review list , Ulf Hansson , Adrian Hunter , Kamal Dasu , Al Cooper , Stefan Wahren , devicetree@vger.kernel.org, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mmc@vger.kernel.org Cc: Andrea della Porta Subject: [PATCH v5 0/4] Add minimal boot support for Raspberry Pi 5 Date: Thu, 30 May 2024 12:11:57 +0200 Message-ID: X-Mailer: git-send-email 2.44.0 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240530_031152_180931_AF20F189 X-CRM114-Status: GOOD ( 24.95 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi, This patchset adds minimal support for the Broadcom BCM2712 SoC and for the on-board SDHCI controller on Broadcom BCM2712 in order to make it possible to boot (particularly) a Raspberry Pi 5 from SD card and get a console through uart. Changes to arm64/defconfig are not needed since the actual options work as they are. This work is heavily based on downstream contributions. Tested on Tumbleweed substituting the stock kernel with upstream one, either chainloading uboot+grub+kernel or directly booting the kernel from 1st stage bootloader. Steps to reproduce: - prepare an SD card from a Raspberry enabled raw image, mount the first FAT partition. - make sure the FAT partition is big enough to contain the kernel, anything bigger than 64Mb is usually enough, depending on your kernel config options. - build the kernel and dtbs making sure that the support for your root fs type is compiled as builtin. - copy the kernel image in your FAT partition overwriting the older one (e.g. kernel*.img for Raspberry Pi OS or u-boot.bin for Tumbleweed). - copy arch/arm64/boot/dts/broadcom/bcm2712-rpi-5-b.dtb on FAT partition. - make sure you have a cmdline.txt file in FAT partition with the following content: # cat /boot/efi/cmdline.txt root=/dev/mmcblk0p3 rootwait rw console=tty ignore_loglevel earlycon console=ttyAMA10,115200 - if you experience random SD issues during boot, try to set initial_turbo=0 in config.txt. Changes in V5: DTS: - axi node merged into soc node - redefined the mapping ranges of the soc node to have proper translation, and a narrower address and size cell number for child nodes.Child nodes reg properties adjusted accordingly - augemented the comment in 'gio_aon' node sdhci-brcmstb.c: - removed unused 'base_clk_mhz' variable Changes in V4: sdhci-brcmstb.c: - dropped the last 4 lines of sdhci_brcmstb_cfginit_2712() function to avoid setting the SDIO_CFG_CQ_CAPABILITY register. The rationale behind this can be found in [4] and subsequent comments DT-bindings: - simplified the compatible item list for 'brcm,bcm2712-sdhci' as per [5] Changes in V3: DTS: - uart0 renamed to uart10 to reflect the current indexing (ttyAMA10 and serial10) - updated the license to (GPL-2.0 OR MIT) - sd_io_1v8_reg 'states' property have second cells as decimal instead of hex. - root node has size-cells=<2> now to accommodate for the DRAM controller and the address bus mapping that goes beyond 4GB. As a consequence, memory, axi and reserved-memory nodes have also size-cells=<2> and subnodes reg and ranges properties have been updated accordingly - ranges property in 'axi' node has been fixed, reg properties of sdio1 and gicv2 subnodes have been adjusted according to the new mapping - 'interrupt-controller@7d517000' node is now enabled by default - dropped 'arm,cpu-registers-not-fw-configured' as it is no longer relevant on A76 core - l2 cache nodes moved under respective cpus, since they are per-cpu - dropped psci cpu functions properties - added the hypervisor EL2 virtual timer interrupt to the 'timer' node - splitted-lines url are now on a single line sdhci-brcmstb.c: - simplified MMC_CAP_HSE_MASK leveraging already existing definitions - MMC_CAP_UHS_MASK renamed to MMC_CAP_UHS_I_SDR_MASK to better reflect its purpose. Added also a comment. - sdhci_brcmstb_set_power() replaced with the already existing (and equivalent) sdhci_set_power_and_bus_voltage() DT-bindings: - removed the BCM2712 specific example, as per Rob's request Changes in V2: - the patchshet has been considerably simplified, both in terms of dts and driver code. Notably, the pinctrl/pinmux driver (and associated binding) was not strictly needed to use the SD card so it has been dropped - dropped the optional SD express support patch - the patches order has been revisited - pass all checks (binding, dtb, checkpatch) Many thanks, Andrea References: [1] - Link to V1: https://lore.kernel.org/all/cover.1713036964.git.andrea.porta@suse.com/ [2] - Link to V2: https://lore.kernel.org/all/cover.1715332922.git.andrea.porta@suse.com/ [3] - Link to V3: https://lore.kernel.org/all/cover.1716277695.git.andrea.porta@suse.com/ [4] - https://lore.kernel.org/all/ZlF5dQbNpZ921e66@apocalypse/ [5] - https://lore.kernel.org/all/bc1eb98c-9d49-4424-ab89-16be6c67c3f5@gmx.net/#t Andrea della Porta (4): dt-bindings: arm: bcm: Add BCM2712 SoC support dt-bindings: mmc: Add support for BCM2712 SD host controller mmc: sdhci-brcmstb: Add BCM2712 support arm64: dts: broadcom: Add minimal support for Raspberry Pi 5 .../devicetree/bindings/arm/bcm/bcm2835.yaml | 6 + .../bindings/mmc/brcm,sdhci-brcmstb.yaml | 1 + arch/arm64/boot/dts/broadcom/Makefile | 1 + .../boot/dts/broadcom/bcm2712-rpi-5-b.dts | 64 ++++ arch/arm64/boot/dts/broadcom/bcm2712.dtsi | 283 ++++++++++++++++++ drivers/mmc/host/sdhci-brcmstb.c | 60 ++++ 6 files changed, 415 insertions(+) create mode 100644 arch/arm64/boot/dts/broadcom/bcm2712-rpi-5-b.dts create mode 100644 arch/arm64/boot/dts/broadcom/bcm2712.dtsi