From patchwork Mon Mar 3 07:53:39 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jingoo Han X-Patchwork-Id: 3751961 Return-Path: X-Original-To: patchwork-linux-arm@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork1.web.kernel.org (Postfix) with ESMTP id C1BE49F1EE for ; Mon, 3 Mar 2014 07:54:36 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id D4F0E203AB for ; Mon, 3 Mar 2014 07:54:35 +0000 (UTC) Received: from casper.infradead.org (casper.infradead.org [85.118.1.10]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CD04420171 for ; Mon, 3 Mar 2014 07:54:34 +0000 (UTC) Received: from merlin.infradead.org ([2001:4978:20e::2]) by casper.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1WKNhT-0004bC-Jg; Mon, 03 Mar 2014 07:54:11 +0000 Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1WKNhR-0005sq-8f; Mon, 03 Mar 2014 07:54:09 +0000 Received: from mailout4.samsung.com ([203.254.224.34]) by merlin.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1WKNhN-0005s0-R8 for linux-arm-kernel@lists.infradead.org; Mon, 03 Mar 2014 07:54:07 +0000 Received: from epcpsbgr5.samsung.com (u145.gpu120.samsung.co.kr [203.254.230.145]) by mailout4.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0N1U00BZEOLGE950@mailout4.samsung.com> for linux-arm-kernel@lists.infradead.org; Mon, 03 Mar 2014 16:53:40 +0900 (KST) Received: from epcpsbgm2.samsung.com ( [203.254.230.48]) by epcpsbgr5.samsung.com (EPCPMTA) with SMTP id 62.F6.14803.40534135; Mon, 03 Mar 2014 16:53:40 +0900 (KST) X-AuditID: cbfee691-b7efc6d0000039d3-10-531435048416 Received: from epmmp1.local.host ( [203.254.227.16]) by epcpsbgm2.samsung.com (EPCPMTA) with SMTP id BB.58.28157.40534135; Mon, 03 Mar 2014 16:53:40 +0900 (KST) Received: from DOJG1HAN03 ([12.36.166.146]) by mmp1.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTPA id <0N1U00F1ROLF0HR1@mmp1.samsung.com>; Mon, 03 Mar 2014 16:53:39 +0900 (KST) From: Jingoo Han To: 'Lucas Stach' , linux-arm-kernel@lists.infradead.org References: <1393608523-17509-1-git-send-email-l.stach@pengutronix.de> <1393608523-17509-5-git-send-email-l.stach@pengutronix.de> <000401cf36b3$e4aa0fb0$adfe2f10$%han@samsung.com> In-reply-to: <000401cf36b3$e4aa0fb0$adfe2f10$%han@samsung.com> Subject: Re: [PATCH 4/7] ARM: dts: exynos5440: fix PCIe interrupt mapping Date: Mon, 03 Mar 2014 16:53:39 +0900 Message-id: <000501cf36b5$b0a27110$11e75330$%han@samsung.com> MIME-version: 1.0 X-Mailer: Microsoft Office Outlook 12.0 Thread-index: Ac80qqqzTC13EZuTT1eJgWirI5kGhACCPmyAAABgKfA= Content-language: ko X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrFKsWRmVeSWpSXmKPExsVy+t8zA10WU5Fgg8MbJSz+TjrGbjFp3QEm iyVNGRYvD2lazD9yjtWieetXRovLCy+xWqyaupPFonfBVTaLB3NvMllsenyN1WLG+X1MFnP+ TGG26Pwyi81i6fWLTBaPZwlbPF23hNni1cE2FouLJz4xW/zcNY/FQcRjzbw1jB6/f01i9Pi7 6gWzx7/D/Uwe53rusnnsnHWX3WPBplKPO9f2sHlsXlLv0f/XwKNvyypGjzk/v7F4fN4k57Fx bmgAXxSXTUpqTmZZapG+XQJXxul3B9kKbvFXzF9wn62BcSNPFyMnh4SAiUTv+jNsELaYxIV7 64FsLg4hgWWMEv9WN7DBFM1fsI8VIrGIUeL9pu1Qzm9GiYXnXoBVsQmoSXz5cpgdxBYRCJD4 8O4tI4jNLPCSReLmBzuIhu2MEnNWvgIr4hSwk2g4MoUZxBYW8JTYeeQ7mM0ioCqx595JsBpe AVuJGzfuQNmCEj8m32OBGKolsX7ncSYIW15i85q3QL0cQKeqSzz6qwtxg5XEs4UQq5gFRCT2 vXjHCHKDhEA7p8TdvZfZIXYJSHybfIgFoldWYtMBZoiPJSUOrrjBMoFRYhaSzbOQbJ6FZPMs JCsWMLKsYhRNLUguKE5KLzLVK07MLS7NS9dLzs/dxAhJRxN3MN4/YH2IMRlo/URmKdHkfGA6 yyuJNzQ2M7IwNTE1NjK3NCNNWEmcN/1RUpCQQHpiSWp2ampBalF8UWlOavEhRiYOTqkGxrp5 b9ecSrL6vcqYsZ352Z2j7TJ2R8QfzQ+bWbfqh2qP0L57f5fcaWO6ecF54h13pUWvszvtvbUk H4d18n6PE1wwo1Rlbcwx13mmT/TmZHyeNfGJyJazN9NNdnhYOS+6nBOutidMcJdv7WzF9Kk3 NZindtqv7RDcbl3YaxJw5PNZlYIcJrnCT0osxRmJhlrMRcWJAEPluNFdAwAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrOJsWRmVeSWpSXmKPExsVy+t9jAV0WU5Fgg8OThCz+TjrGbjFp3QEm iyVNGRYvD2lazD9yjtWieetXRovLCy+xWqyaupPFonfBVTaLB3NvMllsenyN1WLG+X1MFnP+ TGG26Pwyi81i6fWLTBaPZwlbPF23hNni1cE2FouLJz4xW/zcNY/FQcRjzbw1jB6/f01i9Pi7 6gWzx7/D/Uwe53rusnnsnHWX3WPBplKPO9f2sHlsXlLv0f/XwKNvyypGjzk/v7F4fN4k57Fx bmgAX1QDo01GamJKapFCal5yfkpmXrqtkndwvHO8qZmBoa6hpYW5kkJeYm6qrZKLT4CuW2YO 0LtKCmWJOaVAoYDE4mIlfTtME0JD3HQtYBojdH1DguB6jAzQQMI6xozT7w6yFdzir5i/4D5b A+NGni5GTg4JAROJ+Qv2sULYYhIX7q1n62Lk4hASWMQo8X7TdlYI5zejxMJzL9hAqtgE1CS+ fDnMDmKLCARIfHj3lhHEZhZ4ySJx84MdRMN2Rok5K1+BFXEK2Ek0HJnCDGILC3hK7DzyHcxm EVCV2HPvJFgNr4CtxI0bd6BsQYkfk++xQAzVkli/8zgThC0vsXnNW6BeDqBT1SUe/dWFuMFK 4tlCiFXMAiIS+168Y5zAKDQLyaRZSCbNQjJpFpKWBYwsqxhFUwuSC4qT0nON9IoTc4tL89L1 kvNzNzGCk90z6R2MqxosDjEKcDAq8fAaLBUOFmJNLCuuzD3EKMHBrCTCm78MKMSbklhZlVqU H19UmpNafIgxGejRicxSosn5wEScVxJvaGxiZmRpZGZhZGJuTpqwkjjvwVbrQCGB9MSS1OzU 1ILUIpgtTBycUg2MacftZ3FLJcx+2tu8x794smeb2xfT/b8nrT196bz1e267S8fvuF9s/lXa P5mX+9uB34r3eR9Mm7fy2baWnWLvzgTJbbwnZb3fo+z6znlZJ5+GTLL/57x8RuI8f60zWkqy u7snPTz77HS/4YzNhZxaNf4xmZeU7vXfCPp5YdrUHwqvJsUu5NxR1qXEUpyRaKjFXFScCAD7 JdscugMAAA== DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20140303_025406_102745_13860CC9 X-CRM114-Status: GOOD ( 14.28 ) X-Spam-Score: -4.2 (----) Cc: 'Mark Rutland' , devicetree@vger.kernel.org, 'Jingoo Han' , linux-samsung-soc@vger.kernel.org, 'Richard Zhu' , kernel@pengutronix.de, 'Arnd Bergmann' , linux-sh@vger.kernel.org, 'Tim Harvey' , 'Stephen Warren' , 'Bjorn Helgaas' , 'Simon Horman' , 'Thierry Reding' , 'Ben Dooks' , linux-tegra@vger.kernel.org, 'Kukjin Kim' , 'Shawn Guo' X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Spam-Status: No, score=-1.2 required=5.0 tests=BAYES_00,KHOP_BIG_TO_CC, RCVD_IN_DNSWL_MED, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=no version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP On Monday, March 03, 2014 4:41 PM, Jingoo Han wrote: > On Saturday, March 01, 2014 2:29 AM, Lucas Stach wrote: > > > > So it actually works. > > > > Signed-off-by: Lucas Stach > > --- > > arch/arm/boot/dts/exynos5440.dtsi | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/arch/arm/boot/dts/exynos5440.dtsi b/arch/arm/boot/dts/exynos5440.dtsi > > index 02a0a1226cef..65d425d9ec27 100644 > > --- a/arch/arm/boot/dts/exynos5440.dtsi > > +++ b/arch/arm/boot/dts/exynos5440.dtsi > > @@ -274,7 +274,7 @@ > > 0x82000000 0 0x40011000 0x40011000 0 0x1ffef000>; /* non-prefetchable memory */ > > #interrupt-cells = <1>; > > interrupt-map-mask = <0 0 0 0>; > > - interrupt-map = <0x0 0 &gic 53>; > > + interrupt-map = <0 0 0 0 &gic GIC_SPI 21 IRQ_TYPE_LEVEL_HIGH>; > > It makes build errors as below: > > DTC arch/arm/boot/dts/exynos5440-ssdk5440.dtb > Error: arch/arm/boot/dts/exynos5440.dtsi:289.33-34 syntax error > FATAL ERROR: Unable to parse input tree > make[1]: *** [arch/arm/boot/dts/exynos5440-ssdk5440.dtb] Error 1 > make: *** [exynos5440-ssdk5440.dtb] Error 2 > > Would you fix it? I fixed build errors after including 'arm-gic.h' as below: Best regards, Jingoo Han > > > num-lanes = <4>; > > status = "disabled"; > > }; > > @@ -295,7 +295,7 @@ > > 0x82000000 0 0x60011000 0x60011000 0 0x1ffef000>; /* non-prefetchable memory */ > > #interrupt-cells = <1>; > > interrupt-map-mask = <0 0 0 0>; > > - interrupt-map = <0x0 0 &gic 56>; > > + interrupt-map = <0 0 0 0 &gic GIC_SPI 24 IRQ_TYPE_LEVEL_HIGH>; > > num-lanes = <4>; > > status = "disabled"; > > }; > > -- > > 1.8.5.3 --- a/arch/arm/boot/dts/exynos5440.dtsi +++ b/arch/arm/boot/dts/exynos5440.dtsi @@ -9,6 +9,8 @@ * published by the Free Software Foundation. */ +#include + #include "skeleton.dtsi" Would you confirm this?