From patchwork Tue May 27 11:39:24 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kim Kukjin X-Patchwork-Id: 4248721 Return-Path: X-Original-To: patchwork-linux-arm@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 83A89BF90B for ; Tue, 27 May 2014 11:42:30 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id C247820279 for ; Tue, 27 May 2014 11:42:29 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.9]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E2C4F2025A for ; Tue, 27 May 2014 11:42:28 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1WpFjn-0006nv-Qv; Tue, 27 May 2014 11:40:11 +0000 Received: from mailout4.samsung.com ([203.254.224.34]) by bombadil.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1WpFjV-0005ci-JI for linux-arm-kernel@lists.infradead.org; Tue, 27 May 2014 11:39:54 +0000 Received: from epcpsbgr4.samsung.com (u144.gpu120.samsung.co.kr [203.254.230.144]) by mailout4.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0N680091FDPSLJ20@mailout4.samsung.com> for linux-arm-kernel@lists.infradead.org; Tue, 27 May 2014 20:39:28 +0900 (KST) Received: from epcpsbgm2.samsung.com ( [203.254.230.48]) by epcpsbgr4.samsung.com (EPCPMTA) with SMTP id 68.B4.13369.07974835; Tue, 27 May 2014 20:39:28 +0900 (KST) X-AuditID: cbfee690-b7fb56d000003439-6e-538479708853 Received: from epmmp2 ( [203.254.227.17]) by epcpsbgm2.samsung.com (EPCPMTA) with SMTP id 45.86.07139.F6974835; Tue, 27 May 2014 20:39:27 +0900 (KST) Received: from DOKGENEKIM03 ([12.36.166.133]) by mmp2.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTPA id <0N68009J6DPRKY80@mmp2.samsung.com>; Tue, 27 May 2014 20:39:27 +0900 (KST) From: Kukjin Kim To: 'Arnd Bergmann' , 'Abhilash Kesavan' References: <1399307221-8659-1-git-send-email-a.kesavan@samsung.com> <1399307221-8659-6-git-send-email-a.kesavan@samsung.com> <201405271307.56729.arnd@arndb.de> In-reply-to: <201405271307.56729.arnd@arndb.de> Subject: RE: [PATCH v5 5/5] arm: exynos: Add MCPM call-back functions Date: Tue, 27 May 2014 20:39:24 +0900 Message-id: <002101cf79a0$50fba0f0$f2f2e2d0$@samsung.com> MIME-version: 1.0 X-Mailer: Microsoft Outlook 14.0 Thread-index: AQDvUpY8CY2JHNZcTUmeS7FTJuvJRAFg8ukSAeozHn2c+kBUQA== Content-language: ko X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrBKsWRmVeSWpSXmKPExsVy+t8zA92CypZgg/1/WSwer1nMZLHy/V9G i7+TjrFbzPssa9E0dw+jxfwj51gtDvzZwWix+94XRos1f5UsNj2+xmox4/w+Jos3v1+wWyy9 fpHJ4tOzf+wWrXuPsFusn/GaxaJjGaPFy48nWByEPNbMW8Po8fvXJEaP2Q0XWTx2zrrL7rFp VSebx51re9g8Ni+p9+jbsorR4/MmuQDOKC6blNSczLLUIn27BK6MHy+2shf85ql4fLeTqYFx D1cXIyeHhICJxIXmg8wQtpjEhXvr2boYuTiEBJYxSvyd94MVpmjb88msEInpjBI7Lr9iAkkI CfxllGjdKQliswloSBx+/4wdxBYR8Jc4/P8XM0gDs8ASZomTM7qgxi5hlJjTfhmsm1NAX6L/ 9mIgm4NDWMBV4kxjHkiYRUBVYmb3G2aQMK+ApcThSQ4gYV4BQYkfk++xgNjMAloS63ceZ4Kw 5SU2r3kL9YGCxI6zrxkhbnCS+H7nKitEjYjEvhfvGCFq7nBIPDzqAbFKQOLb5EMsIKskBGQl Nh2AGiMpcXDFDZYJjBKzkGyehWTzLCSbZyHZsICRZRWjaGpBckFxUnqRiV5xYm5xaV66XnJ+ 7iZGSCqZsIPx3gHrQ4zJQOsnMkuJJucDU1FeSbyhsZmRhamJqbGRuaUZacJK4rxqj5KChATS E0tSs1NTC1KL4otKc1KLDzEycXBKNTBK583o73nEy85/bsLuC1lXrr3aa90w+2vd89Y/WxLe 21XmL2b9sXK9X47AjnOrvdwvv0uaWnw9UCL08dOplQaH7nm6H9kR/u6wYZPecqWDakkz1Vwi Sx8G/26al/H1YN1x/odMdjGPz+wWOCG333pPb8i7yfu/xUYlPv8nY628YdGnLHm9uo0vlViK MxINtZiLihMBRr056TsDAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFmpjk+LIzCtJLcpLzFFi42I5/e+xoG5+ZUuwwZQZNhaP1yxmslj5/i+j xd9Jx9gt5n2WtWiau4fRYv6Rc6wWB/7sYLTYfe8Lo8Wav0oWmx5fY7WYcX4fk8Wb3y/YLZZe v8hk8enZP3aL1r1H2C3Wz3jNYtGxjNHi5ccTLA5CHmvmrWH0+P1rEqPH7IaLLB47Z91l99i0 qpPN4861PWwem5fUe/RtWcXo8XmTXABnVAOjTUZqYkpqkUJqXnJ+SmZeuq2Sd3C8c7ypmYGh rqGlhbmSQl5ibqqtkotPgK5bZg7QO0oKZYk5pUChgMTiYiV9O0wTQkPcdC1gGiN0fUOC4HqM DNBAwjrGjB8vtrIX/OapeHy3k6mBcQ9XFyMnh4SAicS255NZIWwxiQv31rN1MXJxCAlMZ5TY cfkVE0hCSOAvo0TrTkkQm01AQ+Lw+2fsILaIgL/E4f+/mEEamAWWMEucnNEF1b2EUWJO+2Ww bk4BfYn+24uBbA4OYQFXiTONeSBhFgFViZndb5hBwrwClhKHJzmAhHkFBCV+TL7HAmIzC2hJ rN95nAnClpfYvOYtM8ShChI7zr5mhLjBSeL7nausEDUiEvtevGOcwCg0C8moWUhGzUIyahaS lgWMLKsYRVMLkguKk9JzjfSKE3OLS/PS9ZLzczcxglPVM+kdjKsaLA4xCnAwKvHwTvBtDhZi TSwrrsw9xCjBwawkwru+pCVYiDclsbIqtSg/vqg0J7X4EGMy0KMTmaVEk/OBaTSvJN7Q2MTM yNLIzMLIxNycNGElcd6DrdaBQgLpiSWp2ampBalFMFuYODilGhh13hRpd9zM5+tee2F/6Qyf vYtUv89+9f/H35+WTTLl31z7dtW4XVGUcPSL4Dm59sXlWXskI5W9Us+Y1IjOuXmgq+1jsUjj eqv5b0+wZT5saNs5VfXNAgbhO6UuZntPMqzPX1qVcGtu0q9k45bjtiV+c9x4t7Pvkuy67GzE kWy/RVy++KHM8cVKLMUZiYZazEXFiQBWlfshmQMAAA== DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20140527_043953_800367_12C41EA7 X-CRM114-Status: GOOD ( 12.25 ) X-Spam-Score: -5.7 (-----) Cc: nicolas.pitre@linaro.org, mark.rutland@arm.com, kesavan.abhilash@gmail.com, lorenzo.pieralisi@arm.com, devicetree@vger.kernel.org, abrestic@chromium.org, t.figa@samsung.com, daniel.lezcano@linaro.org, will.deacon@arm.com, robh+dt@kernel.org, linux-samsung-soc@vger.kernel.org, thomas.ab@samsung.com, grant.likely@linaro.org, Dave.Martin@arm.com, linux-arm-kernel@lists.infradead.org, inderpal.s@samsung.com X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Spam-Status: No, score=-2.5 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Arnd Bergmann wrote: > > On Monday 05 May 2014, Abhilash Kesavan wrote: > > +static const struct mcpm_platform_ops exynos_power_ops = { > > + .power_up = exynos_power_up, > > + .power_down = exynos_power_down, > > + .power_down_finish = exynos_power_down_finish, > > +}; > > > I'm getting a build error in linux-next because there is > no .power_down_finish > member in mcpm_platform_ops here. > Yeah, commit 166aaf39 ("ARM: 8029/1: mcpm: Rename the power_down_finish() functions to be less confusing") changed the name to wait_for_cpu_powerdown... So need to change it accordingly... unsigned int cpunr = cpu + (cluster * EXYNOS5420_CPUS_PER_CLUSTER); @@ -261,7 +261,7 @@ static int exynos_power_down_finish(unsigned int cpu, unsigned int cluster) static const struct mcpm_platform_ops exynos_power_ops = { .power_up = exynos_power_up, .power_down = exynos_power_down, - .power_down_finish = exynos_power_down_finish, + .wait_for_powerdown = exynos_wait_for_powerdown, }; static void __init exynos_mcpm_usage_count_init(void) Thanks, Kukjin diff --git a/arch/arm/mach-exynos/mcpm-exynos.c b/arch/arm/mach-exynos/mcpm-exynos.c index 1ac618c..34c4e6f 100644 --- a/arch/arm/mach-exynos/mcpm-exynos.c +++ b/arch/arm/mach-exynos/mcpm-exynos.c @@ -235,7 +235,7 @@ static void exynos_power_down(void) /* Not dead at this point? Let our caller cope. */ } -static int exynos_power_down_finish(unsigned int cpu, unsigned int cluster) +static int exynos_wait_for_powerdown(unsigned int cpu, unsigned int cluster) { unsigned int tries = 100;