From patchwork Mon Mar 4 21:28:40 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 13581287 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id F06C8C54E49 for ; Mon, 4 Mar 2024 21:29:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=OikYwIIY79dStkvpWjSJyT47HpRAXCoRjWN3fB5YQuo=; b=H/QVXBnIrmEBMF h0xwk9nuP7kY05WIwZRQ6BM0+YkOyTepzXprSrvx4NCz7SWXQhbAOp4Y4+tBAL8ZK5eqhL43jwbFA 5dWMRurMYGv4OrbVzWwHiKU/g3fSel6ZIM3sQj82T0zIloD/+/dy4Azx8jpBTL4re3q3eb5iKIcWZ l1ClOY2He7qlqLtSbAuj34j0eB+kigOowAV86Z5SMxOHS20b1L04w5eIxQHdDrB6BYtQM41s8KrKb LVUsnU18IgjXLYQEbZSBg9ZHzie7eefGqH+IuJCNCdoDpYFcrfxPXMjuQd6ibmwtALQ7b03XiIeEh cq7Z+WiJPweic2rW9MzA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rhFru-0000000Alv7-1dGQ; Mon, 04 Mar 2024 21:29:07 +0000 Received: from metis.whiteo.stw.pengutronix.de ([2a0a:edc0:2:b01:1d::104]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rhFrr-0000000Altn-0qD9 for linux-arm-kernel@lists.infradead.org; Mon, 04 Mar 2024 21:29:04 +0000 Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rhFrl-0002hc-4Q; Mon, 04 Mar 2024 22:28:57 +0100 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1rhFrk-004QhP-8m; Mon, 04 Mar 2024 22:28:56 +0100 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.96) (envelope-from ) id 1rhFrk-00H4uJ-0a; Mon, 04 Mar 2024 22:28:56 +0100 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: Chanwoo Choi , MyungJoo Ham , Kyungmin Park Cc: Krzysztof Kozlowski , Alim Akhtar , linux-pm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, kernel@pengutronix.de Subject: [PATCH 2/5] PM / devfreq: exynos-ppmu: Convert to platform remove callback returning void Date: Mon, 4 Mar 2024 22:28:40 +0100 Message-ID: <028822439693e7d6a74f33385a3f634bdd7143dd.1709587301.git.u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.43.0 In-Reply-To: References: MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1679; i=u.kleine-koenig@pengutronix.de; h=from:subject:message-id; bh=WkAMU1jS5gkMcXbruT0u3SkkBeEdVbI821m1pxNR9Wc=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBl5j0Jb0TQlki/z6X9KXH7N4rgac6Lp9lbuNz7h gP4vNA6OdGJATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCZeY9CQAKCRCPgPtYfRL+ TqTrB/wIv8LL0R1fUF2/7b5G90138vYJMxUul0GE2smFvfiKra8cp1Xn8D02oQ7FM5eUOH4Ie09 reB94nWjr04NeYD0rFQqYOzhA9Fdawt5QTumuVVW1US2C35npQziC6GN18RLKRjJPJJfRblmJtE ucMb26BdgJrTguBbD+PwzEt8ZmVLZkIZlJ5S8xn2Dyb4eJadbp2bxxoWW4jQwI/AOWxYl5GR+/4 PO1jJ7U4lySywt/EhhGDrtAf163QHJtM07Vgd95zOoqy+ecFdzqxSyR+BJgzWvZOITTjCgP0Hrr hjCwK0Crq06txUdyHo4eRIbROwoJDCidajzEf3I4sQnahtwo X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-arm-kernel@lists.infradead.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240304_132903_259947_CB299727 X-CRM114-Status: GOOD ( 18.04 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is ignored (apart from emitting a warning) and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new(), which already returns void. Eventually after all drivers are converted, .remove_new() will be renamed to .remove(). Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König --- drivers/devfreq/event/exynos-ppmu.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/devfreq/event/exynos-ppmu.c b/drivers/devfreq/event/exynos-ppmu.c index 56bac4702006..7002df20a49e 100644 --- a/drivers/devfreq/event/exynos-ppmu.c +++ b/drivers/devfreq/event/exynos-ppmu.c @@ -692,18 +692,16 @@ static int exynos_ppmu_probe(struct platform_device *pdev) return 0; } -static int exynos_ppmu_remove(struct platform_device *pdev) +static void exynos_ppmu_remove(struct platform_device *pdev) { struct exynos_ppmu *info = platform_get_drvdata(pdev); clk_disable_unprepare(info->ppmu.clk); - - return 0; } static struct platform_driver exynos_ppmu_driver = { .probe = exynos_ppmu_probe, - .remove = exynos_ppmu_remove, + .remove_new = exynos_ppmu_remove, .driver = { .name = "exynos-ppmu", .of_match_table = exynos_ppmu_id_match,