From patchwork Tue Jul 16 07:34:23 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kim Kukjin X-Patchwork-Id: 2827982 Return-Path: X-Original-To: patchwork-linux-arm@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 2E17A9F9CA for ; Tue, 16 Jul 2013 07:34:56 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 406282011F for ; Tue, 16 Jul 2013 07:34:55 +0000 (UTC) Received: from casper.infradead.org (casper.infradead.org [85.118.1.10]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3638020114 for ; Tue, 16 Jul 2013 07:34:54 +0000 (UTC) Received: from merlin.infradead.org ([2001:4978:20e::2]) by casper.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1Uyzmd-0004PB-7B; Tue, 16 Jul 2013 07:34:51 +0000 Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1Uyzmb-0003Mx-1Q; Tue, 16 Jul 2013 07:34:49 +0000 Received: from mailout2.samsung.com ([203.254.224.25]) by merlin.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1UyzmW-0003MO-VP for linux-arm-kernel@lists.infradead.org; Tue, 16 Jul 2013 07:34:46 +0000 Received: from epcpsbgr4.samsung.com (u144.gpu120.samsung.co.kr [203.254.230.144]) by mailout2.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0MQ000FKQQDBA6C0@mailout2.samsung.com> for linux-arm-kernel@lists.infradead.org; Tue, 16 Jul 2013 16:34:23 +0900 (KST) Received: from epcpsbgm1.samsung.com ( [203.254.230.50]) by epcpsbgr4.samsung.com (EPCPMTA) with SMTP id 87.55.29708.F77F4E15; Tue, 16 Jul 2013 16:34:23 +0900 (KST) X-AuditID: cbfee690-b7f6f6d00000740c-9c-51e4f77f3bbc Received: from epmmp2 ( [203.254.227.17]) by epcpsbgm1.samsung.com (EPCPMTA) with SMTP id A0.B8.03947.F77F4E15; Tue, 16 Jul 2013 16:34:23 +0900 (KST) Received: from DOKGENEKIM03 ([12.23.120.199]) by mmp2.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTPA id <0MQ000E1HQDBP320@mmp2.samsung.com>; Tue, 16 Jul 2013 16:34:23 +0900 (KST) From: Kukjin Kim To: 'Sachin Kamat' , linux-arm-kernel@lists.infradead.org References: <1373533334-5169-1-git-send-email-sachin.kamat@linaro.org> <1373533334-5169-2-git-send-email-sachin.kamat@linaro.org> In-reply-to: <1373533334-5169-2-git-send-email-sachin.kamat@linaro.org> Subject: RE: [PATCH 1/6] clk: exynos4: Staticize local symbols Date: Tue, 16 Jul 2013 16:34:23 +0900 Message-id: <02d801ce81f6$e480fe80$ad82fb80$%kim@samsung.com> MIME-version: 1.0 X-Mailer: Microsoft Office Outlook 12.0 Thread-index: Ac5+F5F0IOJRA+AIQfy/QsE9OIxF2wD3wGbg Content-language: ko X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrLIsWRmVeSWpSXmKPExsVy+t8zI936708CDR50GlhsenyN1WLG+X1M Fk8nXGSzmHL4C4vFyT+9jA6sHneu7WHz2Lyk3uPzJrkA5igum5TUnMyy1CJ9uwSujAfz1jEX vOWv2PVtL3MDYxNvFyMnh4SAiUTr5ElMELaYxIV769m6GLk4hASWMUocWNLKAlO0cu1KqMR0 RomeiX1Qzl9GicbTi8Da2QQ0JA6/f8YOYosIhEgcX7oMLM4sECAxd+EEZoiGZkaJZ9PeMIIk OAXcJfZd+w62QljATuLxwW3MIDaLgKrErQfzweK8ArYS6w9tZYWwBSV+TL7HAjFUS2L9zuNQ C+QlNq95C9TLAXSqusSjv7ogpoiAkcTlPheIChGJfS/eMYKcICFwil3i0ZOdTBCrBCS+TT7E AtEqK7HpADPEw5ISB1fcYJnAKDELyeJZSBbPQrJ4FpIVCxhZVjGKphYkFxQnpReZ6BUn5haX 5qXrJefnbmKEROWEHYz3DlgfYkwGWj+RWUo0OR8Y1Xkl8YbGZkYWpiamxkbmlmakCSuJ86q3 WAcKCaQnlqRmp6YWpBbFF5XmpBYfYmTi4JRqYNR7/FQrJj7C1uun3w623KOn94vzC/esSbrG ITk9xdIo3eP51yIRd5PO2MyVjAXrpYyF+21z7Dubeb8y77NNlixfsst3loVimJvK8j99Bccd Q584FX94OdVReH+MluTWPtlbt0QCp694ZzpF1LKnJybC6OXP47ahfO/eTopZdGvichv2xh5W JZbijERDLeai4kQAe/8iIeACAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrFKsWRmVeSWpSXmKPExsVy+t9jQd36708CDX781rbY9Pgaq8WM8/uY LJ5OuMhmMeXwFxaLk396GR1YPe5c28PmsXlJvcfnTXIBzFENjDYZqYkpqUUKqXnJ+SmZeem2 St7B8c7xpmYGhrqGlhbmSgp5ibmptkouPgG6bpk5QCuVFMoSc0qBQgGJxcVK+naYJoSGuOla wDRG6PqGBMH1GBmggYR1jBkP5q1jLnjLX7Hr217mBsYm3i5GTg4JAROJlWtXskHYYhIX7q0H srk4hASmM0r0TOyDcv4ySjSeXsQEUsUmoCFx+P0zdhBbRCBE4vjSZWBxZoEAibkLJzBDNDQz Sjyb9oYRJMEp4C6x79p3FhBbWMBO4vHBbcwgNouAqsStB/PB4rwCthLrD21lhbAFJX5MvscC MVRLYv3O41AL5CU2r3kL1MsBdKq6xKO/uiCmiICRxOU+F4gKEYl9L94xTmAUmoVk0Cwkg2Yh GTQLScsCRpZVjKKpBckFxUnpuYZ6xYm5xaV56XrJ+bmbGMEx/0xqB+PKBotDjAIcjEo8vBI8 TwKFWBPLiitzDzFKcDArifAmbgIK8aYkVlalFuXHF5XmpBYfYkwG+nMis5Rocj4wHeWVxBsa m5gZWRqZWRiZmJuTJqwkznug1TpQSCA9sSQ1OzW1ILUIZgsTB6dUA2P7+m0vHG2FvcMPu2zJ zEhnv2a9YpLnUelmAdePHyZMkO7zfff+5z0RT8E94jNnWiiJiB0y2iCbGOH04pIxn97FWdfe 6D5Piw35w52gKh8SvUTT9fWtiTaO02qK1rrOuFBodnWbpiGzxpIfq6M6XLb67btiYyh7dv3D F6zBERpr/4Y+ZNJ98FqJpTgj0VCLuag4EQAxQjusPQMAAA== DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20130716_033445_232428_1AECBF8E X-CRM114-Status: GOOD ( 12.40 ) X-Spam-Score: -7.3 (-------) Cc: linux-samsung-soc@vger.kernel.org, mturquette@linaro.org, patches@linaro.org X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Spam-Status: No, score=-4.6 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_MED, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Sachin Kamat wrote: > > Symbols referenced only in this file are made static. > > Signed-off-by: Sachin Kamat > --- > drivers/clk/samsung/clk-exynos4.c | 30 ++++++++++++++++-------------- > 1 file changed, 16 insertions(+), 14 deletions(-) > > diff --git a/drivers/clk/samsung/clk-exynos4.c b/drivers/clk/samsung/clk- > exynos4.c > index 1bdb882..18eadc4 100644 > --- a/drivers/clk/samsung/clk-exynos4.c > +++ b/drivers/clk/samsung/clk-exynos4.c [...] > @@ -975,7 +975,7 @@ static void __init > exynos4_clk_register_finpll(unsigned long xom) > * clock speed. > */ > void __init exynos4_clk_register_fixed_ext(unsigned long xxti_f, > - unsigned long xusbxti_f) > + unsigned long xusbxti_f) Why? > { > exynos4_fixed_rate_ext_clks[0].fixed_rate = xxti_f; > exynos4_fixed_rate_ext_clks[1].fixed_rate = xusbxti_f; > @@ -990,7 +990,9 @@ static __initdata struct of_device_id ext_clk_match[] > = { > }; > > /* register exynos4 clocks */ > -void __init exynos4_clk_init(struct device_node *np, enum exynos4_soc > exynos4_soc, void __iomem *reg_base, unsigned long xom) > +static void __init exynos4_clk_init(struct device_node *np, > + enum exynos4_soc exynos4_soc, > + void __iomem *reg_base, unsigned long xom) > { > struct clk *apll, *mpll, *epll, *vpll; > > -- > 1.7.9.5 And don't we need following? void exynos_firmware_init(void); - Kukjin diff --git a/arch/arm/mach-exynos/common.h b/arch/arm/mach-exynos/common.h index 3e156bc..3a34f1e 100644 --- a/arch/arm/mach-exynos/common.h +++ b/arch/arm/mach-exynos/common.h @@ -26,7 +26,6 @@ void exynos5_restart(enum reboot_mode mode, const char *cmd); void exynos_init_late(void); /* ToDo: remove these after migrating legacy exynos4 platforms to dt */ -void exynos4_clk_init(struct device_node *np, int is_exynos4210, void __iomem *reg_base, unsigned long xom); void exynos4_clk_register_fixed_ext(unsigned long, unsigned long);