| Message ID | 03627216-54b5-5d9b-f91d-adcd637819e3@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [v2,1/8] dt-bindings: gpio: rockchip,gpio-bank: add compatible string per SoC | expand |
On 21/01/2023 12:06, Johan Jonker wrote: > Currently all Rockchip gpio nodes have the same compatible. > Compatible strings should be SoC related. > > Signed-off-by: Johan Jonker <jbx6244@gmail.com> > --- > .../bindings/gpio/rockchip,gpio-bank.yaml | 26 ++++++++++++++++--- > 1 file changed, 22 insertions(+), 4 deletions(-) > > diff --git a/Documentation/devicetree/bindings/gpio/rockchip,gpio-bank.yaml b/Documentation/devicetree/bindings/gpio/rockchip,gpio-bank.yaml > index affd823c8..a604c3638 100644 > --- a/Documentation/devicetree/bindings/gpio/rockchip,gpio-bank.yaml > +++ b/Documentation/devicetree/bindings/gpio/rockchip,gpio-bank.yaml > @@ -11,9 +11,27 @@ maintainers: > > properties: > compatible: > - enum: > - - rockchip,gpio-bank > - - rockchip,rk3188-gpio-bank0 > + oneOf: > + - const: rockchip,gpio-bank > + - const: rockchip,rk3188-gpio-bank0 That's an enum so keep them like that > + - items: Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Best regards, Krzysztof
On Sat, Jan 21, 2023 at 12:06 PM Johan Jonker <jbx6244@gmail.com> wrote: > Currently all Rockchip gpio nodes have the same compatible. > Compatible strings should be SoC related. > > Signed-off-by: Johan Jonker <jbx6244@gmail.com> Reviewed-by: Linus Walleij <linus.walleij@linaro.org> Yours, Linus Walleij
On Sat, Jan 21, 2023 at 12:06 PM Johan Jonker <jbx6244@gmail.com> wrote: > Currently all Rockchip gpio nodes have the same compatible. > Compatible strings should be SoC related. > > Signed-off-by: Johan Jonker <jbx6244@gmail.com> Bartosz can you merge this one patch and keep the rest back so we get a more defined DT binding baseline? Yours, Linus Walleij
On Wed, Feb 8, 2023 at 12:08 PM Linus Walleij <linus.walleij@linaro.org> wrote: > > On Sat, Jan 21, 2023 at 12:06 PM Johan Jonker <jbx6244@gmail.com> wrote: > > > Currently all Rockchip gpio nodes have the same compatible. > > Compatible strings should be SoC related. > > > > Signed-off-by: Johan Jonker <jbx6244@gmail.com> > > Bartosz can you merge this one patch and keep the rest back > so we get a more defined DT binding baseline? > > Yours, > Linus Walleij Krzysztof, you left your ack but seem to also have pointed out an issue - do you want me to fix it up somehow before applying? Drop the oneOf and turn it back into an enum? Bart
On 10/02/2023 21:03, Bartosz Golaszewski wrote: > On Wed, Feb 8, 2023 at 12:08 PM Linus Walleij <linus.walleij@linaro.org> wrote: >> >> On Sat, Jan 21, 2023 at 12:06 PM Johan Jonker <jbx6244@gmail.com> wrote: >> >>> Currently all Rockchip gpio nodes have the same compatible. >>> Compatible strings should be SoC related. >>> >>> Signed-off-by: Johan Jonker <jbx6244@gmail.com> >> >> Bartosz can you merge this one patch and keep the rest back >> so we get a more defined DT binding baseline? >> >> Yours, >> Linus Walleij > > Krzysztof, you left your ack but seem to also have pointed out an > issue - do you want me to fix it up somehow before applying? Drop the > oneOf and turn it back into an enum? Sure, you can apply with my comment fixed but then just please check with `make dt_binding_check DT_SCHEMA_FILES="xxx.yaml"`, that indentation is not mixed up. Best regards, Krzysztof
On Sun, Feb 12, 2023 at 5:14 PM Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> wrote: > > On 10/02/2023 21:03, Bartosz Golaszewski wrote: > > On Wed, Feb 8, 2023 at 12:08 PM Linus Walleij <linus.walleij@linaro.org> wrote: > >> > >> On Sat, Jan 21, 2023 at 12:06 PM Johan Jonker <jbx6244@gmail.com> wrote: > >> > >>> Currently all Rockchip gpio nodes have the same compatible. > >>> Compatible strings should be SoC related. > >>> > >>> Signed-off-by: Johan Jonker <jbx6244@gmail.com> > >> > >> Bartosz can you merge this one patch and keep the rest back > >> so we get a more defined DT binding baseline? > >> > >> Yours, > >> Linus Walleij > > > > Krzysztof, you left your ack but seem to also have pointed out an > > issue - do you want me to fix it up somehow before applying? Drop the > > oneOf and turn it back into an enum? > > > Sure, you can apply with my comment fixed but then just please check > with `make dt_binding_check DT_SCHEMA_FILES="xxx.yaml"`, that > indentation is not mixed up. > > Best regards, > Krzysztof > I prefer to get your ack on the final version really. Johan, please address the enum issue and resend just this patch. Bart
On 2/15/23 16:02, Bartosz Golaszewski wrote: > On Sun, Feb 12, 2023 at 5:14 PM Krzysztof Kozlowski > <krzysztof.kozlowski@linaro.org> wrote: >> >> On 10/02/2023 21:03, Bartosz Golaszewski wrote: >>> On Wed, Feb 8, 2023 at 12:08 PM Linus Walleij <linus.walleij@linaro.org> wrote: >>>> >>>> On Sat, Jan 21, 2023 at 12:06 PM Johan Jonker <jbx6244@gmail.com> wrote: >>>> >>>>> Currently all Rockchip gpio nodes have the same compatible. >>>>> Compatible strings should be SoC related. >>>>> >>>>> Signed-off-by: Johan Jonker <jbx6244@gmail.com> >>>> >>>> Bartosz can you merge this one patch and keep the rest back >>>> so we get a more defined DT binding baseline? >>>> >>>> Yours, >>>> Linus Walleij >>> >>> Krzysztof, you left your ack but seem to also have pointed out an >>> issue - do you want me to fix it up somehow before applying? Drop the >>> oneOf and turn it back into an enum? >> >> >> Sure, you can apply with my comment fixed but then just please check >> with `make dt_binding_check DT_SCHEMA_FILES="xxx.yaml"`, that >> indentation is not mixed up. >> >> Best regards, >> Krzysztof >> > > I prefer to get your ack on the final version really. > > Johan, please address the enum issue and resend just this patch. I changed to oneOf, because with enum I didn't get it working. With 2 enum's it complains about: is not of type 'string'. I'm out of ideas... Maybe it's something simple that I overlook. Could Krzysztof give an example? Johan > > Bart
On 15/02/2023 17:14, Johan Jonker wrote: > >> Johan, please address the enum issue and resend just this patch. > > I changed to oneOf, because with enum I didn't get it working. > With 2 enum's it complains about: is not of type 'string'. > I'm out of ideas... > Maybe it's something simple that I overlook. > Could Krzysztof give an example? Documentation/devicetree/bindings/arm/l2c2x0.yaml It should look like this, if my email did not mess up indents: + oneOf: + - enum: + - rockchip,gpio-bank + - rockchip,rk3188-gpio-bank0 + - items: + - enum: Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/gpio/rockchip,gpio-bank.yaml b/Documentation/devicetree/bindings/gpio/rockchip,gpio-bank.yaml index affd823c8..a604c3638 100644 --- a/Documentation/devicetree/bindings/gpio/rockchip,gpio-bank.yaml +++ b/Documentation/devicetree/bindings/gpio/rockchip,gpio-bank.yaml @@ -11,9 +11,27 @@ maintainers: properties: compatible: - enum: - - rockchip,gpio-bank - - rockchip,rk3188-gpio-bank0 + oneOf: + - const: rockchip,gpio-bank + - const: rockchip,rk3188-gpio-bank0 + - items: + - enum: + - rockchip,px30-gpio-bank + - rockchip,rk3036-gpio-bank + - rockchip,rk3066a-gpio-bank + - rockchip,rk3128-gpio-bank + - rockchip,rk3188-gpio-bank + - rockchip,rk3228-gpio-bank + - rockchip,rk3288-gpio-bank + - rockchip,rk3328-gpio-bank + - rockchip,rk3308-gpio-bank + - rockchip,rk3368-gpio-bank + - rockchip,rk3399-gpio-bank + - rockchip,rk3568-gpio-bank + - rockchip,rk3588-gpio-bank + - rockchip,rv1108-gpio-bank + - rockchip,rv1126-gpio-bank + - const: rockchip,gpio-bank reg: maxItems: 1 @@ -75,7 +93,7 @@ examples: }; gpio1: gpio@2003c000 { - compatible = "rockchip,gpio-bank"; + compatible = "rockchip,rk3188-gpio-bank", "rockchip,gpio-bank"; reg = <0x2003c000 0x100>; interrupts = <GIC_SPI 55 IRQ_TYPE_LEVEL_HIGH>; clocks = <&clk_gates8 10>;
Currently all Rockchip gpio nodes have the same compatible. Compatible strings should be SoC related. Signed-off-by: Johan Jonker <jbx6244@gmail.com> --- .../bindings/gpio/rockchip,gpio-bank.yaml | 26 ++++++++++++++++--- 1 file changed, 22 insertions(+), 4 deletions(-) -- 2.20.1