From patchwork Thu Dec 30 11:31:27 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Gaston Gonzalez X-Patchwork-Id: 12701398 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C1498C433F5 for ; Thu, 30 Dec 2021 11:34:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=oWEukMSqOKR5K30A1WSbajYOUZgPMZYQxjC8NLdsIgM=; b=0WyspIKrwfePyP rsBs5/9Sdnr6Uu4B2tQMlKL7Xic+QSba/7AcGr92eUHYkJCa+SMKKbuuJqcH2GPvUoyYR20rMPD+v gxy7159xU7JlncdbsxfPeIts0WwC7DgIbHONvt43aRpri0DaAbE6VH+PyPTqaXscyask3NjjqOxct qjRnGwo+NvOvsBummwoUol4nKpGqeKj++jXPnVquyFcdKb3/gCOUlhj7mFtRdO/zeCKENRijY3brZ Ddm0UjsPRD/Do9yqahHOdKfw0vdfVEg2SCbZUxSFGrOCGjPtXWn/bZMquIXaD0E+Q5fWiBG4GnxzJ oAyNNS5a7LOlTjhUj69w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1n2tg4-004I90-9r; Thu, 30 Dec 2021 11:33:00 +0000 Received: from mail-qt1-x82b.google.com ([2607:f8b0:4864:20::82b]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1n2tg0-004I7B-8j; Thu, 30 Dec 2021 11:32:57 +0000 Received: by mail-qt1-x82b.google.com with SMTP id m25so21370302qtq.13; Thu, 30 Dec 2021 03:32:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=a+3drHr85ha2baZful+nRJ7uBfrZaAbysA+5tvBlqBY=; b=qPtzEAgNBKbi3F8mzlujZv/gYnhOvqhIviEvIuYvKHcBnL1trShVtjmds0pGd2hf79 liFxw3cM75vsuO4svQ2s3GgC7/2uBAes/Vcvy+/v8DC0tRhnv+4xSLcrxzptF2nmQkI8 YV9aKyqADMLP1qpBgZStSDBs6fCLTe3qX08bvjMP+knZB3h1CIQ3XM7r/kBTqitdFn87 Bw5NxzIQ2d6iDtHxBo5vVLZ0FF0dRuNApfGF2BlgH7O2YTETm2Y2eym5o3L7kZ9Gh3M9 9rX2Jul5hJPmEiL37bWzrNIHOoIZFNdPajiUyeB0m96hmwVAT+udeMoeycCHtEzLGuwd LolQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=a+3drHr85ha2baZful+nRJ7uBfrZaAbysA+5tvBlqBY=; b=qk1ud6rxdkKdc9mMqTWE7GMiarFc0v2d90FklnlBIkjvY9kNzNYxUtSrWs6nKQgEoN /pQr6UacJljVCvjk16+p8arMONxKkyHJBdRU2MdrCyMYLYfCFc7S43+XDhPHTtsNpnU4 AMCZIqAxCeskVNbdjQJQ1lfzcbCJ01rPu4l4FceCQQDB8vnL1Ad6oIbkq8o6/fYK3Avr kotYqK36ya30vpIsh9kFAzKl4XGExqLt9uNB/aCXHM/OayTK5GGi+6UJ5shl048l1Ma/ PsUf8ofY10xz6Oyazq4YShFy+Fs6Yh5U+ToJXGzE8Y191ZigLcVLnJ92oYIqDQmoUGb/ Xubw== X-Gm-Message-State: AOAM533f1Xhp6l4lcQyIbrdHttwO/87ovZGc6xSBVdO336jBid4QWBL/ OHrlTmvWQyzcxnKoqV5/ppQ= X-Google-Smtp-Source: ABdhPJycnyd4H24DA5r2pASiGfeQVL5PDTMuBWNjmfl03v0nt+qlhV0ox7sLYQwz0sd6ruO2U1lfQQ== X-Received: by 2002:a05:622a:144:: with SMTP id v4mr25727272qtw.191.1640863975231; Thu, 30 Dec 2021 03:32:55 -0800 (PST) Received: from localhost.localdomain ([181.23.70.139]) by smtp.gmail.com with ESMTPSA id v5sm20348559qkp.126.2021.12.30.03.32.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 30 Dec 2021 03:32:54 -0800 (PST) From: Gaston Gonzalez To: linux-staging@lists.linux.dev Cc: gregkh@linuxfoundation.org, nsaenz@kernel.org, f.fainelli@gmail.com, rjui@broadcom.com, sbranden@broadcom.com, bcm-kernel-feedback-list@broadcom.com, juerg.haefliger@canonical.com, rdunlap@infradead.org, dave.stevenson@raspberrypi.com, stefan.wahren@i2se.com, unixbhaskar@gmail.com, mitaliborkar810@gmail.com, phil@raspberrypi.com, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, gascoar@gmail.com Subject: [PATCH v2 2/3] staging: vc04_services: bcm2835-camera: avoid the use of typedef for function pointers Date: Thu, 30 Dec 2021 08:31:27 -0300 Message-Id: <0418e6e19e1580fff4abfc4bb2f4269dc206df44.1640776340.git.gascoar@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: References: MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211230_033256_320567_18D29751 X-CRM114-Status: GOOD ( 11.23 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Replace typedef bm2835_mmal_v4l2_ctrl_cb with equivalent declaration to better align with the linux kernel coding style. Signed-off-by: Gaston Gonzalez --- .../staging/vc04_services/bcm2835-camera/controls.c | 10 ++-------- 1 file changed, 2 insertions(+), 8 deletions(-) diff --git a/drivers/staging/vc04_services/bcm2835-camera/controls.c b/drivers/staging/vc04_services/bcm2835-camera/controls.c index b096a12387f7..3696dfb5a020 100644 --- a/drivers/staging/vc04_services/bcm2835-camera/controls.c +++ b/drivers/staging/vc04_services/bcm2835-camera/controls.c @@ -65,13 +65,6 @@ enum bm2835_mmal_ctrl_type { MMAL_CONTROL_TYPE_CLUSTER, /* special cluster entry */ }; -struct bm2835_mmal_v4l2_ctrl; - -typedef int(bm2835_mmal_v4l2_ctrl_cb)( - struct bm2835_mmal_dev *dev, - struct v4l2_ctrl *ctrl, - const struct bm2835_mmal_v4l2_ctrl *mmal_ctrl); - struct bm2835_mmal_v4l2_ctrl { u32 id; /* v4l2 control identifier */ enum bm2835_mmal_ctrl_type type; @@ -84,7 +77,8 @@ struct bm2835_mmal_v4l2_ctrl { u64 step; /* step size of the control */ const s64 *imenu; /* integer menu array */ u32 mmal_id; /* mmal parameter id */ - bm2835_mmal_v4l2_ctrl_cb *setter; + int (*setter)(struct bm2835_mmal_dev *dev, struct v4l2_ctrl *ctrl, + const struct bm2835_mmal_v4l2_ctrl *mmal_ctrl); }; struct v4l2_to_mmal_effects_setting {