From patchwork Fri Nov 9 10:08:47 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kim Kukjin X-Patchwork-Id: 1719841 Return-Path: X-Original-To: patchwork-linux-arm@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork1.kernel.org Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) by patchwork1.kernel.org (Postfix) with ESMTP id 968873FCF7 for ; Fri, 9 Nov 2012 10:10:58 +0000 (UTC) Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.76 #1 (Red Hat Linux)) id 1TWlWC-0005R9-GT; Fri, 09 Nov 2012 10:08:56 +0000 Received: from mailout1.samsung.com ([203.254.224.24]) by merlin.infradead.org with esmtp (Exim 4.76 #1 (Red Hat Linux)) id 1TWlW8-0005QR-Fw for linux-arm-kernel@lists.infradead.org; Fri, 09 Nov 2012 10:08:54 +0000 Received: from epcpsbgm2.samsung.com (epcpsbgm2 [203.254.230.27]) by mailout1.samsung.com (Oracle Communications Messaging Server 7u4-24.01(7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0MD700HIMTIMM310@mailout1.samsung.com> for linux-arm-kernel@lists.infradead.org; Fri, 09 Nov 2012 19:08:47 +0900 (KST) Received: from epcpsbgm2.samsung.com ( [203.254.230.49]) by epcpsbgm2.samsung.com (EPCPMTA) with SMTP id 73.42.12699.F26DC905; Fri, 09 Nov 2012 19:08:47 +0900 (KST) X-AuditID: cbfee61b-b7f616d00000319b-9f-509cd62fc00f Received: from epmmp2 ( [203.254.227.17]) by epcpsbgm2.samsung.com (EPCPMTA) with SMTP id 23.42.12699.F26DC905; Fri, 09 Nov 2012 19:08:47 +0900 (KST) Received: from DOKGENEKIM03 ([12.23.120.199]) by mmp2.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTPA id <0MD7000METIN6U40@mmp2.samsung.com> for linux-arm-kernel@lists.infradead.org; Fri, 09 Nov 2012 19:08:47 +0900 (KST) From: Kukjin Kim To: 'Andrey Gusakov' , 'Sylwester Nawrocki' References: <1352449929-20168-1-git-send-email-sylvester.nawrocki@gmail.com> In-reply-to: Subject: RE: [PATCH] ARM: S3C64XX: Statically define parent clock of the "camera" clock Date: Fri, 09 Nov 2012 19:08:47 +0900 Message-id: <0e8101cdbe62$3537bc50$9fa734f0$%kim@samsung.com> MIME-version: 1.0 X-Mailer: Microsoft Office Outlook 12.0 Thread-index: Ac2+XPf2WjdUaBHxSMmPNa5D23CC2gABOwVg Content-language: ko DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrKIsWRmVeSWpSXmKPExsVy+t8zQ139a3MCDHa3yFpsenyN1YHRY/OS +gDGKC6blNSczLLUIn27BK6MqX9eMBY8EK+Y+2wnawPjYcEuRk4OCQETiYOLzrFD2GISF+6t ZwOxhQSWMUpc/hsDU/NgTT9QnAsoPp1RYnHXP1YIZxmTxJMLi5lBqtgENCQOv38GNklEIEHi 8IROsDizgLfEnlubGCEa7jBKTHjxA2gUBwenQLDEw72ZIDXCApESq1oWsYDYLAKqEhdfzAbr 5RWwlfj6/AcbhC0o8WPyPRaImVoS63ceZ4Kw5SU2r3nLDDJSQkBd4tFfXYgTjCS+74A5QURi 34t3jBDjBSS+TT7EAlEuK7HpADPEj4vYJTovBELYkhIHV9xgmcAoMQvJ4llIFs9CsngWkg0L GFlWMYqmFiQXFCel5xrpFSfmFpfmpesl5+duYoTElfQOxlUNFocYBTgYlXh4Ex/MDhBiTSwr rsw9xCjBwawkwmt0dk6AEG9KYmVValF+fFFpTmrxIUYfoMMnMkuJJucDYz6vJN7Q2NjEzMTU xNzS1NwUh7CSOG+zR0qAkEB6YklqdmpqQWoRzDgmDk6pBsaM7y/LH6fNXvzFZJF6zwWGG2wX GE34Z213q22cmSPWef/TttVX/3y+7vKh7dUjdi+WmbqrxDrtjr5kNOALqEm83pfwpfc376mf eSlL638YRPYlbp2uesE+3fX6jKPh75fOvmK198Az97o7DA3ufXJJtwt6xD//u3/hyImtDLXu Scxff7tnscYosRRnJBpqMRcVJwIA9at+SdgCAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrGIsWRmVeSWpSXmKPExsVy+t9jQV39a3MCDFpOS1psenyN1YHRY/OS +gDGqAZGm4zUxJTUIoXUvOT8lMy8dFsl7+B453hTMwNDXUNLC3MlhbzE3FRbJRefAF23zByg qUoKZYk5pUChgMTiYiV9O0wTQkPcdC1gGiN0fUOC4HqMDNBAwjrGjKl/XjAWPBCvmPtsJ2sD 42HBLkZODgkBE4kHa/rZIGwxiQv31gPZXBxCAtMZJRZ3/WOFcJYxSTy5sJgZpIpNQEPi8Ptn 7CC2iECCxOEJnWBxZgFviT23NjFCNNxhlJjw4gfQKA4OToFgiYd7M0FqhAUiJVa1LGIBsVkE VCUuvpgN1ssrYCvx9fkPNghbUOLH5HssEDO1JNbvPM4EYctLbF7zlhlkpISAusSjv7oQJxhJ fN8Bc4KIxL4X7xgnMArNQjJpFpJJs5BMmoWkZQEjyypG0dSC5ILipPRcI73ixNzi0rx0veT8 3E2M4Mh9Jr2DcVWDxSFGAQ5GJR7exAezA4RYE8uKK3MPMUpwMCuJ8BqdnRMgxJuSWFmVWpQf X1Sak1p8iNEH6NGJzFKiyfnApJJXEm9obGJmZGlkZmFkYm6OQ1hJnLfZIyVASCA9sSQ1OzW1 ILUIZhwTB6dUA2NOXU+v/c65BxyrHmVOCX/Rw8gb9OGU4kfhB9/O2B5e6XTZQOn8XB/e7acO vPa5ePF8/714ndm79sz/PfVT6JfZnzfI/D0TFW722M3NlnePlB/Lr+tXjvguevf+YkSak2Z8 4kuVr6+YD/yz7zp1QmrdYgfRK/NtL/cU5Ps/SuD+mN6RLLwwfu1NJZbijERDLeai4kQAs8fA VwkDAAA= X-CFilter-Loop: Reflected X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20121109_050852_834261_07879982 X-CRM114-Status: GOOD ( 20.53 ) X-Spam-Score: -7.6 (-------) X-Spam-Report: SpamAssassin version 3.3.2 on merlin.infradead.org summary: Content analysis details: (-7.6 points) pts rule name description ---- ---------------------- -------------------------------------------------- -5.0 RCVD_IN_DNSWL_HI RBL: Sender listed at http://www.dnswl.org/, high trust [203.254.224.24 listed in list.dnswl.org] -0.0 SPF_HELO_PASS SPF: HELO matches SPF record -0.7 RP_MATCHES_RCVD Envelope sender domain matches handover relay domain -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] Cc: linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linux-arm-kernel-bounces@lists.infradead.org Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org Andrey Gusakov wrote: > > Hi. > > On Fri, Nov 9, 2012 at 12:32 PM, Sylwester Nawrocki > wrote: > > The "camera" clock defined in arch/arm/mach-s3c64xx/clock.c has null > > clock source mux control register as it can have only one parent > > clock. In such cases there is a need to configure the parent clock > > statically, otherwise s3c_set_clksrc() bails out with an error message > > "no parent clock specified" leaving the parent clock not configured. > > Define statically the parent clock so it is possible to get or set > > rate of the "camera" clock. > > While at it remove the unneded null reg_src definition. > > > > Reported-by: In-Bae Jeong > > Signed-off-by: Sylwester Nawrocki > > --- > > arch/arm/mach-s3c64xx/clock.c | 2 +- > > 1 files changed, 1 insertions(+), 1 deletions(-) > > > > diff --git a/arch/arm/mach-s3c64xx/clock.c b/arch/arm/mach- > s3c64xx/clock.c > > index 28041e8..2e6d7f9 100644 > > --- a/arch/arm/mach-s3c64xx/clock.c > > +++ b/arch/arm/mach-s3c64xx/clock.c > > @@ -744,9 +744,9 @@ static struct clksrc_clk clksrcs[] = { > > .name = "camera", > > .ctrlbit = S3C_CLKCON_SCLK_CAM, > > .enable = s3c64xx_sclk_ctrl, > > + .parent = &clk_h2, > > }, > > .reg_div = { .reg = S3C_CLK_DIV0, .shift = 20, .size = > 4 }, > > - .reg_src = { .reg = NULL, .shift = 0, .size = 0 }, > > .sources = &clkset_camif, > Just figure out that .sources can be removed to. And seems > "clkset_camif" and "clkset_camif_list" can be removed as unused. > Yeah, in this case, right. And we don't need source field as well because its source is fixed. See below. 8<---- 8<---- Thanks. Best regards, Kgene. --- Kukjin Kim , Senior Engineer, SW Solution Development Team, Samsung Electronics Co., Ltd. diff --git a/arch/arm/mach-s3c64xx/clock.c b/arch/arm/mach-s3c64xx/clock.c index 28041e8..e963711 100644 --- a/arch/arm/mach-s3c64xx/clock.c +++ b/arch/arm/mach-s3c64xx/clock.c @@ -681,15 +681,6 @@ static struct clksrc_sources clkset_audio2 = { .nr_sources = ARRAY_SIZE(clkset_audio2_list), }; -static struct clk *clkset_camif_list[] = { - &clk_h2, -}; - -static struct clksrc_sources clkset_camif = { - .sources = clkset_camif_list, - .nr_sources = ARRAY_SIZE(clkset_camif_list), -}; - static struct clksrc_clk clksrcs[] = { { .clk = { @@ -742,12 +733,11 @@ static struct clksrc_clk clksrcs[] = { }, { .clk = { .name = "camera", + .parent = &clk_h2, .ctrlbit = S3C_CLKCON_SCLK_CAM, .enable = s3c64xx_sclk_ctrl, }, .reg_div = { .reg = S3C_CLK_DIV0, .shift = 20, .size = 4 }, - .reg_src = { .reg = NULL, .shift = 0, .size = 0 }, - .sources = &clkset_camif, }, };