Message ID | 0f096d1ad277cf94032ca274ced0cb35cb5d967c.1455198819.git.larper@axis.com (mailing list archive) |
---|---|
State | New, archived |
Headers | show |
On Thursday 11 February 2016 15:04:37 Lars Persson wrote: > + > +The DMA configuration unit muxes dma request lines between single and burst > +alternatives. > + > +Required properties: > +- compatible: axis,artpec6-dmacfg > +- reg: Address and length of DMACFG register. > + > +Example: > + dmacfg { > + compatible = "axis,artpec6-dmacfg"; > + reg = <0xf8000010 4>; > + }; > + This method looks better than before, but putting a single register into DT looks wrong. I can almost guarantee that there are more registers at 0xf8000000-0xf8000fff (or more) that belong to either some system controller or a DMA controller. Whatever it is, please describe it in the DT in a sensible way based on what the hardware does and what other resources it uses (interrupts etc) rather than what today's kernel happens to need. Arnd
diff --git a/Documentation/devicetree/bindings/arm/axis.txt b/Documentation/devicetree/bindings/arm/axis.txt new file mode 100644 index 0000000..203a305 --- /dev/null +++ b/Documentation/devicetree/bindings/arm/axis.txt @@ -0,0 +1,29 @@ +Axis Communications AB +ARTPEC series SoC Device Tree Bindings + +ARTPEC-6 ARM SoC +================ + +Required root node properties: +- compatible = "axis,artpec6"; + +ARTPEC-6 DMA Configuration +-------------------------- + +The DMA configuration unit muxes dma request lines between single and burst +alternatives. + +Required properties: +- compatible: axis,artpec6-dmacfg +- reg: Address and length of DMACFG register. + +Example: + dmacfg { + compatible = "axis,artpec6-dmacfg"; + reg = <0xf8000010 4>; + }; + +ARTPEC-6 Development board: +--------------------------- +Required root node properties: +- compatible = "axis,artpec6-dev-board", "axis,artpec6";
This adds device tree bindings for the Artpec-6 SoC. Signed-off-by: Lars Persson <larper@axis.com> --- Documentation/devicetree/bindings/arm/axis.txt | 29 ++++++++++++++++++++++++++ 1 file changed, 29 insertions(+) create mode 100644 Documentation/devicetree/bindings/arm/axis.txt