| Message ID | 0f82c3f97cb798d012270d13b34d8d15305ef293.1711923520.git.dsimic@manjaro.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | arm64: dts: rockchip: Remove unsupported node from the Pinebook Pro dts | expand |
On Mon, 1 Apr 2024 00:20:56 +0200, Dragan Simic wrote: > Remove a redundant node from the Pine64 Pinebook Pro dts, which is intended > to provide a value for the delay in PCI Express enumeration, but that isn't > supported without additional out-of-tree kernel patches. > > There were already efforts to upstream those kernel patches, because they > reportedly make some PCI Express cards (such as LSI SAS HBAs) usable in > Pine64 RockPro64 (which is also based on the RK3399); otherwise, those PCI > Express cards fail to enumerate. However, providing the required background > and explanations proved to be a tough nut to crack, which is the reason why > those patches remain outside of the kernel mainline for now. > > [...] Applied, thanks! [1/1] arm64: dts: rockchip: Remove unsupported node from the Pinebook Pro dts commit: 43853e843aa6c3d47ff2b0cce898318839483d05 Best regards,
On 2024-04-01 23:55, Heiko Stuebner wrote: > On Mon, 1 Apr 2024 00:20:56 +0200, Dragan Simic wrote: >> Remove a redundant node from the Pine64 Pinebook Pro dts, which is >> intended >> to provide a value for the delay in PCI Express enumeration, but that >> isn't >> supported without additional out-of-tree kernel patches. >> >> There were already efforts to upstream those kernel patches, because >> they >> reportedly make some PCI Express cards (such as LSI SAS HBAs) usable >> in >> Pine64 RockPro64 (which is also based on the RK3399); otherwise, >> those PCI >> Express cards fail to enumerate. However, providing the required >> background >> and explanations proved to be a tough nut to crack, which is the >> reason why >> those patches remain outside of the kernel mainline for now. >> >> [...] > > Applied, thanks! > > [1/1] arm64: dts: rockchip: Remove unsupported node from the Pinebook > Pro dts > commit: 43853e843aa6c3d47ff2b0cce898318839483d05 Great, thanks!
diff --git a/arch/arm64/boot/dts/rockchip/rk3399-pinebook-pro.dts b/arch/arm64/boot/dts/rockchip/rk3399-pinebook-pro.dts index 054c6a4d1a45..294eb2de263d 100644 --- a/arch/arm64/boot/dts/rockchip/rk3399-pinebook-pro.dts +++ b/arch/arm64/boot/dts/rockchip/rk3399-pinebook-pro.dts @@ -779,7 +779,6 @@ &pcie_phy { }; &pcie0 { - bus-scan-delay-ms = <1000>; ep-gpios = <&gpio2 RK_PD4 GPIO_ACTIVE_HIGH>; num-lanes = <4>; pinctrl-names = "default";
Remove a redundant node from the Pine64 Pinebook Pro dts, which is intended to provide a value for the delay in PCI Express enumeration, but that isn't supported without additional out-of-tree kernel patches. There were already efforts to upstream those kernel patches, because they reportedly make some PCI Express cards (such as LSI SAS HBAs) usable in Pine64 RockPro64 (which is also based on the RK3399); otherwise, those PCI Express cards fail to enumerate. However, providing the required background and explanations proved to be a tough nut to crack, which is the reason why those patches remain outside of the kernel mainline for now. If those out-of-tree patches eventually become upstreamed, the resulting device-tree changes will almost surely belong to the RK3399 SoC dtsi. Also, the above-mentioned unusable-without-out-of-tree-patches PCI Express devices are in all fairness not usable in a Pinebook Pro without some extensive hardware modifications, which is another reason to delete this redundant node. When it comes to the Pinebook Pro, only M.2 NVMe SSDs can be installed out of the box (using an additional passive adapter PCB sold separately by Pine64), which reportedly works fine with no additional patches. Fixes: 5a65505a6988 ("arm64: dts: rockchip: Add initial support for Pinebook Pro") Signed-off-by: Dragan Simic <dsimic@manjaro.org> --- arch/arm64/boot/dts/rockchip/rk3399-pinebook-pro.dts | 1 - 1 file changed, 1 deletion(-)