| Message ID | 0ff17be9b31c9fcf03481c0665293b98ced741f7.1692871243.git.geert+renesas@glider.be (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | pinctrl: berlin: Drop superfluous ampersands | expand |
On Thu, Aug 24, 2023 at 12:05:50PM +0200, Geert Uytterhoeven wrote: > There is no need to use an ampersand to take the address of a function. > > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> Reviewed-by: Jisheng Zhang <jszhang@kernel.org> Hi Linus Walleij, If it's not too late, could you please merge it? Thanks in advance > --- > drivers/pinctrl/berlin/berlin.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/drivers/pinctrl/berlin/berlin.c b/drivers/pinctrl/berlin/berlin.c > index 1e427ea4d31bcbfc..9550cc8095c28720 100644 > --- a/drivers/pinctrl/berlin/berlin.c > +++ b/drivers/pinctrl/berlin/berlin.c > @@ -96,10 +96,10 @@ static int berlin_pinctrl_dt_node_to_map(struct pinctrl_dev *pctrl_dev, > } > > static const struct pinctrl_ops berlin_pinctrl_ops = { > - .get_groups_count = &berlin_pinctrl_get_group_count, > - .get_group_name = &berlin_pinctrl_get_group_name, > - .dt_node_to_map = &berlin_pinctrl_dt_node_to_map, > - .dt_free_map = &pinctrl_utils_free_map, > + .get_groups_count = berlin_pinctrl_get_group_count, > + .get_group_name = berlin_pinctrl_get_group_name, > + .dt_node_to_map = berlin_pinctrl_dt_node_to_map, > + .dt_free_map = pinctrl_utils_free_map, > }; > > static int berlin_pinmux_get_functions_count(struct pinctrl_dev *pctrl_dev) > -- > 2.34.1 >
On Thu, Aug 24, 2023 at 12:05 PM Geert Uytterhoeven <geert+renesas@glider.be> wrote: > There is no need to use an ampersand to take the address of a function. > > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> Patch applied as nonurgent fix. Yours, Linus Walleij
diff --git a/drivers/pinctrl/berlin/berlin.c b/drivers/pinctrl/berlin/berlin.c index 1e427ea4d31bcbfc..9550cc8095c28720 100644 --- a/drivers/pinctrl/berlin/berlin.c +++ b/drivers/pinctrl/berlin/berlin.c @@ -96,10 +96,10 @@ static int berlin_pinctrl_dt_node_to_map(struct pinctrl_dev *pctrl_dev, } static const struct pinctrl_ops berlin_pinctrl_ops = { - .get_groups_count = &berlin_pinctrl_get_group_count, - .get_group_name = &berlin_pinctrl_get_group_name, - .dt_node_to_map = &berlin_pinctrl_dt_node_to_map, - .dt_free_map = &pinctrl_utils_free_map, + .get_groups_count = berlin_pinctrl_get_group_count, + .get_group_name = berlin_pinctrl_get_group_name, + .dt_node_to_map = berlin_pinctrl_dt_node_to_map, + .dt_free_map = pinctrl_utils_free_map, }; static int berlin_pinmux_get_functions_count(struct pinctrl_dev *pctrl_dev)
There is no need to use an ampersand to take the address of a function. Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> --- drivers/pinctrl/berlin/berlin.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)