From patchwork Fri May 25 10:31:56 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Viresh Kumar X-Patchwork-Id: 10427045 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id CAF436032C for ; Fri, 25 May 2018 10:35:30 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id A98E8291AB for ; Fri, 25 May 2018 10:35:30 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 9CE5E29599; Fri, 25 May 2018 10:35:30 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.9 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI autolearn=unavailable version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 3BBE9291AB for ; Fri, 25 May 2018 10:35:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:References: In-Reply-To:Message-Id:Date:Subject:To:From:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=UvlRrYvEPWAPEoKOhZ+QM0K4zmzaE11FTfvF8xzIwDE=; b=ipIYBaAYLTFHnNUBZ8CBGSCA+n iGgEbDA2kOsvFCWFid1Ve6ycOnF6OiiopO5B7W04S/pyPe1Cz4WhuPJ/KFU6pFsX27/CZGhyc3Se7 NC4Rdgu1ViASRPZsAJAxdxx30g6OCr3m9WLRTtnExSraRa2SxggUapOiK98FbsuLXfteBfS+oSfzP 6UnYbKX87BI22c+rVN0GZw2jTLH3UJ2/1UG/5cW4VVe+ntfQJpwWJdksTPF00JXF6h8v7HyvWxrjj mAuhFQpj3WYiJ28PCrXodC+ZvEyo7rj7b9KpduF/qxAgyPGFdfZLL6AQxDg1uSdtGuumuz7+FeK3h 7rbwlyEw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1fMA48-0004pv-3b; Fri, 25 May 2018 10:35:20 +0000 Received: from mail-pg0-x244.google.com ([2607:f8b0:400e:c05::244]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1fMA1r-0002eX-K3 for linux-arm-kernel@lists.infradead.org; Fri, 25 May 2018 10:33:14 +0000 Received: by mail-pg0-x244.google.com with SMTP id a13-v6so2126578pgu.4 for ; Fri, 25 May 2018 03:32:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :in-reply-to:references; bh=oxDacl2OIDr7Nd409LauBugaXeD2W+E2eVDckohi0ks=; b=aUjijDtAWzLuCraf/W+u9hdAiXBJCGzHqYrbYBigOHcpOdOVz7d7vx5/o6SgESDQ0A jtES9fyNgy9vWG+Z5yW7OFFGWSqm1rVOePFI51XlAaWtMIkBIpkmiFERvWLksBe0DWHJ uH71VxUreFLM7ibCJrlXWJr6zSvraZzFyiMZA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:in-reply-to:references; bh=oxDacl2OIDr7Nd409LauBugaXeD2W+E2eVDckohi0ks=; b=VkGCWxTXHD9mHYTOC9f53Tzm5psogo5mjik4oVHKj1dnu+W5ILJmckux5lABpE2XSE G2Jsn6YQfrlq2hv5NgoCM7uyj5RRz9TAs0lmFDecItIQWVmPd79GphGviqwAfeTS3MZt G85ORRhKUQcbACm1npcEJRO3gM16I+0ODcbHU3gJZGuk4J/h6WWO6W+tvBiDLqS4fnAJ aiKOqbRuR6S8P04lakEmWJ0WiYUVUTf8Hs/oRkVSyRz8PsrQWA7iWzgeLxE1mcu91Jc+ QzcPigdescQGwidJwHSYeejCWngYc8Gexdy9o0kFfgwz3w6gAn7vyXSd2mntwkw50XKi L6qg== X-Gm-Message-State: ALKqPwfNsntGN44J//lKGqd/k3lV4Xv/M4EwcfLHDm7VYgyLCzy0o8M4 PJHyctv45hNlgqus08VdH+v/jw== X-Google-Smtp-Source: AB8JxZqx83qzjuPGpZugm5ruib/IuOi1sfSPQEu5SZzAOL6aWzn32CabZjtbgpOZ8AomWMDotMpMAA== X-Received: by 2002:a63:7255:: with SMTP id c21-v6mr623450pgn.99.1527244368051; Fri, 25 May 2018 03:32:48 -0700 (PDT) Received: from localhost ([122.172.112.176]) by smtp.gmail.com with ESMTPSA id l23-v6sm11414149pgc.61.2018.05.25.03.32.47 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 25 May 2018 03:32:47 -0700 (PDT) From: Viresh Kumar To: arm@kernel.org, Heiko Stuebner , Rob Herring , Mark Rutland Subject: [PATCH 10/15] arm: dts: rk3288: Add missing cooling device properties for CPUs Date: Fri, 25 May 2018 16:01:56 +0530 Message-Id: <11f16618dc965a7996976a2bca040cd87d1961d2.1527244201.git.viresh.kumar@linaro.org> X-Mailer: git-send-email 2.15.0.194.g9af6a3dea062 In-Reply-To: References: In-Reply-To: References: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20180525_033259_933491_EDDD7670 X-CRM114-Status: GOOD ( 13.28 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, Vincent Guittot , Viresh Kumar , Daniel Lezcano , linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org, chris.redpath@arm.com, ionela.voinescu@arm.com, linux-arm-kernel@lists.infradead.org MIME-Version: 1.0 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP The cooling device properties, like "#cooling-cells" and "dynamic-power-coefficient", should either be present for all the CPUs of a cluster or none. If these are present only for a subset of CPUs of a cluster then things will start falling apart as soon as the CPUs are brought online in a different order. For example, this will happen because the operating system looks for such properties in the CPU node it is trying to bring up, so that it can register a cooling device. Add such missing properties. Fix other missing properties (clocks, OPP, clock latency) as well to make it all work. Signed-off-by: Viresh Kumar --- arch/arm/boot/dts/rk3288.dtsi | 54 +++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 54 insertions(+) diff --git a/arch/arm/boot/dts/rk3288.dtsi b/arch/arm/boot/dts/rk3288.dtsi index d7e49d29ace5..752a892847dd 100644 --- a/arch/arm/boot/dts/rk3288.dtsi +++ b/arch/arm/boot/dts/rk3288.dtsi @@ -122,18 +122,72 @@ compatible = "arm,cortex-a12"; reg = <0x501>; resets = <&cru SRST_CORE1>; + operating-points = < + /* KHz uV */ + 1608000 1350000 + 1512000 1300000 + 1416000 1200000 + 1200000 1100000 + 1008000 1050000 + 816000 1000000 + 696000 950000 + 600000 900000 + 408000 900000 + 312000 900000 + 216000 900000 + 126000 900000 + >; + #cooling-cells = <2>; /* min followed by max */ + clock-latency = <40000>; + clocks = <&cru ARMCLK>; }; cpu2: cpu@502 { device_type = "cpu"; compatible = "arm,cortex-a12"; reg = <0x502>; resets = <&cru SRST_CORE2>; + operating-points = < + /* KHz uV */ + 1608000 1350000 + 1512000 1300000 + 1416000 1200000 + 1200000 1100000 + 1008000 1050000 + 816000 1000000 + 696000 950000 + 600000 900000 + 408000 900000 + 312000 900000 + 216000 900000 + 126000 900000 + >; + #cooling-cells = <2>; /* min followed by max */ + clock-latency = <40000>; + clocks = <&cru ARMCLK>; }; cpu3: cpu@503 { device_type = "cpu"; compatible = "arm,cortex-a12"; reg = <0x503>; resets = <&cru SRST_CORE3>; + operating-points = < + /* KHz uV */ + 1608000 1350000 + 1512000 1300000 + 1416000 1200000 + 1200000 1100000 + 1008000 1050000 + 816000 1000000 + 696000 950000 + 600000 900000 + 408000 900000 + 312000 900000 + 216000 900000 + 126000 900000 + >; + #cooling-cells = <2>; /* min followed by max */ + clock-latency = <40000>; + clocks = <&cru ARMCLK>; }; };