From patchwork Mon May 30 10:04:44 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Marc Zyngier X-Patchwork-Id: 829592 Received: from bombadil.infradead.org (173-166-109-252-newengland.hfc.comcastbusiness.net [173.166.109.252]) by demeter2.kernel.org (8.14.4/8.14.3) with ESMTP id p4UAEREd024173 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO) for ; Mon, 30 May 2011 10:14:50 GMT Received: from canuck.infradead.org ([2001:4978:20e::1]) by bombadil.infradead.org with esmtps (Exim 4.76 #1 (Red Hat Linux)) id 1QQzM7-0006jT-In; Mon, 30 May 2011 10:05:51 +0000 Received: from localhost ([127.0.0.1] helo=canuck.infradead.org) by canuck.infradead.org with esmtp (Exim 4.76 #1 (Red Hat Linux)) id 1QQzM4-000775-5t; Mon, 30 May 2011 10:05:48 +0000 Received: from inca-roads.misterjones.org ([213.251.177.50]) by canuck.infradead.org with esmtps (Exim 4.76 #1 (Red Hat Linux)) id 1QQzLZ-00073Y-EQ for linux-arm-kernel@lists.infradead.org; Mon, 30 May 2011 10:05:20 +0000 Received: from lopsy-lu.misterjones.org ([93.97.26.37] helo=localhost.localdomain) by inca-roads.misterjones.org with esmtpsa (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.69) (envelope-from ) id 1QQzLX-0007RK-12 for linux-arm-kernel@lists.infradead.org; Mon, 30 May 2011 12:05:15 +0200 From: Marc Zyngier To: linux-arm-kernel@lists.infradead.org Subject: [RFC PATCH v5 03/13] ARM: smp_twd: add support for remapped PPI interrupts Date: Mon, 30 May 2011 11:04:44 +0100 Message-Id: <1306749894-28749-4-git-send-email-marc.zyngier@arm.com> X-Mailer: git-send-email 1.7.5.2 In-Reply-To: <1306749894-28749-1-git-send-email-marc.zyngier@arm.com> References: <1306749894-28749-1-git-send-email-marc.zyngier@arm.com> X-SA-Exim-Connect-IP: 93.97.26.37 X-SA-Exim-Rcpt-To: linux-arm-kernel@lists.infradead.org X-SA-Exim-Mail-From: marc.zyngier@arm.com X-SA-Exim-Scanned: No (on inca-roads.misterjones.org); SAEximRunCond expanded to false X-CRM114-Version: 20090807-BlameThorstenAndJenny ( TRE 0.7.6 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20110530_060517_711676_18358FEF X-CRM114-Status: GOOD ( 15.36 ) X-Spam-Score: 0.0 (/) X-Spam-Report: SpamAssassin version 3.3.1 on canuck.infradead.org summary: Content analysis details: (0.0 points) pts rule name description ---- ---------------------- -------------------------------------------------- X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: linux-arm-kernel-bounces@lists.infradead.org Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Greylist: IP, sender and recipient auto-whitelisted, not delayed by milter-greylist-4.2.6 (demeter2.kernel.org [140.211.167.43]); Mon, 30 May 2011 10:14:50 +0000 (UTC) When CONFIG_ARM_GIC_VPPI is enabled, let smp_twd request interrupts the normal way (ie using request_irq()). This involves letting PPIs go via the same code path as SPIs and having normal interrupt handler for the local timer code. The previous ad-hoc code is still supported when CONFIG_ARM_GIC_VPPI is not defined. Signed-off-by: Marc Zyngier Reviewed-by: Will Deacon --- arch/arm/kernel/smp_twd.c | 28 +++++++++++++++++++++++++++- 1 files changed, 27 insertions(+), 1 deletions(-) diff --git a/arch/arm/kernel/smp_twd.c b/arch/arm/kernel/smp_twd.c index 60636f4..773336e 100644 --- a/arch/arm/kernel/smp_twd.c +++ b/arch/arm/kernel/smp_twd.c @@ -15,16 +15,18 @@ #include #include #include -#include +#include #include #include +#include #include /* set up by the platform code */ void __iomem *twd_base; static unsigned long twd_timer_rate; +static DEFINE_PER_CPU(bool, irq_reqd); static void twd_set_mode(enum clock_event_mode mode, struct clock_event_device *clk) @@ -43,6 +45,10 @@ static void twd_set_mode(enum clock_event_mode mode, ctrl = TWD_TIMER_CONTROL_IT_ENABLE | TWD_TIMER_CONTROL_ONESHOT; break; case CLOCK_EVT_MODE_UNUSED: +#ifdef CONFIG_ARM_GIC_VPPI + disable_irq(clk->irq); + /* fall through */ +#endif case CLOCK_EVT_MODE_SHUTDOWN: default: ctrl = 0; @@ -124,6 +130,9 @@ static void __cpuinit twd_calibrate_rate(void) */ void __cpuinit twd_timer_setup(struct clock_event_device *clk) { + int err; + bool *reqd; + twd_calibrate_rate(); clk->name = "local_timer"; @@ -137,8 +146,25 @@ void __cpuinit twd_timer_setup(struct clock_event_device *clk) clk->max_delta_ns = clockevent_delta2ns(0xffffffff, clk); clk->min_delta_ns = clockevent_delta2ns(0xf, clk); +#ifdef CONFIG_ARM_GIC_VPPI + reqd = &__get_cpu_var(irq_reqd); + if (!*reqd) { + err = request_irq(clk->irq, percpu_timer_handler, + IRQF_PERCPU | IRQF_NOBALANCING | IRQF_TIMER, + clk->name, clk); + if (err) { + pr_err("%s: can't register interrupt %d on cpu %d (%d)\n", + clk->name, clk->irq, smp_processor_id(), err); + return; + } + + *reqd = true; + } else + enable_irq(clk->irq); +#else /* Make sure our local interrupt controller has this enabled */ gic_enable_ppi(clk->irq); +#endif clockevents_register_device(clk); }