From patchwork Tue May 31 08:27:01 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jarkko Nikula X-Patchwork-Id: 832782 Received: from canuck.infradead.org (canuck.infradead.org [134.117.69.58]) by demeter1.kernel.org (8.14.4/8.14.3) with ESMTP id p4VEaTxD013869 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO) for ; Tue, 31 May 2011 14:36:51 GMT Received: from localhost ([127.0.0.1] helo=canuck.infradead.org) by canuck.infradead.org with esmtp (Exim 4.76 #1 (Red Hat Linux)) id 1QRKIF-0006kY-8m; Tue, 31 May 2011 08:27:15 +0000 Received: from mail-ey0-f177.google.com ([209.85.215.177]) by canuck.infradead.org with esmtps (Exim 4.76 #1 (Red Hat Linux)) id 1QRKI1-0006jv-9i for linux-arm-kernel@lists.infradead.org; Tue, 31 May 2011 08:27:01 +0000 Received: by eyh6 with SMTP id 6so1739213eyh.36 for ; Tue, 31 May 2011 01:27:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:from:to:cc:subject:date:message-id:x-mailer :in-reply-to:references; bh=4tZZuTG7zZz+c5CNqxYcQ8C9si4gsuGx9d+vLWnEOVE=; b=XtOw14rcV0EWPfH6UXqiAxMvwgAV+A1yxzYHQcJs24vzueLrBu7Q7lRh87NELPxiqa mfFo4S52ykCKfV5t11G+MFZKrfFxElq23E6HZ0WkLD53i2lM4eEEBlc65JOkn1XPTP/W 38htj2heFzkcUYjCqB3783gQi1LbgQ/FC2va4= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=from:to:cc:subject:date:message-id:x-mailer:in-reply-to:references; b=d4jossqCtXU2fuphUt54oPGt7c77YzW9KBaEGi9EezH2s+E/NO6FlO2F3qHSN8i33F RqzsnY/ytInCETz3HKI/Iw57mPYBVEV7VPr97CNTVP/zZov4SLLJROYOVDw+JCM7T9T0 WMO/gGuDms/FReBGpw1WZ+gbuj01zhR+6gzOY= Received: by 10.213.99.137 with SMTP id u9mr2198163ebn.34.1306830420043; Tue, 31 May 2011 01:27:00 -0700 (PDT) Received: from localhost ([194.136.136.46]) by mx.google.com with ESMTPS id f1sm3715982eec.27.2011.05.31.01.26.59 (version=TLSv1/SSLv3 cipher=OTHER); Tue, 31 May 2011 01:26:59 -0700 (PDT) From: Jarkko Nikula To: linux-omap@vger.kernel.org Subject: [PATCHv2 2/2] omap: rx51: Don't power up speaker amplifier at bootup Date: Tue, 31 May 2011 11:27:01 +0300 Message-Id: <1306830421-25727-2-git-send-email-jhnikula@gmail.com> X-Mailer: git-send-email 1.7.4.4 In-Reply-To: <1306830421-25727-1-git-send-email-jhnikula@gmail.com> References: <1306830421-25727-1-git-send-email-jhnikula@gmail.com> X-CRM114-Version: 20090807-BlameThorstenAndJenny ( TRE 0.7.6 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20110531_042701_483236_1B475FD3 X-CRM114-Status: GOOD ( 13.04 ) X-Spam-Score: -0.8 (/) X-Spam-Report: SpamAssassin version 3.3.1 on canuck.infradead.org summary: Content analysis details: (-0.8 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at http://www.dnswl.org/, low trust [209.85.215.177 listed in list.dnswl.org] 0.0 FREEMAIL_FROM Sender email is freemail (jhnikula[at]gmail.com) -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature 0.0 RFC_ABUSE_POST Both abuse and postmaster missing on sender domain 0.0 T_TO_NO_BRKTS_FREEMAIL T_TO_NO_BRKTS_FREEMAIL Cc: Tony Lindgren , Jarkko Nikula , Kalle Jokiniemi , linux-arm-kernel@lists.infradead.org X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: linux-arm-kernel-bounces@lists.infradead.org Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Greylist: IP, sender and recipient auto-whitelisted, not delayed by milter-greylist-4.2.6 (demeter1.kernel.org [140.211.167.41]); Tue, 31 May 2011 14:36:51 +0000 (UTC) Speaker amplifier is accidentally powered up in early TWL gpio setup. This causes a few mA of needless battery current consumption. Without this patch the amplifier can be shutdown only by having one active audio playback and shutdown cycle to speaker output. Thanks to Kalle Jokiniemi for noticing the issue. Signed-off-by: Jarkko Nikula Cc: Kalle Jokiniemi --- v2. Updated on top of commit bc593f5 ("arm: omap2plus: GPIO cleanup"). --- arch/arm/mach-omap2/board-rx51-peripherals.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/arch/arm/mach-omap2/board-rx51-peripherals.c b/arch/arm/mach-omap2/board-rx51-peripherals.c index 02a6587..9903667 100644 --- a/arch/arm/mach-omap2/board-rx51-peripherals.c +++ b/arch/arm/mach-omap2/board-rx51-peripherals.c @@ -583,7 +583,7 @@ static int rx51_twlgpio_setup(struct device *dev, unsigned gpio, unsigned n) { /* FIXME this gpio setup is just a placeholder for now */ gpio_request_one(gpio + 6, GPIOF_OUT_INIT_LOW, "backlight_pwm"); - gpio_request_one(gpio + 7, GPIOF_OUT_INIT_HIGH, "speaker_en"); + gpio_request_one(gpio + 7, GPIOF_OUT_INIT_LOW, "speaker_en"); return 0; }