diff mbox

[1/3] pxa2xx vpac: pcmcia - free gpios on exist rather than requesting them again.

Message ID 1307370255-15963-2-git-send-email-jic23@cam.ac.uk (mailing list archive)
State New, archived
Headers show

Commit Message

Jonathan Cameron June 6, 2011, 2:24 p.m. UTC 
Signed-off-by: Jonathan Cameron <jic23@cam.ac.uk>
---
 drivers/pcmcia/pxa2xx_vpac270.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

Comments

Marek Vasut June 6, 2011, 2:43 p.m. UTC | #1 
On Monday, June 06, 2011 04:24:13 PM Jonathan Cameron wrote:
> Signed-off-by: Jonathan Cameron <jic23@cam.ac.uk>
> ---
>  drivers/pcmcia/pxa2xx_vpac270.c |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/pcmcia/pxa2xx_vpac270.c
> b/drivers/pcmcia/pxa2xx_vpac270.c index 435002d..413dc7d 100644
> --- a/drivers/pcmcia/pxa2xx_vpac270.c
> +++ b/drivers/pcmcia/pxa2xx_vpac270.c
> @@ -75,10 +75,10 @@ static int vpac270_pcmcia_hw_init(struct
> soc_pcmcia_socket *skt) static void vpac270_pcmcia_hw_shutdown(struct
> soc_pcmcia_socket *skt) {
>  	if (skt->nr == 0)
> -		gpio_request_array(vpac270_pcmcia_gpios,
> +		gpio_free_array(vpac270_pcmcia_gpios,
>  					ARRAY_SIZE(vpac270_pcmcia_gpios));
>  	else
> -		gpio_request_array(vpac270_cf_gpios,
> +		gpio_free_array(vpac270_cf_gpios,
>  					ARRAY_SIZE(vpac270_cf_gpios));
>  }

Please add my

Acked-by: Marek Vasut <marek.vasut@gmail.com>

Thanks, cheers
Eric Miao June 15, 2011, 1:07 p.m. UTC | #2 
2011/6/6 Marek Vasut <marek.vasut@gmail.com>:
> On Monday, June 06, 2011 04:24:13 PM Jonathan Cameron wrote:
>> Signed-off-by: Jonathan Cameron <jic23@cam.ac.uk>
>> ---
>>  drivers/pcmcia/pxa2xx_vpac270.c |    4 ++--
>>  1 files changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/pcmcia/pxa2xx_vpac270.c
>> b/drivers/pcmcia/pxa2xx_vpac270.c index 435002d..413dc7d 100644
>> --- a/drivers/pcmcia/pxa2xx_vpac270.c
>> +++ b/drivers/pcmcia/pxa2xx_vpac270.c
>> @@ -75,10 +75,10 @@ static int vpac270_pcmcia_hw_init(struct
>> soc_pcmcia_socket *skt) static void vpac270_pcmcia_hw_shutdown(struct
>> soc_pcmcia_socket *skt) {
>>       if (skt->nr == 0)
>> -             gpio_request_array(vpac270_pcmcia_gpios,
>> +             gpio_free_array(vpac270_pcmcia_gpios,
>>                                       ARRAY_SIZE(vpac270_pcmcia_gpios));
>>       else
>> -             gpio_request_array(vpac270_cf_gpios,
>> +             gpio_free_array(vpac270_cf_gpios,
>>                                       ARRAY_SIZE(vpac270_cf_gpios));
>>  }
>
> Please add my
>
> Acked-by: Marek Vasut <marek.vasut@gmail.com>
>

Applied.
diff mbox

Patch

diff --git a/drivers/pcmcia/pxa2xx_vpac270.c b/drivers/pcmcia/pxa2xx_vpac270.c
index 435002d..413dc7d 100644
--- a/drivers/pcmcia/pxa2xx_vpac270.c
+++ b/drivers/pcmcia/pxa2xx_vpac270.c
@@ -75,10 +75,10 @@  static int vpac270_pcmcia_hw_init(struct soc_pcmcia_socket *skt)
 static void vpac270_pcmcia_hw_shutdown(struct soc_pcmcia_socket *skt)
 {
 	if (skt->nr == 0)
-		gpio_request_array(vpac270_pcmcia_gpios,
+		gpio_free_array(vpac270_pcmcia_gpios,
 					ARRAY_SIZE(vpac270_pcmcia_gpios));
 	else
-		gpio_request_array(vpac270_cf_gpios,
+		gpio_free_array(vpac270_cf_gpios,
 					ARRAY_SIZE(vpac270_cf_gpios));
 }