| Message ID | 1309871321-11305-8-git-send-email-dbaryshkov@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Hi, On Tue, Jul 05, 2011 at 05:08:33PM +0400, Dmitry Eremin-Solenikov wrote: > None of pxa25x devices use udc_command() for UDC functionality. > Stop calling this callback from pxa25x_udc code. looks good to me, Greg since this is a big re-work which depends on parts out of the Gadget Framework, can you take all the patches straight ? Here's my Acked-by: Acked-by: Felipe Balbi <balbi@ti.com>
On Tue, Jul 05, 2011 at 04:46:16PM +0300, Felipe Balbi wrote: > Hi, > > On Tue, Jul 05, 2011 at 05:08:33PM +0400, Dmitry Eremin-Solenikov wrote: > > None of pxa25x devices use udc_command() for UDC functionality. > > Stop calling this callback from pxa25x_udc code. > > looks good to me, Greg since this is a big re-work which depends on > parts out of the Gadget Framework, can you take all the patches > straight ? Here's my Acked-by: > > Acked-by: Felipe Balbi <balbi@ti.com> I can't take these, they should go through the gpio subsystem maintainer instead. thanks, greg k-h
On Fri, Jul 08, 2011 at 02:34:28PM -0700, Greg KH wrote: > On Tue, Jul 05, 2011 at 04:46:16PM +0300, Felipe Balbi wrote: > > Hi, > > > > On Tue, Jul 05, 2011 at 05:08:33PM +0400, Dmitry Eremin-Solenikov wrote: > > > None of pxa25x devices use udc_command() for UDC functionality. > > > Stop calling this callback from pxa25x_udc code. > > > > looks good to me, Greg since this is a big re-work which depends on > > parts out of the Gadget Framework, can you take all the patches > > straight ? Here's my Acked-by: > > > > Acked-by: Felipe Balbi <balbi@ti.com> > > I can't take these, they should go through the gpio subsystem maintainer > instead. But why ? They only touch drivers/usb/gadget/pxa*.c Would it be enough if Grant would Ack them ?
On Sat, Jul 09, 2011 at 12:54:43AM +0300, Felipe Balbi wrote: > On Fri, Jul 08, 2011 at 02:34:28PM -0700, Greg KH wrote: > > On Tue, Jul 05, 2011 at 04:46:16PM +0300, Felipe Balbi wrote: > > > Hi, > > > > > > On Tue, Jul 05, 2011 at 05:08:33PM +0400, Dmitry Eremin-Solenikov wrote: > > > > None of pxa25x devices use udc_command() for UDC functionality. > > > > Stop calling this callback from pxa25x_udc code. > > > > > > looks good to me, Greg since this is a big re-work which depends on > > > parts out of the Gadget Framework, can you take all the patches > > > straight ? Here's my Acked-by: > > > > > > Acked-by: Felipe Balbi <balbi@ti.com> > > > > I can't take these, they should go through the gpio subsystem maintainer > > instead. > > But why ? They only touch drivers/usb/gadget/pxa*.c All 15 patches? No they don't they touch all sorts of things. > Would it be enough if Grant would Ack them ? Sure, but it would be easier if Grant took them all, right? thanks, greg k-h
Hi, On Fri, Jul 08, 2011 at 03:02:58PM -0700, Greg KH wrote: > > > I can't take these, they should go through the gpio subsystem maintainer > > > instead. > > > > But why ? They only touch drivers/usb/gadget/pxa*.c > > All 15 patches? No they don't they touch all sorts of things. > > > Would it be enough if Grant would Ack them ? > > Sure, but it would be easier if Grant took them all, right? Makes sense too.
Hi, On 7/9/11, Greg KH <greg@kroah.com> wrote: > On Tue, Jul 05, 2011 at 04:46:16PM +0300, Felipe Balbi wrote: >> Hi, >> >> On Tue, Jul 05, 2011 at 05:08:33PM +0400, Dmitry Eremin-Solenikov wrote: >> > None of pxa25x devices use udc_command() for UDC functionality. >> > Stop calling this callback from pxa25x_udc code. >> >> looks good to me, Greg since this is a big re-work which depends on >> parts out of the Gadget Framework, can you take all the patches >> straight ? Here's my Acked-by: >> >> Acked-by: Felipe Balbi <balbi@ti.com> > > I can't take these, they should go through the gpio subsystem maintainer > instead. Why? I can understand if you'd say that it should go through the ARM/PXA trees, but why GPIO?
On 7/9/11, Greg KH <gregkh@suse.de> wrote: > On Sat, Jul 09, 2011 at 12:54:43AM +0300, Felipe Balbi wrote: >> On Fri, Jul 08, 2011 at 02:34:28PM -0700, Greg KH wrote: >> > On Tue, Jul 05, 2011 at 04:46:16PM +0300, Felipe Balbi wrote: >> > > Hi, >> > > >> > > On Tue, Jul 05, 2011 at 05:08:33PM +0400, Dmitry Eremin-Solenikov >> > > wrote: >> > > > None of pxa25x devices use udc_command() for UDC functionality. >> > > > Stop calling this callback from pxa25x_udc code. >> > > >> > > looks good to me, Greg since this is a big re-work which depends on >> > > parts out of the Gadget Framework, can you take all the patches >> > > straight ? Here's my Acked-by: >> > > >> > > Acked-by: Felipe Balbi <balbi@ti.com> >> > >> > I can't take these, they should go through the gpio subsystem maintainer >> > instead. >> >> But why ? They only touch drivers/usb/gadget/pxa*.c > > All 15 patches? No they don't they touch all sorts of things. > >> Would it be enough if Grant would Ack them ? > > Sure, but it would be easier if Grant took them all, right? Colleagues, can you please tell me the current status/future of this patches? Are they going to 3.1? 3.2? Should they go via ARM/PXA, via usb? usb-gadget? Via gpio(why?)?? Should I send them to somebody for merging? Thank you!
On Tue, Jul 12, 2011 at 9:41 PM, Dmitry Eremin-Solenikov <dbaryshkov@gmail.com> wrote: > On 7/9/11, Greg KH <gregkh@suse.de> wrote: >> On Sat, Jul 09, 2011 at 12:54:43AM +0300, Felipe Balbi wrote: >>> On Fri, Jul 08, 2011 at 02:34:28PM -0700, Greg KH wrote: >>> > On Tue, Jul 05, 2011 at 04:46:16PM +0300, Felipe Balbi wrote: >>> > > Hi, >>> > > >>> > > On Tue, Jul 05, 2011 at 05:08:33PM +0400, Dmitry Eremin-Solenikov >>> > > wrote: >>> > > > None of pxa25x devices use udc_command() for UDC functionality. >>> > > > Stop calling this callback from pxa25x_udc code. >>> > > >>> > > looks good to me, Greg since this is a big re-work which depends on >>> > > parts out of the Gadget Framework, can you take all the patches >>> > > straight ? Here's my Acked-by: >>> > > >>> > > Acked-by: Felipe Balbi <balbi@ti.com> >>> > >>> > I can't take these, they should go through the gpio subsystem maintainer >>> > instead. >>> >>> But why ? They only touch drivers/usb/gadget/pxa*.c >> >> All 15 patches? No they don't they touch all sorts of things. >> >>> Would it be enough if Grant would Ack them ? >> >> Sure, but it would be easier if Grant took them all, right? > > Colleagues, can you please tell me the current status/future of this patches? > Are they going to 3.1? 3.2? Should they go via ARM/PXA, via usb? usb-gadget? > Via gpio(why?)?? Should I send them to somebody for merging? Well, I agree with Dmitry the whole patchset is not related to the GPIO subsystem at all. The major cleanup is actually to the PXA machines, and touches part of the pxa25x_udc driver. If some one Acks the USB part, I can help take the remaining patches.
On 07/14/2011 04:52 AM, Eric Miao wrote: > Well, I agree with Dmitry the whole patchset is not related to the GPIO > subsystem at all. The major cleanup is actually to the PXA machines, > and touches part of the pxa25x_udc driver. If some one Acks the USB > part, I can help take the remaining patches. Ok, I tested the patches for the pxa27x_udc and mioa701 parts. Therefore, as it is working, for patches 2, 13, and 15 (reduced to pxa27x_udc), I give my : Acked-by: Robert Jarzmik <robert.jarzmik@free> That leaves you with the pxa25x_udc, I'm afraid, but I don't maintain that one. Is there an identified maintainer now, or at least someone able to test it ? Cheers. -- Robert
On 07/14/2011 08:24 PM, Robert Jarzmik wrote: > On 07/14/2011 04:52 AM, Eric Miao wrote: >> Well, I agree with Dmitry the whole patchset is not related to the GPIO >> subsystem at all. The major cleanup is actually to the PXA machines, >> and touches part of the pxa25x_udc driver. If some one Acks the USB >> part, I can help take the remaining patches. > And I forgot patch 12 : Acked-by: Robert Jarzmik <robert.jarzmik@free> Cheers. -- Robert
Not sure if zaurus people can help test it. Pavel? - eric On Fri, Jul 15, 2011 at 2:24 AM, Robert Jarzmik <robert.jarzmik@free.fr> wrote: > On 07/14/2011 04:52 AM, Eric Miao wrote: >> >> Well, I agree with Dmitry the whole patchset is not related to the GPIO >> subsystem at all. The major cleanup is actually to the PXA machines, >> and touches part of the pxa25x_udc driver. If some one Acks the USB >> part, I can help take the remaining patches. > > Ok, I tested the patches for the pxa27x_udc and mioa701 parts. > Therefore, as it is working, for patches 2, 13, and 15 (reduced to > pxa27x_udc), I give my : > Acked-by: Robert Jarzmik <robert.jarzmik@free> > > That leaves you with the pxa25x_udc, I'm afraid, but I don't maintain that > one. Is there an identified maintainer now, or at least someone able to test > it ? > > Cheers. > > -- > Robert >
Hi, On Thu, Jul 14, 2011 at 10:52:47AM +0800, Eric Miao wrote: > On Tue, Jul 12, 2011 at 9:41 PM, Dmitry Eremin-Solenikov > <dbaryshkov@gmail.com> wrote: > > On 7/9/11, Greg KH <gregkh@suse.de> wrote: > >> On Sat, Jul 09, 2011 at 12:54:43AM +0300, Felipe Balbi wrote: > >>> On Fri, Jul 08, 2011 at 02:34:28PM -0700, Greg KH wrote: > >>> > On Tue, Jul 05, 2011 at 04:46:16PM +0300, Felipe Balbi wrote: > >>> > > Hi, > >>> > > > >>> > > On Tue, Jul 05, 2011 at 05:08:33PM +0400, Dmitry Eremin-Solenikov > >>> > > wrote: > >>> > > > None of pxa25x devices use udc_command() for UDC functionality. > >>> > > > Stop calling this callback from pxa25x_udc code. > >>> > > > >>> > > looks good to me, Greg since this is a big re-work which depends on > >>> > > parts out of the Gadget Framework, can you take all the patches > >>> > > straight ? Here's my Acked-by: > >>> > > > >>> > > Acked-by: Felipe Balbi <balbi@ti.com> > >>> > > >>> > I can't take these, they should go through the gpio subsystem maintainer > >>> > instead. > >>> > >>> But why ? They only touch drivers/usb/gadget/pxa*.c > >> > >> All 15 patches? No they don't they touch all sorts of things. > >> > >>> Would it be enough if Grant would Ack them ? > >> > >> Sure, but it would be easier if Grant took them all, right? > > > > Colleagues, can you please tell me the current status/future of this patches? > > Are they going to 3.1? 3.2? Should they go via ARM/PXA, via usb? usb-gadget? > > Via gpio(why?)?? Should I send them to somebody for merging? > > Well, I agree with Dmitry the whole patchset is not related to the GPIO > subsystem at all. The major cleanup is actually to the PXA machines, > and touches part of the pxa25x_udc driver. If some one Acks the USB > part, I can help take the remaining patches. For the gadget part you can have my Ack. Although I don't have how to test those patches, they seem simple enough: Acked-by: Felipe Balbi <balbi@ti.com>
diff --git a/drivers/usb/gadget/pxa25x_udc.c b/drivers/usb/gadget/pxa25x_udc.c index 6f543c7..aa34698 100644 --- a/drivers/usb/gadget/pxa25x_udc.c +++ b/drivers/usb/gadget/pxa25x_udc.c @@ -144,8 +144,6 @@ static void pullup_off(void) if (gpio_is_valid(mach->gpio_pullup)) gpio_set_value(mach->gpio_pullup, off_level); - else if (mach->udc_command) - mach->udc_command(PXA2XX_UDC_CMD_DISCONNECT); } static void pullup_on(void) @@ -155,8 +153,6 @@ static void pullup_on(void) if (gpio_is_valid(mach->gpio_pullup)) gpio_set_value(mach->gpio_pullup, on_level); - else if (mach->udc_command) - mach->udc_command(PXA2XX_UDC_CMD_CONNECT); } static void pio_irq_enable(int bEndpointAddress) @@ -984,7 +980,7 @@ static int pxa25x_udc_pullup(struct usb_gadget *_gadget, int is_active) udc = container_of(_gadget, struct pxa25x_udc, gadget); /* not all boards support pullup control */ - if (!gpio_is_valid(udc->mach->gpio_pullup) && !udc->mach->udc_command) + if (!gpio_is_valid(udc->mach->gpio_pullup)) return -EOPNOTSUPP; udc->pullup = (is_active != 0); @@ -2241,7 +2237,7 @@ static int pxa25x_udc_suspend(struct platform_device *dev, pm_message_t state) struct pxa25x_udc *udc = platform_get_drvdata(dev); unsigned long flags; - if (!gpio_is_valid(udc->mach->gpio_pullup) && !udc->mach->udc_command) + if (!gpio_is_valid(udc->mach->gpio_pullup)) WARNING("USB host won't detect disconnect!\n"); udc->suspended = 1;
None of pxa25x devices use udc_command() for UDC functionality. Stop calling this callback from pxa25x_udc code. Signed-off-by: Dmitry Eremin-Solenikov <dbaryshkov@gmail.com> --- drivers/usb/gadget/pxa25x_udc.c | 8 ++------ 1 files changed, 2 insertions(+), 6 deletions(-)