From patchwork Mon Jul 25 13:38:31 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Vinod Koul X-Patchwork-Id: 1004362 Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) by demeter2.kernel.org (8.14.4/8.14.4) with ESMTP id p6PDdTD8013066 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO) for ; Mon, 25 Jul 2011 13:39:50 GMT Received: from canuck.infradead.org ([2001:4978:20e::1]) by merlin.infradead.org with esmtps (Exim 4.76 #1 (Red Hat Linux)) id 1QlLNH-0005hj-8p; Mon, 25 Jul 2011 13:39:11 +0000 Received: from localhost ([127.0.0.1] helo=canuck.infradead.org) by canuck.infradead.org with esmtp (Exim 4.76 #1 (Red Hat Linux)) id 1QlLNG-0006lk-TI; Mon, 25 Jul 2011 13:39:10 +0000 Received: from casper.infradead.org ([2001:770:15f::2]) by canuck.infradead.org with esmtps (Exim 4.76 #1 (Red Hat Linux)) id 1QlLNE-0006lf-31 for linux-arm-kernel@canuck.infradead.org; Mon, 25 Jul 2011 13:39:08 +0000 Received: from [192.55.79.164] (helo=[10.255.18.12]) by casper.infradead.org with esmtpsa (Exim 4.76 #1 (Red Hat Linux)) id 1QlLNA-00036Y-Ee; Mon, 25 Jul 2011 13:39:05 +0000 Subject: Re: [PATCH 0/9] PL08x further cleanups From: Vinod Koul To: Russell King - ARM Linux In-Reply-To: <20110721160800.GR26574@n2100.arm.linux.org.uk> References: <20110705131030.GE8286@n2100.arm.linux.org.uk> <1310598328.1536.27.camel@vkoul-udesk3> <20110721160800.GR26574@n2100.arm.linux.org.uk> Organization: Intel Corp Date: Mon, 25 Jul 2011 19:08:31 +0530 Message-ID: <1311601111.8206.5.camel@vkoul-mobl4> Mime-Version: 1.0 X-Mailer: Evolution 2.32.2 Cc: vinod.koul@intel.com, Dan Williams , Linus Walleij , linux-arm-kernel@lists.infradead.org X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linux-arm-kernel-bounces@lists.infradead.org Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Greylist: IP, sender and recipient auto-whitelisted, not delayed by milter-greylist-4.2.6 (demeter2.kernel.org [140.211.167.43]); Mon, 25 Jul 2011 13:39:50 +0000 (UTC) On Thu, 2011-07-21 at 17:08 +0100, Russell King - ARM Linux wrote: > On Thu, Jul 14, 2011 at 04:35:28AM +0530, Koul, Vinod wrote: > > On Tue, 2011-07-05 at 14:10 +0100, Russell King - ARM Linux wrote: > > > This patch series is the remainder of the PL08x work I did earlier > > > this year while trying to get the ARM platforms working with DMA. > > > > > > Unfortunately, due to the state of the hardware, I was not able to > > > properly test these changes. However, they do compile, and I think > > > if others are going to be looking at the PL08x DMA engine driver, > > > they're worth having. > > > > > > Linus, can you check these out on your hardware please? > > > > Russell, > > > > The fail to build for me, on line 550 it refers to bd.llil_bus whereas > > the bd is a pointer. Further the WIDTH macros seem to be missing. > > Grr, I've updated the patches and will post the two updated ones. I > have them in my git tree - would you like them via git instead, or > would you prefer to provide acks and let me push them upstream? > Russell, Thanks I have applied this Although gcc didnt like not handling other enums so warned: drivers/dma/amba-pl08x.c: In function 'pl08x_width': drivers/dma/amba-pl08x.c:1119: warning: enumeration value 'DMA_SLAVE_BUSWIDTH_UNDEFINED' not handled in switch drivers/dma/amba-pl08x.c:1119: warning: enumeration value 'DMA_SLAVE_BUSWIDTH_8_BYTES' not handled in switch which can be fixed as: } If you are okay, pls ack it diff --git a/drivers/dma/amba-pl08x.c b/drivers/dma/amba-pl08x.c index 9aa2bd4..4925e0d 100644 --- a/drivers/dma/amba-pl08x.c +++ b/drivers/dma/amba-pl08x.c @@ -1123,6 +1123,8 @@ static u32 pl08x_width(enum dma_slave_buswidth width) return PL080_WIDTH_16BIT; case DMA_SLAVE_BUSWIDTH_4_BYTES: return PL080_WIDTH_32BIT; + default: + return -EINVAL; } return ~0;