[3/5] mach-u300: patch physoffset by default

Commit Message

Linus Walleij Aug. 9, 2011, 7:41 p.m. UTC

From: Linus Walleij <[e-mail]>

This works like a charm so I'll just default-select it.

Cc: Nicolas Pitre <[e-mail]>
Signed-off-by: Linus Walleij <[e-mail]>
---
 arch/arm/Kconfig |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

Comments

Russell King - ARM Linux Aug. 10, 2011, 9:16 a.m. UTC | #1

On Tue, Aug 09, 2011 at 09:41:38PM +0200, Linus Walleij wrote:
> From: Linus Walleij <[e-mail]>
> 
> This works like a charm so I'll just default-select it.

Well, we can remove the EXPERIMENTAL status of this option now.  This
raises the question is whether we should now default it to 'y' - I
think we should.  Anyone have any objections?

Will Deacon Aug. 10, 2011, 9:22 a.m. UTC | #2

On Wed, Aug 10, 2011 at 10:16:35AM +0100, Russell King - ARM Linux wrote:
> On Tue, Aug 09, 2011 at 09:41:38PM +0200, Linus Walleij wrote:
> > From: Linus Walleij <[e-mail]>
> > 
> > This works like a charm so I'll just default-select it.
> 
> Well, we can remove the EXPERIMENTAL status of this option now.  This
> raises the question is whether we should now default it to 'y' - I
> think we should.  Anyone have any objections?

I've been running with this option enabled for the collection of ARM boards
I have and the only problem I have encountered was related to u-boot loading
at the wrong address.

So I'm all for enabling it by default, especially since it will force out
any remaining issues for boards where this hasn't been used extensively.

Will

Russell King - ARM Linux Aug. 10, 2011, 9:29 a.m. UTC | #3

On Wed, Aug 10, 2011 at 10:22:06AM +0100, Will Deacon wrote:
> On Wed, Aug 10, 2011 at 10:16:35AM +0100, Russell King - ARM Linux wrote:
> > On Tue, Aug 09, 2011 at 09:41:38PM +0200, Linus Walleij wrote:
> > > From: Linus Walleij <[e-mail]>
> > > 
> > > This works like a charm so I'll just default-select it.
> > 
> > Well, we can remove the EXPERIMENTAL status of this option now.  This
> > raises the question is whether we should now default it to 'y' - I
> > think we should.  Anyone have any objections?
> 
> I've been running with this option enabled for the collection of ARM boards
> I have and the only problem I have encountered was related to u-boot loading
> at the wrong address.
> 
> So I'm all for enabling it by default, especially since it will force out
> any remaining issues for boards where this hasn't been used extensively.

Maybe also making the option hidden depending on EXPERT, or even EMBEDDED
would be a good idea too.  I think it falls into at least the same class
as UID16, sysctl, hotplug, printk, etc. which are all EXPERT options.

Linus Walleij Aug. 10, 2011, 9:40 a.m. UTC | #4

On Wed, Aug 10, 2011 at 11:16 AM, Russell King - ARM Linux
<[e-mail]> wrote:
> On Tue, Aug 09, 2011 at 09:41:38PM +0200, Linus Walleij wrote:
>> From: Linus Walleij <[e-mail]>
>>
>> This works like a charm so I'll just default-select it.
>
> Well, we can remove the EXPERIMENTAL status of this option now.  This
> raises the question is whether we should now default it to 'y' - I
> think we should.  Anyone have any objections?

I agree, no objections. Works flawlessly on all my systems.

Thanks,
Linus Walleij

Patch

diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig
index 2c71a8f..14bfd8b 100644
--- a/arch/arm/Kconfig
+++ b/arch/arm/Kconfig
@@ -831,6 +831,7 @@  config ARCH_U300
 	select HAVE_SCHED_CLOCK
 	select HAVE_TCM
 	select ARM_AMBA
+	select ARM_PATCH_PHYS_VIRT
 	select ARM_VIC
 	select GENERIC_CLOCKEVENTS
 	select CLKDEV_LOOKUP