From patchwork Fri Aug 12 10:26:25 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Abhilash Kesavan X-Patchwork-Id: 1060302 Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) by demeter1.kernel.org (8.14.4/8.14.4) with ESMTP id p7CATEDk020090 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO) for ; Fri, 12 Aug 2011 10:29:35 GMT Received: from canuck.infradead.org ([2001:4978:20e::1]) by merlin.infradead.org with esmtps (Exim 4.76 #1 (Red Hat Linux)) id 1Qroyi-0001LQ-Dz; Fri, 12 Aug 2011 10:28:37 +0000 Received: from localhost ([127.0.0.1] helo=canuck.infradead.org) by canuck.infradead.org with esmtp (Exim 4.76 #1 (Red Hat Linux)) id 1Qroxn-00078j-H5; Fri, 12 Aug 2011 10:27:39 +0000 Received: from mailout2.samsung.com ([203.254.224.25]) by canuck.infradead.org with esmtp (Exim 4.76 #1 (Red Hat Linux)) id 1Qrow8-0006bE-5G for linux-arm-kernel@lists.infradead.org; Fri, 12 Aug 2011 10:25:57 +0000 Received: from epcpsbgm1.samsung.com (mailout2.samsung.com [203.254.224.25]) by mailout2.samsung.com (Oracle Communications Messaging Exchange Server 7u4-19.01 64bit (built Sep 7 2010)) with ESMTP id <0LPT00DB48YJOVR0@mailout2.samsung.com> for linux-arm-kernel@lists.infradead.org; Fri, 12 Aug 2011 19:25:34 +0900 (KST) X-AuditID: cbfee61a-b7cf0ae000006bc6-f6-4e44ff9e3fbc Received: from epmmp2 ( [203.254.227.17]) by epcpsbgm1.samsung.com (MMPCPMTA) with SMTP id A4.45.27590.E9FF44E4; Fri, 12 Aug 2011 19:25:34 +0900 (KST) Received: from localhost.localdomain ([107.108.73.92]) by mmp2.samsung.com (iPlanet Messaging Server 5.2 Patch 2 (built Jul 14 2004)) with ESMTPA id <0LPT00ESK8YEI1@mmp2.samsung.com> for linux-arm-kernel@lists.infradead.org; Fri, 12 Aug 2011 19:25:34 +0900 (KST) Date: Fri, 12 Aug 2011 15:56:25 +0530 From: Abhilash Kesavan Subject: [PATCH 3/5] ARM: S5P64X0: Add pm save/restore functions for GPIO banks In-reply-to: <1313144787-30666-1-git-send-email-a.kesavan@samsung.com> To: linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, kgene.kim@samsung.com Message-id: <1313144787-30666-4-git-send-email-a.kesavan@samsung.com> X-Mailer: git-send-email 1.6.6.1 References: <1313144787-30666-1-git-send-email-a.kesavan@samsung.com> X-Brightmail-Tracker: AAAAAA== X-CRM114-Version: 20090807-BlameThorstenAndJenny ( TRE 0.7.6 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20110812_062556_661719_0B550205 X-CRM114-Status: GOOD ( 14.59 ) X-Spam-Score: -3.1 (---) X-Spam-Report: SpamAssassin version 3.3.1 on canuck.infradead.org summary: Content analysis details: (-3.1 points) pts rule name description ---- ---------------------- -------------------------------------------------- -2.3 RCVD_IN_DNSWL_MED RBL: Sender listed at http://www.dnswl.org/, medium trust [203.254.224.25 listed in list.dnswl.org] -0.8 RP_MATCHES_RCVD Envelope sender domain matches handover relay domain X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: linux-arm-kernel-bounces@lists.infradead.org Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Greylist: IP, sender and recipient auto-whitelisted, not delayed by milter-greylist-4.2.6 (demeter1.kernel.org [140.211.167.41]); Fri, 12 Aug 2011 10:29:35 +0000 (UTC) Fix the "no pm for GPIOXX" messages appearing during bootup due to missing assignment of save/restore functions for those banks. Signed-off-by: Abhilash Kesavan --- arch/arm/mach-s5p64x0/gpiolib.c | 1 + drivers/gpio/gpio-plat-samsung.c | 4 +++- 2 files changed, 4 insertions(+), 1 deletions(-) diff --git a/arch/arm/mach-s5p64x0/gpiolib.c b/arch/arm/mach-s5p64x0/gpiolib.c index e7fb3b0..76c0924 100644 --- a/arch/arm/mach-s5p64x0/gpiolib.c +++ b/arch/arm/mach-s5p64x0/gpiolib.c @@ -467,6 +467,7 @@ static void __init s5p64x0_gpio_add_rbank_4bit2(struct s3c_gpio_chip *chip, chip->chip.direction_input = s5p64x0_gpiolib_rbank_4bit2_input; chip->chip.direction_output = s5p64x0_gpiolib_rbank_4bit2_output; + chip->pm = __gpio_pm(&s3c_gpio_pm_4bit); s3c_gpiolib_add(chip); } } diff --git a/drivers/gpio/gpio-plat-samsung.c b/drivers/gpio/gpio-plat-samsung.c index ef67f19..4f7c387 100644 --- a/drivers/gpio/gpio-plat-samsung.c +++ b/drivers/gpio/gpio-plat-samsung.c @@ -200,6 +200,8 @@ void __init samsung_gpiolib_add_4bit2_chips(struct s3c_gpio_chip *chip, void __init samsung_gpiolib_add_2bit_chips(struct s3c_gpio_chip *chip, int nr_chips) { - for (; nr_chips > 0; nr_chips--, chip++) + for (; nr_chips > 0; nr_chips--, chip++) { + chip->pm = __gpio_pm(&s3c_gpio_pm_2bit); s3c_gpiolib_add(chip); + } }