| Message ID | 1313189697-21287-6-git-send-email-swarren@nvidia.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Fri, Aug 12, 2011 at 3:54 PM, Stephen Warren <swarren@nvidia.com> wrote: > Add board-specific gpio node for Harmony and Seaboard. This lists the > GPIOs used by the board. Note that not all GPIOs that exist on the board > are listed; only those used by devices currently supported by device > tree. I don't want to bikeshed over this, but something like "nvidia,enabled-gpios" could be a bit more descriptive. Either way is OK though. The property should be documented under the bindings Documentation/ hierarchy though. -Olof
Olof Johansson wrote at Sunday, August 14, 2011 1:02 AM: > On Fri, Aug 12, 2011 at 3:54 PM, Stephen Warren <swarren@nvidia.com> wrote: > > Add board-specific gpio node for Harmony and Seaboard. This lists the > > GPIOs used by the board. Note that not all GPIOs that exist on the board > > are listed; only those used by devices currently supported by device > > tree. > > I don't want to bikeshed over this, but something like > "nvidia,enabled-gpios" could be a bit more descriptive. Either way is > OK though. Yes, that's a much better name. Existing board files do have a Boolean enabled/disabled flag per GPIO, which is currently always true, whereas this patch series only implements "enabled" entries. I thought about it briefly, and didn't think that explicitly disabling GPIOs that the bootloader had already enabled was likely to be useful. Do you agree? Possibly not since IIRC you added the tables that contain that Boolean. > The property should be documented under the bindings Documentation/ > hierarchy though. Yup. The next posting will include this.
diff --git a/arch/arm/boot/dts/tegra-harmony.dts b/arch/arm/boot/dts/tegra-harmony.dts index 4c05334..c9bb847 100644 --- a/arch/arm/boot/dts/tegra-harmony.dts +++ b/arch/arm/boot/dts/tegra-harmony.dts @@ -15,6 +15,21 @@ reg = < 0x00000000 0x40000000 >; }; + gpio: gpio@6000d000 { + nvidia,gpios = < + 69 // TEGRA_GPIO_PI5 SD2_CD + 57 // TEGRA_GPIO_PH1 SD2_WP + 155 // TEGRA_GPIO_PT3 SD2_POWER + 58 // TEGRA_GPIO_PH2 SD4_CD + 59 // TEGRA_GPIO_PH3 SD4_WP + 70 // TEGRA_GPIO_PI6 SD4_POWER + 187 // TEGRA_GPIO_PX3 CDC_IRQ + 178 // TEGRA_GPIO_PW2 HP_DET + 184 // TEGRA_GPIO_PX0 INT_MIC_EN + 185 // TEGRA_GPIO_PX1 EXT_MIC_EN + >; + }; + i2c@7000c000 { clock-frequency = <400000>; diff --git a/arch/arm/boot/dts/tegra-seaboard.dts b/arch/arm/boot/dts/tegra-seaboard.dts index 1940cae..b0d44a5 100644 --- a/arch/arm/boot/dts/tegra-seaboard.dts +++ b/arch/arm/boot/dts/tegra-seaboard.dts @@ -16,6 +16,14 @@ reg = < 0x00000000 0x40000000 >; }; + gpio: gpio@6000d000 { + nvidia,gpios = < + 69 // TEGRA_GPIO_PI5 SD2_CD + 57 // TEGRA_GPIO_PH1 SD2_WP + 70 // TEGRA_GPIO_PI6 SD2_POWER + >; + }; + serial@70006300 { clock-frequency = < 216000000 >; };
Add board-specific gpio node for Harmony and Seaboard. This lists the GPIOs used by the board. Note that not all GPIOs that exist on the board are listed; only those used by devices currently supported by device tree. Signed-off-by: Stephen Warren <swarren@nvidia.com> --- arch/arm/boot/dts/tegra-harmony.dts | 15 +++++++++++++++ arch/arm/boot/dts/tegra-seaboard.dts | 8 ++++++++ 2 files changed, 23 insertions(+), 0 deletions(-)