diff mbox

arm: footbridge: Netwinder: Add KConfig select CLKEVT_I8253 to fix build failure

Message ID 1313422280-21942-1-git-send-email-peterhuewe@gmx.de (mailing list archive)
State New, archived
Headers show

Commit Message

Peter Huewe Aug. 15, 2011, 3:31 p.m. UTC
This patch fixes a build failure for the netwinder_defconfig by adding
the necessary select CLKEVT_I8253 statement to the KCONFIG option.

Without this patch the build fails with this linker error:
isa-rtc.c:(.init.text+0x11d4): undefined reference to
`clockevent_i8253_init'
isa-rtc.c:(.init.text+0x11dc): undefined reference to `i8253_clockevent'
arch/arm/mach-footbridge/built-in.o:(.data+0x18c): undefined reference
to `i8253_clockevent'

This is because the functions are guarded by a #ifdef
CONFIG_CLKEVT_I8253

KernelVersion: Linux-next 20110812
but this is also present in Linus' current tree since July 1st.
(since commit e6220bd "i8253: Create common clockevent implementation")

Signed-off-by: Peter Huewe <peterhuewe@gmx.de>
---
 arch/arm/mach-footbridge/Kconfig |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

Comments

Russell King - ARM Linux Aug. 15, 2011, 3:33 p.m. UTC | #1
On Mon, Aug 15, 2011 at 05:31:20PM +0200, Peter Huewe wrote:
> diff --git a/arch/arm/mach-footbridge/Kconfig b/arch/arm/mach-footbridge/Kconfig
> index dc26fff..c8e7afc 100644
> --- a/arch/arm/mach-footbridge/Kconfig
> +++ b/arch/arm/mach-footbridge/Kconfig
> @@ -62,6 +62,7 @@ config ARCH_EBSA285_HOST
>  config ARCH_NETWINDER
>  	bool "NetWinder"
>  	select CLKSRC_I8253
> +	select CLKEVT_I8253

Could you please add this in alphabetical order, just like the rest of the
'select' options here?

>  	select FOOTBRIDGE_HOST
>  	select ISA
>  	select ISA_DMA

Then I'll take it through the patch system into my fixes branch.  Thanks.
diff mbox

Patch

diff --git a/arch/arm/mach-footbridge/Kconfig b/arch/arm/mach-footbridge/Kconfig
index dc26fff..c8e7afc 100644
--- a/arch/arm/mach-footbridge/Kconfig
+++ b/arch/arm/mach-footbridge/Kconfig
@@ -62,6 +62,7 @@  config ARCH_EBSA285_HOST
 config ARCH_NETWINDER
 	bool "NetWinder"
 	select CLKSRC_I8253
+	select CLKEVT_I8253
 	select FOOTBRIDGE_HOST
 	select ISA
 	select ISA_DMA