| Message ID | 1314037024-9015-1-git-send-email-fabio.estevam@freescale.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Hi Fabio, On Mon, Aug 22, 2011 at 03:17:03PM -0300, Fabio Estevam wrote: > Currently each i.MX processor has its own function for displaying the silicon > revision. > > Introduce a generic function for this purpose, so that all i.MX processors can > reuse it. Looks good, thanks. Do you care to update the other SoCs aswell? Sascha > > Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com> > --- > Changes since v1: > > - Introduce this generic function as suggested by Sascha Hauer. > > Sascha, > > If these 2 patches are merged, then I will convert the other i.MX processors > to use this new method. > > arch/arm/plat-mxc/cpu.c | 10 ++++++++++ > arch/arm/plat-mxc/include/mach/common.h | 1 + > 2 files changed, 11 insertions(+), 0 deletions(-) > > diff --git a/arch/arm/plat-mxc/cpu.c b/arch/arm/plat-mxc/cpu.c > index 386e0d5..f081ef0 100644 > --- a/arch/arm/plat-mxc/cpu.c > +++ b/arch/arm/plat-mxc/cpu.c > @@ -1,5 +1,6 @@ > > #include <linux/module.h> > +#include <mach/hardware.h> > > unsigned int __mxc_cpu_type; > EXPORT_SYMBOL(__mxc_cpu_type); > @@ -9,3 +10,12 @@ void mxc_set_cpu_type(unsigned int type) > __mxc_cpu_type = type; > } > > +void imx_print_silicon_rev(const char *cpu, int srev) > +{ > + if (srev == IMX_CHIP_REVISION_UNKNOWN) > + pr_info("CPU identified as %s, unknown revision\n", cpu); > + else > + pr_info("CPU identified as %s, silicon rev %d.%d\n", > + cpu, (srev >> 4) & 0xf, srev & 0xf); > +} > +EXPORT_SYMBOL(imx_print_silicon_rev); > diff --git a/arch/arm/plat-mxc/include/mach/common.h b/arch/arm/plat-mxc/include/mach/common.h > index 91fa263..e427f63 100644 > --- a/arch/arm/plat-mxc/include/mach/common.h > +++ b/arch/arm/plat-mxc/include/mach/common.h > @@ -72,4 +72,5 @@ extern void mxc_arch_reset_init(void __iomem *); > extern void mx51_efikamx_reset(void); > extern int mx53_revision(void); > extern int mx53_display_revision(void); > +extern void imx_print_silicon_rev(const char *cpu, int srev); > #endif > -- > 1.7.1 > > >
Hi, Sascha, Fabio, 2011/8/23 Sascha Hauer <s.hauer@pengutronix.de>: > Hi Fabio, > > On Mon, Aug 22, 2011 at 03:17:03PM -0300, Fabio Estevam wrote: >> Currently each i.MX processor has its own function for displaying the silicon >> revision. >> >> Introduce a generic function for this purpose, so that all i.MX processors can >> reuse it. > > Looks good, thanks. Do you care to update the other SoCs aswell? I have already started to updated all other SoCs, I will send out patch soon. Jason > > Sascha > >> >> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com> >> --- >> Changes since v1: >> >> - Introduce this generic function as suggested by Sascha Hauer. >> >> Sascha, >> >> If these 2 patches are merged, then I will convert the other i.MX processors >> to use this new method. >> >> arch/arm/plat-mxc/cpu.c | 10 ++++++++++ >> arch/arm/plat-mxc/include/mach/common.h | 1 + >> 2 files changed, 11 insertions(+), 0 deletions(-) >> >> diff --git a/arch/arm/plat-mxc/cpu.c b/arch/arm/plat-mxc/cpu.c >> index 386e0d5..f081ef0 100644 >> --- a/arch/arm/plat-mxc/cpu.c >> +++ b/arch/arm/plat-mxc/cpu.c >> @@ -1,5 +1,6 @@ >> >> #include <linux/module.h> >> +#include <mach/hardware.h> >> >> unsigned int __mxc_cpu_type; >> EXPORT_SYMBOL(__mxc_cpu_type); >> @@ -9,3 +10,12 @@ void mxc_set_cpu_type(unsigned int type) >> __mxc_cpu_type = type; >> } >> >> +void imx_print_silicon_rev(const char *cpu, int srev) >> +{ >> + if (srev == IMX_CHIP_REVISION_UNKNOWN) >> + pr_info("CPU identified as %s, unknown revision\n", cpu); >> + else >> + pr_info("CPU identified as %s, silicon rev %d.%d\n", >> + cpu, (srev >> 4) & 0xf, srev & 0xf); >> +} >> +EXPORT_SYMBOL(imx_print_silicon_rev); >> diff --git a/arch/arm/plat-mxc/include/mach/common.h b/arch/arm/plat-mxc/include/mach/common.h >> index 91fa263..e427f63 100644 >> --- a/arch/arm/plat-mxc/include/mach/common.h >> +++ b/arch/arm/plat-mxc/include/mach/common.h >> @@ -72,4 +72,5 @@ extern void mxc_arch_reset_init(void __iomem *); >> extern void mx51_efikamx_reset(void); >> extern int mx53_revision(void); >> extern int mx53_display_revision(void); >> +extern void imx_print_silicon_rev(const char *cpu, int srev); >> #endif >> -- >> 1.7.1 >> >> >> > > -- > Pengutronix e.K. | | > Industrial Linux Solutions | http://www.pengutronix.de/ | > Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | > Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | > > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel >
diff --git a/arch/arm/plat-mxc/cpu.c b/arch/arm/plat-mxc/cpu.c index 386e0d5..f081ef0 100644 --- a/arch/arm/plat-mxc/cpu.c +++ b/arch/arm/plat-mxc/cpu.c @@ -1,5 +1,6 @@ #include <linux/module.h> +#include <mach/hardware.h> unsigned int __mxc_cpu_type; EXPORT_SYMBOL(__mxc_cpu_type); @@ -9,3 +10,12 @@ void mxc_set_cpu_type(unsigned int type) __mxc_cpu_type = type; } +void imx_print_silicon_rev(const char *cpu, int srev) +{ + if (srev == IMX_CHIP_REVISION_UNKNOWN) + pr_info("CPU identified as %s, unknown revision\n", cpu); + else + pr_info("CPU identified as %s, silicon rev %d.%d\n", + cpu, (srev >> 4) & 0xf, srev & 0xf); +} +EXPORT_SYMBOL(imx_print_silicon_rev); diff --git a/arch/arm/plat-mxc/include/mach/common.h b/arch/arm/plat-mxc/include/mach/common.h index 91fa263..e427f63 100644 --- a/arch/arm/plat-mxc/include/mach/common.h +++ b/arch/arm/plat-mxc/include/mach/common.h @@ -72,4 +72,5 @@ extern void mxc_arch_reset_init(void __iomem *); extern void mx51_efikamx_reset(void); extern int mx53_revision(void); extern int mx53_display_revision(void); +extern void imx_print_silicon_rev(const char *cpu, int srev); #endif
Currently each i.MX processor has its own function for displaying the silicon revision. Introduce a generic function for this purpose, so that all i.MX processors can reuse it. Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com> --- Changes since v1: - Introduce this generic function as suggested by Sascha Hauer. Sascha, If these 2 patches are merged, then I will convert the other i.MX processors to use this new method. arch/arm/plat-mxc/cpu.c | 10 ++++++++++ arch/arm/plat-mxc/include/mach/common.h | 1 + 2 files changed, 11 insertions(+), 0 deletions(-)