From patchwork Sat Jun 30 12:08:53 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sylwester Nawrocki X-Patchwork-Id: 1134281 Return-Path: X-Original-To: patchwork-linux-arm@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork1.kernel.org Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) by patchwork1.kernel.org (Postfix) with ESMTP id DA52A40AC1 for ; Sat, 30 Jun 2012 12:12:52 +0000 (UTC) Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.76 #1 (Red Hat Linux)) id 1SkwUc-0008WS-QP; Sat, 30 Jun 2012 12:09:38 +0000 Received: from mail-ey0-f177.google.com ([209.85.215.177]) by merlin.infradead.org with esmtps (Exim 4.76 #1 (Red Hat Linux)) id 1SkwUO-0008Tn-Mo for linux-arm-kernel@lists.infradead.org; Sat, 30 Jun 2012 12:09:25 +0000 Received: by eaaf11 with SMTP id f11so1715834eaa.36 for ; Sat, 30 Jun 2012 05:09:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:x-mailer:in-reply-to:references; bh=bMFMwjaW5qNBLzz/WqgGDoPCA4GLrqGHotIXtXPHrac=; b=tvHxEpvm6ElG989hDJ8mvmAohM0z9n1nL5YXugQiyNGrMRfl+X0QfoeX3+qr02XSCg +kvg/GOGNXiz1B1FxGdeM004srEkZc+P9dK5qbZ6qjQa8gUwvbO1I/PRG73hMk+NKkmi 0Qb75H1AZMIiD6B4iqj0xE7SfucZPCmQVZKNji1xDMHFN/i58sYhjwDkpGyDaQ9Z5mtU gq5+IsTukVrvtZPiQvLkxC9X9EmOqKm+IgDp3HMEUjKtUS3CJFmseSKFS/cBPTfTF3i3 Max+ueRPxJDxyrc26TG1IiNLKWd2FBKOk2IxW4xN5+VWd6HEqqFcn92xiv5sBEwhRTnO /Taw== Received: by 10.14.95.207 with SMTP id p55mr1472883eef.40.1341058162970; Sat, 30 Jun 2012 05:09:22 -0700 (PDT) Received: from localhost.localdomain (031011252076.warszawa.vectranet.pl. [31.11.252.76]) by mx.google.com with ESMTPS id a16sm16456798eeg.0.2012.06.30.05.09.21 (version=TLSv1/SSLv3 cipher=OTHER); Sat, 30 Jun 2012 05:09:22 -0700 (PDT) From: Sylwester Nawrocki To: kgene.kim@samsung.com Subject: [PATCH 01/10] ARM: S3C24XX: Free the backlight gpio requested in Mini2440 board code Date: Sat, 30 Jun 2012 14:08:53 +0200 Message-Id: <1341058142-30438-2-git-send-email-sylvester.nawrocki@gmail.com> X-Mailer: git-send-email 1.7.4.1 In-Reply-To: <1341058142-30438-1-git-send-email-sylvester.nawrocki@gmail.com> References: <1341058142-30438-1-git-send-email-sylvester.nawrocki@gmail.com> X-Spam-Note: CRM114 invocation failed X-Spam-Score: -2.7 (--) X-Spam-Report: SpamAssassin version 3.3.2 on merlin.infradead.org summary: Content analysis details: (-2.7 points) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (sylvester.nawrocki[at]gmail.com) -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at http://www.dnswl.org/, low trust [209.85.215.177 listed in list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature Cc: Sylwester Nawrocki , linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, ben-linux@fluff.org X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: linux-arm-kernel-bounces@lists.infradead.org Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org The backlight gpio must not be left requested in the board code, otherwise s3c24xx_led driver can't successfully claim it. So request the backlight gpio, configure it to proper state and gpio_free right away. This change is required for converting the s3c24xx_led driver to the gpiolib API. Signed-off-by: Sylwester Nawrocki Acked-by: jbe@pengutronix.de --- arch/arm/mach-s3c24xx/mach-mini2440.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/arm/mach-s3c24xx/mach-mini2440.c b/arch/arm/mach-s3c24xx/mach-mini2440.c index f092b18..bd6d252 100644 --- a/arch/arm/mach-s3c24xx/mach-mini2440.c +++ b/arch/arm/mach-s3c24xx/mach-mini2440.c @@ -634,8 +634,8 @@ static void __init mini2440_init(void) s3c_gpio_cfgpin(S3C2410_GPC(0), S3C2410_GPC0_LEND); /* Turn the backlight early on */ - WARN_ON(gpio_request(S3C2410_GPG(4), "backlight")); - gpio_direction_output(S3C2410_GPG(4), 1); + WARN_ON(gpio_request_one(S3C2410_GPG(4), GPIOF_OUT_INIT_HIGH, NULL)); + gpio_free(S3C2410_GPG(4)); /* remove pullup on optional PWM backlight -- unused on 3.5 and 7"s */ s3c_gpio_setpull(S3C2410_GPB(1), S3C_GPIO_PULL_UP);