| Message ID | 1343233066-15397-2-git-send-email-zonque@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Wednesday 25 July 2012, Daniel Mack wrote: > +* PXA RTC > + > +PXA specific RTC driver. > + > +Required properties: > +- compatible : Should be pxa-rtc > + > +Examples: > + > +rtc@0 { > + compatible = "mrvl,pxa-rtc"; > +}; The description doesn't match the example here, I think you should change both to marvell,pxa-rtc. Arnd
Hello. On 25-07-2012 20:17, Daniel Mack wrote: > This patch adds generic device tree bindings to the PXA RTC driver. > Documentation for bindings were also added. > Signed-off-by: Daniel Mack <zonque@gmail.com> > Cc: Robert Jarzmik <robert.jarzmik@free.fr> > Cc: Alessandro Zummo <a.zummo@towertech.it> > --- > Documentation/devicetree/bindings/rtc/pxa-rtc.txt | 12 ++++++++++++ > drivers/rtc/rtc-pxa.c | 11 +++++++++++ > 2 files changed, 23 insertions(+) > create mode 100644 Documentation/devicetree/bindings/rtc/pxa-rtc.txt > diff --git a/Documentation/devicetree/bindings/rtc/pxa-rtc.txt b/Documentation/devicetree/bindings/rtc/pxa-rtc.txt > new file mode 100644 > index 0000000..acba256 > --- /dev/null > +++ b/Documentation/devicetree/bindings/rtc/pxa-rtc.txt > @@ -0,0 +1,12 @@ > +* PXA RTC > + > +PXA specific RTC driver. > + > +Required properties: > +- compatible : Should be pxa-rtc > + > +Examples: > + > +rtc@0 { Don't use the address postfix when the node doesn't have "reg" property. > + compatible = "mrvl,pxa-rtc"; > +}; WBR, Sergei
diff --git a/Documentation/devicetree/bindings/rtc/pxa-rtc.txt b/Documentation/devicetree/bindings/rtc/pxa-rtc.txt new file mode 100644 index 0000000..acba256 --- /dev/null +++ b/Documentation/devicetree/bindings/rtc/pxa-rtc.txt @@ -0,0 +1,12 @@ +* PXA RTC + +PXA specific RTC driver. + +Required properties: +- compatible : Should be pxa-rtc + +Examples: + +rtc@0 { + compatible = "mrvl,pxa-rtc"; +}; diff --git a/drivers/rtc/rtc-pxa.c b/drivers/rtc/rtc-pxa.c index 0075c8f..50d062a 100644 --- a/drivers/rtc/rtc-pxa.c +++ b/drivers/rtc/rtc-pxa.c @@ -27,6 +27,8 @@ #include <linux/interrupt.h> #include <linux/io.h> #include <linux/slab.h> +#include <linux/of.h> +#include <linux/of_device.h> #include <mach/hardware.h> @@ -396,6 +398,14 @@ static int __exit pxa_rtc_remove(struct platform_device *pdev) return 0; } +#ifdef CONFIG_OF +static struct of_device_id pxa_rtc_dt_ids[] = { + { .compatible = "mrvl,pxa-rtc" }, + {} +}; +MODULE_DEVICE_TABLE(of, pxa_rtc_dt_ids); +#endif + #ifdef CONFIG_PM static int pxa_rtc_suspend(struct device *dev) { @@ -425,6 +435,7 @@ static struct platform_driver pxa_rtc_driver = { .remove = __exit_p(pxa_rtc_remove), .driver = { .name = "pxa-rtc", + .of_match_table = of_match_ptr(pxa_rtc_dt_ids), #ifdef CONFIG_PM .pm = &pxa_rtc_pm_ops, #endif
This patch adds generic device tree bindings to the PXA RTC driver. Documentation for bindings were also added. Signed-off-by: Daniel Mack <zonque@gmail.com> Cc: Robert Jarzmik <robert.jarzmik@free.fr> Cc: Alessandro Zummo <a.zummo@towertech.it> --- Documentation/devicetree/bindings/rtc/pxa-rtc.txt | 12 ++++++++++++ drivers/rtc/rtc-pxa.c | 11 +++++++++++ 2 files changed, 23 insertions(+) create mode 100644 Documentation/devicetree/bindings/rtc/pxa-rtc.txt