From patchwork Tue Aug 21 09:15:44 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Felipe Balbi X-Patchwork-Id: 1353281 Return-Path: X-Original-To: patchwork-linux-arm@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork1.kernel.org Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) by patchwork1.kernel.org (Postfix) with ESMTP id 2795A40210 for ; Tue, 21 Aug 2012 09:24:55 +0000 (UTC) Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.76 #1 (Red Hat Linux)) id 1T3kdT-00025T-7m; Tue, 21 Aug 2012 09:20:31 +0000 Received: from na3sys009aog125.obsmtp.com ([74.125.149.153]) by merlin.infradead.org with smtps (Exim 4.76 #1 (Red Hat Linux)) id 1T3kd2-0001zy-Bj for linux-arm-kernel@lists.infradead.org; Tue, 21 Aug 2012 09:20:05 +0000 Received: from mail-lpp01m010-f46.google.com ([209.85.215.46]) (using TLSv1) by na3sys009aob125.postini.com ([74.125.148.12]) with SMTP ID DSNKUDNSwRtMW9b6oLbMUm26Z64WAVJzmAR8@postini.com; Tue, 21 Aug 2012 02:20:04 PDT Received: by lagy9 with SMTP id y9so3774028lag.19 for ; Tue, 21 Aug 2012 02:20:00 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=from:to:cc:subject:date:message-id:x-mailer:in-reply-to:references :x-gm-message-state; bh=Y/N1Smt833W8A1sgZ9IagtfMkTg7QklF48S2ORk/ims=; b=FcF0irl8IKgihJmG9yVf/53xNk73KM2Z51vXyiJ1J4rGVkv/H6zgkJRC9uc3FBA7jB FVq5fkgj8xAqGQqjSOweTQCn7gXZvXHIuNsY7dJ6UxCOhXozyE5bhSEdMyFb3HM2pSCh g793UBSBuB4951fIag6yHb9XA42pVT0NFtes2Iu0bfi4u0V6MPlgu8w1geoWHDE/99sv Yqx21MrUY8qfbneXmbwkD8M47YuGBtaTt5EFF652Atn4C5HHL0IXXPwRZgoq8NHJe5yW 6dwHoYAU4hvlyuUxPMVq8zdgjZJFOEMxOZLfk7GtbhTSCXIX90i2Zb4eNQYq7Z0PGrn2 8l1g== Received: by 10.152.148.199 with SMTP id tu7mr16602483lab.37.1345540800340; Tue, 21 Aug 2012 02:20:00 -0700 (PDT) Received: from localhost (cs78217178.pp.htv.fi. [62.78.217.178]) by mx.google.com with ESMTPS id fd1sm283609lbb.7.2012.08.21.02.19.58 (version=TLSv1/SSLv3 cipher=OTHER); Tue, 21 Aug 2012 02:19:59 -0700 (PDT) From: Felipe Balbi To: alan@linux.intel.com Subject: [RFC/PATCH 02/13] serial: omap: always return IRQ_HANDLED Date: Tue, 21 Aug 2012 12:15:44 +0300 Message-Id: <1345540555-24359-3-git-send-email-balbi@ti.com> X-Mailer: git-send-email 1.7.12.rc3 In-Reply-To: <1345540555-24359-1-git-send-email-balbi@ti.com> References: <1345540555-24359-1-git-send-email-balbi@ti.com> X-Gm-Message-State: ALoCoQmBkF1ApalvnHrx02ANHiQj7rhm7JlT3eemSBpVvcGUm/y5sJUU8FY5PQqvxnaU7kENvcXS X-Spam-Note: CRM114 invocation failed X-Spam-Score: -4.2 (----) X-Spam-Report: SpamAssassin version 3.3.2 on merlin.infradead.org summary: Content analysis details: (-4.2 points) pts rule name description ---- ---------------------- -------------------------------------------------- -2.3 RCVD_IN_DNSWL_MED RBL: Sender listed at http://www.dnswl.org/, medium trust [74.125.149.153 listed in list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] Cc: Kevin Hilman , Tony Lindgren , Linux Kernel Mailing List , Felipe Balbi , Santosh Shilimkar , linux-serial@vger.kernel.org, Linux OMAP Mailing List , Shubhrajyoti Datta , Linux ARM Kernel Mailing List X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: linux-arm-kernel-bounces@lists.infradead.org Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org Even if we enter our IRQ handler just to notice that the our device didn't generate the IRQ, that still means "handling" and IRQ, so let's return IRQ_HANDLED. Signed-off-by: Felipe Balbi --- drivers/tty/serial/omap-serial.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/tty/serial/omap-serial.c b/drivers/tty/serial/omap-serial.c index 5c0d0bc..b4b95fc 100644 --- a/drivers/tty/serial/omap-serial.c +++ b/drivers/tty/serial/omap-serial.c @@ -417,7 +417,7 @@ static inline irqreturn_t serial_omap_irq(int irq, void *dev_id) if (iir & UART_IIR_NO_INT) { pm_runtime_mark_last_busy(&up->pdev->dev); pm_runtime_put_autosuspend(&up->pdev->dev); - return IRQ_NONE; + return IRQ_HANDLED; } spin_lock_irqsave(&up->port.lock, flags);