From patchwork Tue Aug 21 15:58:41 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 1416481 Return-Path: X-Original-To: patchwork-linux-arm@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork1.kernel.org Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) by patchwork1.kernel.org (Postfix) with ESMTP id 3403B3FC85 for ; Thu, 6 Sep 2012 15:53:28 +0000 (UTC) Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.76 #1 (Red Hat Linux)) id 1T9eB2-0003Yj-Fs; Thu, 06 Sep 2012 15:39:33 +0000 Received: from moutng.kundenserver.de ([212.227.17.10]) by merlin.infradead.org with esmtp (Exim 4.76 #1 (Red Hat Linux)) id 1T3qr1-0004fB-Ai for linux-arm-kernel@lists.infradead.org; Tue, 21 Aug 2012 15:58:56 +0000 Received: from localhost.localdomain (HSI-KBW-149-172-5-253.hsi13.kabel-badenwuerttemberg.de [149.172.5.253]) by mrelayeu.kundenserver.de (node=mrbap3) with ESMTP (Nemesis) id 0Mdurl-1TK8oK2yEP-00Pe8J; Tue, 21 Aug 2012 17:58:53 +0200 From: Arnd Bergmann To: linux-arm-kernel@lists.infradead.org Subject: [RFC 1/4] ARM: autogenerate mach-foo/* and plat-foo/* header redirects Date: Tue, 21 Aug 2012 17:58:41 +0200 Message-Id: <1345564724-14466-2-git-send-email-arnd@arndb.de> X-Mailer: git-send-email 1.7.10 In-Reply-To: <1345564724-14466-1-git-send-email-arnd@arndb.de> References: <1345564724-14466-1-git-send-email-arnd@arndb.de> X-Provags-ID: V02:K0:nAak1O3b+Fj5vbSUqsqJXvk1gvHAlSv2z0T1xWt+6o6 e8FOMA+ABuZEzJCrab+GEs7GgtWMLVEiYVAoKn4i52kD2Gc9kM 1OKtL3gvPdZdx1nRjp72LIrLPJhmO8rVdObS5gHTL5WascbLSo eHyuuROoITL67zYnnnIk5hGJ79hBwSTe83gp3z+70lY/pjRxGR n2iVdPTRydHm5xZ1461OzZi+5Th08SCrKtaNlOBWlC9xTQi2mI 1zuY9JcJSMCgv3VKZ2WcmG//u1cfBSjz0ZynAVP0+I+RTHHb0K PUmeEPbEHZwNZx8Cn59iOpSkWLbTvyGr9EA+s3MuxP0Ed1BK4i /qHKZp0Qg4X+24UPMbiBuayoI87KftrGpkNWgo5LIp00SvhqM2 UBQaYz7bVDqYA== X-Bad-Reply: References and In-Reply-To but no 'Re:' in Subject. X-Spam-Note: CRM114 invocation failed X-Spam-Score: -1.9 (-) X-Spam-Report: SpamAssassin version 3.3.2 on merlin.infradead.org summary: Content analysis details: (-1.9 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at http://www.dnswl.org/, no trust [212.227.17.10 listed in list.dnswl.org] -0.0 SPF_HELO_PASS SPF: HELO matches SPF record -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Mailman-Approved-At: Thu, 06 Sep 2012 10:43:46 -0400 Cc: Arnd Bergmann X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: linux-arm-kernel-bounces@lists.infradead.org Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org This is an attempt to simplify the duplicate header problem for multiplatform kernels, in multiple steps: 1. (this patch) for each arch/arm/mach-${MACHINE}/include/mach-${MACHINE}/*.h file, generate a arch/arm/include/generated/mach/*.h file at build time, same for plat-*. 2. rename all arch/arm/mach-${MACHINE}/include/mach/*.h to arch/arm/mach-${MACHINE}/include/mach-${MACHINE}/*.h and arch/arm/plat-${PLAT}/include/plat/*.h to arch/arm/plat-${PLAT}/include/plat-${PLAT}/*.h 3. change all includes of to in all files where ${MACHINE} is known. 4. ... 5. Revert this patch again. We can apply this patch at any time, and do step 2 at the end of the next merge window to minimize the potential for conflicts. We will also still need to deal with any inclusion of a mach/* file, but out of the 6355 ones we have today, I expect only a few hundred to remain after step 3 and they will be much easier to spot. I've picked the format to get a unique name because it matches the directory name under arch/arm, but other names would work with the same script, and have been suggested previously. Signed-off-by: Arnd Bergmann --- arch/arm/Makefile | 1 + arch/arm/tools/Makefile | 5 ++++ arch/arm/tools/gen-headers | 57 ++++++++++++++++++++++++++++++++++++++++++++ 3 files changed, 63 insertions(+) create mode 100755 arch/arm/tools/gen-headers diff --git a/arch/arm/Makefile b/arch/arm/Makefile index 30eae87..761b077 100644 --- a/arch/arm/Makefile +++ b/arch/arm/Makefile @@ -274,6 +274,7 @@ boot := arch/arm/boot archprepare: $(Q)$(MAKE) $(build)=arch/arm/tools include/generated/mach-types.h + $(Q)$(MAKE) $(build)=arch/arm/tools plat="$(plat-y)" machine="$(machine-y)" gen_headers # Convert bzImage to zImage bzImage: zImage diff --git a/arch/arm/tools/Makefile b/arch/arm/tools/Makefile index 635cb18..6e18ca9 100644 --- a/arch/arm/tools/Makefile +++ b/arch/arm/tools/Makefile @@ -8,3 +8,8 @@ include/generated/mach-types.h: $(src)/gen-mach-types $(src)/mach-types @echo ' Generating $@' @mkdir -p $(dir $@) $(Q)$(AWK) -f $^ > $@ || { rm -f $@; /bin/false; } + +gen_headers: + $(Q)bash $(srctree)/$(src)/gen-headers $(srctree) $(objtree) $(machine) $(plat) + +.PHONY: gen_headers diff --git a/arch/arm/tools/gen-headers b/arch/arm/tools/gen-headers new file mode 100755 index 0000000..caa6a9a --- /dev/null +++ b/arch/arm/tools/gen-headers @@ -0,0 +1,57 @@ +#!/bin/bash + +SRC=$1 +OBJ=$2 +MACH=$3 +PLAT1=$4 +PLAT2=$5 + +# create $3 to include $2 if it doesn't already have the correct +# contents, or remove it if it's no longer needed. +mkfile() +{ + if [ -e $1/$2 ] ; then + if [ ! -e $3 ] ; then + mkdir -p ${3%/*} + echo "#include <${2}>" > $3 + elif [ "`cat $3`" != "#include <${2#./}>" ] ; then + echo "#include <${2}>" > $3 + fi + elif [ ! -e $1/$2 -a -e $3 ] ; then + rm -f $3 + fi +} + +# list any header files that are present in the source or +# destination directories +find_files() +{ + pushd ${SRC}/arch/arm/$1-$2/include/$1-$2 >/dev/null 2>&1 && + find . -type f -name \*.h -o -name \*.S && + popd > /dev/null 2>&1 + pushd ${OBJ}/arch/arm/include/generated/$1 >/dev/null 2>&1 && + find . -type f -name \*.h -o -name \*.S && + popd > /dev/null 2>&1 +} + +# process files in either mach-{MACH} or plat-${PLAT} +mkfiles() +{ + mkdir -p ${OBJ}/arch/arm/include/generated/$1 + + FILES=`find_files $1 $2 | sort -u` + for i in ${FILES} ; do + mkfile "${SRC}/arch/arm/$1-$2/include/" "$1-$2/${i#./}" \ + "${OBJ}/arch/arm/include/generated/$1/$i" + done +} + +# always process mach-* +mkfiles mach ${MACH} +# process plat-* if applicable +if [ -d ${SRC}/arch/arm/plat-${PLAT1} ]; then + mkfiles plat ${PLAT1} +fi +if [ -d ${SRC}/arch/arm/plat-${PLAT2} ]; then + mkfiles plat ${PLAT2} +fi