diff mbox

[3/7] gpio/ab8500: MASK_ON_SUSPEND

Message ID 1345625042-5678-1-git-send-email-linus.walleij@stericsson.com (mailing list archive)
State New, archived
Headers show

Commit Message

Linus Walleij Aug. 22, 2012, 8:44 a.m. UTC 
From: Etienne Carriere <etienne.carriere@stericsson.com>

ux500 machines performs pins (GPIO) reconfiguration when entering
in the suspended mode. This reconfiguration aims at reaching an ultra
low power HW configuration.

Due to this HW reconfiguration, some HW devices can change of HW state
and have their output signals at level that could generate IRQs.

If the non-wakeup IRQs are disabled but not yet masked (delayed interrupt
disable feature from the generic irq layer), effective interrupts reach
the system only because the system attempt to enter the suspended mode.

To prevent such IRQs to trig, all irq chips embedded in ux500 platform
should enable their IRQCHIP_MASK_ON_SUSPEND flag.

Cc: Grant Likely <grant.likely@secretlab.ca>
Signed-off-by: Etienne Carriere <etienne.carriere@stericsson.com>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
---
 drivers/gpio/gpio-ab8500.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Linus Walleij Aug. 22, 2012, 11:50 a.m. UTC | #1 
On Wed, Aug 22, 2012 at 10:44 AM, Linus Walleij
<linus.walleij@stericsson.com> wrote:

> ux500 machines performs pins (GPIO) reconfiguration when entering
> in the suspended mode. This reconfiguration aims at reaching an ultra
> low power HW configuration.

Sam, please disregard this patch.

Yours,
Linus Walleij
diff mbox

Patch

diff --git a/drivers/gpio/gpio-ab8500.c b/drivers/gpio/gpio-ab8500.c
index 050c05d..3d2cd66 100644
--- a/drivers/gpio/gpio-ab8500.c
+++ b/drivers/gpio/gpio-ab8500.c
@@ -203,6 +203,7 @@  static struct gpio_chip ab8500gpio_chip = {
 	.direction_output	= ab8500_gpio_direction_output,
 	.set			= ab8500_gpio_set,
 	.to_irq			= ab8500_gpio_to_irq,
+	.flags			= IRQCHIP_MASK_ON_SUSPEND,
 };
 
 static unsigned int irq_to_rising(unsigned int irq)