From patchwork Wed Aug 22 15:13:05 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 1362101 Return-Path: X-Original-To: patchwork-linux-arm@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork2.kernel.org Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) by patchwork2.kernel.org (Postfix) with ESMTP id 342EEDF280 for ; Wed, 22 Aug 2012 15:17:18 +0000 (UTC) Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.76 #1 (Red Hat Linux)) id 1T4Cck-0008DV-Sd; Wed, 22 Aug 2012 15:13:38 +0000 Received: from moutng.kundenserver.de ([212.227.126.187]) by merlin.infradead.org with esmtp (Exim 4.76 #1 (Red Hat Linux)) id 1T4Ccg-0008Cd-Qt for linux-arm-kernel@lists.infradead.org; Wed, 22 Aug 2012 15:13:35 +0000 Received: from localhost.localdomain (HSI-KBW-149-172-5-253.hsi13.kabel-badenwuerttemberg.de [149.172.5.253]) by mrelayeu.kundenserver.de (node=mrbap3) with ESMTP (Nemesis) id 0M9XvL-1SxILG3B4Z-00Cyud; Wed, 22 Aug 2012 17:13:30 +0200 From: Arnd Bergmann To: linux-arm-kernel@lists.infradead.org Subject: [PATCH 1/6] ARM: ux500: don't select LEDS_GPIO for snowball Date: Wed, 22 Aug 2012 17:13:05 +0200 Message-Id: <1345648390-4234-2-git-send-email-arnd@arndb.de> X-Mailer: git-send-email 1.7.10 In-Reply-To: <1345648390-4234-1-git-send-email-arnd@arndb.de> References: <1345648390-4234-1-git-send-email-arnd@arndb.de> X-Provags-ID: V02:K0:Y5kvlH3VNvcTPmjv21ZalAgS4o+wSe/DamZ0+PX/WB4 I8uz9CXEZ6TUt4hEMUwT6iU9BFzlts86KuZnP4hBgVmzDotK66 2z99jERAZJy49TDbW6YAiiSjnwCivrMoHTOTIYU7YslfAEEle1 JF6AmkF6HS36+KeNHm6rAPHZYgBgkqgTmt81BX3ZIpGSMSjHsE pag4Sb/D/jTQsp2mpEmderwvp/n/rrhlY3/SULJwLXVSZJMI9A inbx9n1uUoICgnQHqo3M9IBnJFWKAqgMcrFd+mvLd6i58VpMZR sfyPMSC6GMs1pFgWL+Ujk+wmArY2WFGe6lIyMuD5gKLGEbrSbh MjNJ6VN3SRY/fxjYdBXtTnxCyp9tQz/MJWvnV/vHHD7MlSCH6V +m7YBo0DTPEGg== X-Spam-Note: CRM114 invocation failed X-Spam-Score: -1.9 (-) X-Spam-Report: SpamAssassin version 3.3.2 on merlin.infradead.org summary: Content analysis details: (-1.9 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at http://www.dnswl.org/, no trust [212.227.126.187 listed in list.dnswl.org] -0.0 SPF_HELO_PASS SPF: HELO matches SPF record -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] Cc: Russell King , Linus Walleij , Lee Jones , linux-kernel@vger.kernel.org, Arnd Bergmann X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: linux-arm-kernel-bounces@lists.infradead.org Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org The gpio leds driver can only be built if the generic LED code is also enabled. Snowball selects LEDS_GPIO for an unknown reason but it does not select LEDS_CLASS and also does not really require the LED support at all, so we can just drop this dependency. Without this patch, building without LEDS_CLASS esults in: drivers/built-in.o: In function `create_gpio_led.part.2': governor_userspace.c:(.devinit.text+0x5a58): undefined reference to `led_classdev_register' drivers/built-in.o: In function `gpio_led_remove': governor_userspace.c:(.devexit.text+0x6b8): undefined reference to `led_classdev_unregister' This reverts 8733f53c6 "ARM: ux500: Kconfig: Compile in leds-gpio support for Snowball", which was not completely thought through. Signed-off-by: Arnd Bergmann Cc: Linus Walleij Cc: Lee Jones --- arch/arm/mach-ux500/Kconfig | 1 - 1 file changed, 1 deletion(-) diff --git a/arch/arm/mach-ux500/Kconfig b/arch/arm/mach-ux500/Kconfig index c013bbf..53d3d46 100644 --- a/arch/arm/mach-ux500/Kconfig +++ b/arch/arm/mach-ux500/Kconfig @@ -41,7 +41,6 @@ config MACH_HREFV60 config MACH_SNOWBALL bool "U8500 Snowball platform" select MACH_MOP500 - select LEDS_GPIO help Include support for the snowball development platform.