diff mbox

ARM: Build dtb files in all target

Message ID 1346218523-15958-1-git-send-email-andrew@lunn.ch (mailing list archive)
State New, archived
Headers show

Commit Message

Andrew Lunn Aug. 29, 2012, 5:35 a.m. UTC
Tools like kisskb are good at finding build regressions in the kernel
sources. However, regressions in the DT desscriptions are not found,
because generally these build systems don't build the DT binary blobs.

Extend the ARM all target to build all enabled DTB files.

Signed-off-by: Andrew Lunn <andrew@lunn.ch>
---
 arch/arm/Makefile |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Stephen Boyd Aug. 29, 2012, 7:20 a.m. UTC | #1
On 8/28/2012 10:35 PM, Andrew Lunn wrote:
> Tools like kisskb are good at finding build regressions in the kernel
> sources. However, regressions in the DT desscriptions are not found,
> because generally these build systems don't build the DT binary blobs.
>
> Extend the ARM all target to build all enabled DTB files.
>
> Signed-off-by: Andrew Lunn <andrew@lunn.ch>

You should probably put a star (*) next to the dtbs info in the help
text too.

Have you tried this in a clean tree? Also, should this only be default
true if USE_OF is true?
Andrew Lunn Aug. 30, 2012, 5:11 a.m. UTC | #2
On Wed, Aug 29, 2012 at 12:20:55AM -0700, Stephen Boyd wrote:
> On 8/28/2012 10:35 PM, Andrew Lunn wrote:
> > Tools like kisskb are good at finding build regressions in the kernel
> > sources. However, regressions in the DT desscriptions are not found,
> > because generally these build systems don't build the DT binary blobs.
> >
> > Extend the ARM all target to build all enabled DTB files.
> >
> > Signed-off-by: Andrew Lunn <andrew@lunn.ch>
> 
> You should probably put a star (*) next to the dtbs info in the help
> text too.

Will do. Version 2 to be posted soon.

> 
> Have you tried this in a clean tree?

I tested with
make distclean
make kirkwood_defconfig
make

Any other permutations you would like me to test?

> Also, should this only be default true if USE_OF is true?

Also in v2.

     Thanks
          Andrew
diff mbox

Patch

diff --git a/arch/arm/Makefile b/arch/arm/Makefile
index 30eae87..aee2b1e 100644
--- a/arch/arm/Makefile
+++ b/arch/arm/Makefile
@@ -268,7 +268,7 @@  else
 KBUILD_IMAGE := zImage
 endif
 
-all:	$(KBUILD_IMAGE)
+all:	$(KBUILD_IMAGE) dtbs
 
 boot := arch/arm/boot