| Message ID | 1347614754-26357-1-git-send-email-vbyravarasu@nvidia.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Friday 14 September 2012 02:55 PM, Venu Byravarasu wrote: > Adding pinmux entries for PI4 and PH7 to enable Vbus for USB1 > and USB3 controllers on Cardhu A02 board. > > Signed-off-by: Venu Byravarasu<vbyravarasu@nvidia.com> > --- Looks good. Acked-by: Laxman Dewangan <ldewangan@nvidia.com>
On 09/14/2012 03:25 AM, Venu Byravarasu wrote: > Adding pinmux entries for PI4 and PH7 to enable Vbus for USB1 > and USB3 controllers on Cardhu A02 board. > > Signed-off-by: Venu Byravarasu <vbyravarasu@nvidia.com> Given our internal discussions about whether to and how to configure open-drain and enable-input on these pins, I'd like to hold off on this patch. Lets resolve this internally first. Also, I assume we'll need an equivalent patch for Cardhu A04 too.
diff --git a/arch/arm/boot/dts/tegra30-cardhu-a02.dts b/arch/arm/boot/dts/tegra30-cardhu-a02.dts index dd4222f..b76ad31 100644 --- a/arch/arm/boot/dts/tegra30-cardhu-a02.dts +++ b/arch/arm/boot/dts/tegra30-cardhu-a02.dts @@ -8,6 +8,26 @@ model = "NVIDIA Tegra30 Cardhu A02 evaluation board"; compatible = "nvidia,cardhu-a02", "nvidia,cardhu", "nvidia,tegra30"; + pinmux { + gmi_rst_n_pi4 { + nvidia,pins = "gmi_rst_n_pi4"; + nvidia,function = "gmi"; + nvidia,tristate = <0>; + nvidia,enable-input = <1>; + nvidia,open-drain = <1>; + nvidia,pull = <0>; + }; + + gmi_ad15_ph7 { + nvidia,pins = "gmi_ad15_ph7"; + nvidia,function = "gmi"; + nvidia,tristate = <0>; + nvidia,enable-input = <1>; + nvidia,open-drain = <1>; + nvidia,pull = <0>; + }; + }; + regulators { compatible = "simple-bus"; #address-cells = <1>;
Adding pinmux entries for PI4 and PH7 to enable Vbus for USB1 and USB3 controllers on Cardhu A02 board. Signed-off-by: Venu Byravarasu <vbyravarasu@nvidia.com> --- arch/arm/boot/dts/tegra30-cardhu-a02.dts | 20 ++++++++++++++++++++ 1 files changed, 20 insertions(+), 0 deletions(-)