From patchwork Wed Sep 19 09:44:19 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Pawel Moll X-Patchwork-Id: 1476641 Return-Path: X-Original-To: patchwork-linux-arm@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork1.kernel.org Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) by patchwork1.kernel.org (Postfix) with ESMTP id 02B413FE4F for ; Wed, 19 Sep 2012 09:46:12 +0000 (UTC) Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.76 #1 (Red Hat Linux)) id 1TEGpZ-0006Uz-Bj; Wed, 19 Sep 2012 09:44:29 +0000 Received: from service87.mimecast.com ([91.220.42.44]) by merlin.infradead.org with esmtp (Exim 4.76 #1 (Red Hat Linux)) id 1TEGpU-0006S5-So for linux-arm-kernel@lists.infradead.org; Wed, 19 Sep 2012 09:44:25 +0000 Received: from cam-owa1.Emea.Arm.com (fw-tnat.cambridge.arm.com [217.140.96.21]) by service87.mimecast.com; Wed, 19 Sep 2012 10:44:20 +0100 Received: from [10.1.205.42] ([10.1.255.212]) by cam-owa1.Emea.Arm.com with Microsoft SMTPSVC(6.0.3790.0); Wed, 19 Sep 2012 10:44:19 +0100 Message-ID: <1348047859.11116.48.camel@hornet> Subject: Re: [PATCH 10/11] ARM: vexpress: Add config bus components and clocks to DTs From: Pawel Moll To: Rob Herring Date: Wed, 19 Sep 2012 10:44:19 +0100 In-Reply-To: <50463FA4.90106@gmail.com> References: <1346689531-7212-1-git-send-email-pawel.moll@arm.com> <1346689531-7212-11-git-send-email-pawel.moll@arm.com> <5045FAEC.6030906@gmail.com> <1346763920.2605.81.camel@hornet> <504610B4.6060902@gmail.com> <1346773023.20599.15.camel@hornet> <50463FA4.90106@gmail.com> X-Mailer: Evolution 3.2.3-0ubuntu6 Mime-Version: 1.0 X-OriginalArrivalTime: 19 Sep 2012 09:44:19.0541 (UTC) FILETIME=[57536850:01CD964B] X-MC-Unique: 112091910442101501 X-Spam-Note: CRM114 invocation failed X-Spam-Score: -2.6 (--) X-Spam-Report: SpamAssassin version 3.3.2 on merlin.infradead.org summary: Content analysis details: (-2.6 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at http://www.dnswl.org/, low trust [91.220.42.44 listed in list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] Cc: "arm@kernel.org" , "linux-arm-kernel@lists.infradead.org" X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linux-arm-kernel-bounces@lists.infradead.org Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org On Tue, 2012-09-04 at 18:51 +0100, Rob Herring wrote: > I did say they are *supposed* to be optional, but the amba bus code > essentially makes them required. Ideally, Linux doesn't dictate what > goes in the dtb or not, but I don't have a problem if specific users of > the clock binding require the names. Ok, so how about such change in wording? Also, maybe we could add a possibility of defining the APB clock for whole APB "cluster" (as usually the same clock is shared across all peripherals connected to a single AHB/APB bridge) using clock-ranges parents? What I think about is something of this sort: iofpga { clock-ranges; clocks = <&pclk>; clock-names = "apb_pclk"; serial { compatible = "arm,pl011", "arm,primecell"; clocks = <&refclk>; clock-names = "uartclk"; }; }; Cheers! Pawel --- a/Documentation/devicetree/bindings/arm/primecell.txt +++ b/Documentation/devicetree/bindings/arm/primecell.txt @@ -13,17 +13,18 @@ Required properties: Optional properties: - arm,primecell-periphid : Value to override the h/w value with -- clocks : From common clock binding. First clock is phandle to clock for apb - pclk. Additional clocks are optional and specific to those peripherals. -- clock-names : From common clock binding. Shall be "apb_pclk" for first clock. +- clocks : From common clock binding. One of the clocks should be a phandle to + clock for APB PCLK. Additional clocks are optional and specific to + those peripherals. +- clock-names : From common clock binding. Required here if clocks are + defined. Shall be "apb_pclk" for the APB PCLK. Example: serial@fff36000 { compatible = "arm,pl011", "arm,primecell"; arm,primecell-periphid = <0x00341011>; - clocks = <&pclk>; - clock-names = "apb_pclk"; - + clocks = <&refclk>, <&pclk>; + clock-names = "uartclk", "apb_pclk"; };