From patchwork Thu Oct 18 09:07:01 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Haojian Zhuang X-Patchwork-Id: 1608771 Return-Path: X-Original-To: patchwork-linux-arm@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork2.kernel.org Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) by patchwork2.kernel.org (Postfix) with ESMTP id D5FD7DFB34 for ; Thu, 18 Oct 2012 09:10:23 +0000 (UTC) Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.76 #1 (Red Hat Linux)) id 1TOm5C-00023N-7V; Thu, 18 Oct 2012 09:08:02 +0000 Received: from mail-pa0-f49.google.com ([209.85.220.49]) by merlin.infradead.org with esmtps (Exim 4.76 #1 (Red Hat Linux)) id 1TOm4Y-0001Um-5e for linux-arm-kernel@lists.infradead.org; Thu, 18 Oct 2012 09:07:23 +0000 Received: by mail-pa0-f49.google.com with SMTP id bi5so8418397pad.36 for ; Thu, 18 Oct 2012 02:07:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:x-mailer:in-reply-to:references; bh=yhKCv+lsMBE6dNlOMrJZvLmi1gl2kmROuWqgAzJXsdo=; b=vNK+FeoFS+jUWtk5pg/K+KghayIllmKCe/uNgAV1VK408pNsDwmTrm1j06Uir7lO/s KnrOEerr5DNW2u61StXsCQwRetpzdwLybCeuvT8CNmupKelr1OuWeP2dxEQTDHMHerqz RMC3l+1yfFh+YbD0OcUNPaLJCKbpnaCt5C6semu++antB1umfh8JR330cfdUN7HZPBvk kUDbvDKRFlFT9/H5XsmSjzhCnAQKUjfMqG4JU1E66BItpqZEPrWrNlr2zSDc1rNbMs7e 8aVBzhdGZrdzUH5WVFScRglr3dcBZW0jNSbAxp/TVfBt/DAiSjmsvgUdboQur+vC+wLU 1Uvg== Received: by 10.66.80.65 with SMTP id p1mr57573906pax.20.1350551241879; Thu, 18 Oct 2012 02:07:21 -0700 (PDT) Received: from localhost ([58.39.221.134]) by mx.google.com with ESMTPS id d2sm907497paw.19.2012.10.18.02.07.17 (version=TLSv1/SSLv3 cipher=OTHER); Thu, 18 Oct 2012 02:07:20 -0700 (PDT) From: Haojian Zhuang To: linux-arm-kernel@lists.infradead.org, arnd@arndb.de, linus.walleij@linaro.org, tony@atomide.com, devicetree-discuss@lists.ozlabs.org Subject: [PATCH 07/10] pinctrl: remove mutex lock in groups show Date: Thu, 18 Oct 2012 17:07:01 +0800 Message-Id: <1350551224-12857-7-git-send-email-haojian.zhuang@gmail.com> X-Mailer: git-send-email 1.7.9.5 In-Reply-To: <1350551224-12857-1-git-send-email-haojian.zhuang@gmail.com> References: <1350551224-12857-1-git-send-email-haojian.zhuang@gmail.com> X-Spam-Note: CRM114 invocation failed X-Spam-Score: -2.7 (--) X-Spam-Report: SpamAssassin version 3.3.2 on merlin.infradead.org summary: Content analysis details: (-2.7 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at http://www.dnswl.org/, low trust [209.85.220.49 listed in list.dnswl.org] 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (haojian.zhuang[at]gmail.com) -0.0 SPF_PASS SPF: sender matches SPF record -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature Cc: Haojian Zhuang X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: linux-arm-kernel-bounces@lists.infradead.org Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org Mutex is locked duplicatly by pinconf_groups_show() and pin_config_group_get(). It results dead lock. So avoid to lock mutex in pinconf_groups_show(). Signed-off-by: Haojian Zhuang --- drivers/pinctrl/pinconf.c | 4 ---- 1 files changed, 0 insertions(+), 4 deletions(-) diff --git a/drivers/pinctrl/pinconf.c b/drivers/pinctrl/pinconf.c index 43f474c..baee2cc 100644 --- a/drivers/pinctrl/pinconf.c +++ b/drivers/pinctrl/pinconf.c @@ -537,8 +537,6 @@ static int pinconf_groups_show(struct seq_file *s, void *what) seq_puts(s, "Pin config settings per pin group\n"); seq_puts(s, "Format: group (name): configs\n"); - mutex_lock(&pinctrl_mutex); - while (selector < ngroups) { const char *gname = pctlops->get_group_name(pctldev, selector); @@ -549,8 +547,6 @@ static int pinconf_groups_show(struct seq_file *s, void *what) selector++; } - mutex_unlock(&pinctrl_mutex); - return 0; }